Skip to content

Commit 403d0f5

Browse files
committed
fix: address PR feedback on null handling
1 parent e93879c commit 403d0f5

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

src/deploy/functions/build.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -604,7 +604,7 @@ function discoverTrigger(endpoint: Endpoint, region: string, r: Resolver): backe
604604
} else if (endpoint.scheduleTrigger.retryConfig === null) {
605605
bkSchedule.retryConfig = null;
606606
}
607-
if (endpoint.scheduleTrigger.attemptDeadlineSeconds) {
607+
if (typeof endpoint.scheduleTrigger.attemptDeadlineSeconds !== "undefined") {
608608
bkSchedule.attemptDeadlineSeconds = r.resolveInt(
609609
endpoint.scheduleTrigger.attemptDeadlineSeconds,
610610
);

src/gcp/cloudscheduler.ts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -262,11 +262,13 @@ export async function jobFromEndpoint(
262262
);
263263
}
264264
job.schedule = endpoint.scheduleTrigger.schedule;
265-
if (endpoint.scheduleTrigger.attemptDeadlineSeconds) {
266-
job.attemptDeadline = proto.durationFromSeconds(
267-
endpoint.scheduleTrigger.attemptDeadlineSeconds,
268-
);
269-
}
265+
proto.convertIfPresent(
266+
job,
267+
endpoint.scheduleTrigger,
268+
"attemptDeadline",
269+
"attemptDeadlineSeconds",
270+
nullsafeVisitor(proto.durationFromSeconds),
271+
);
270272
if (endpoint.scheduleTrigger.retryConfig) {
271273
job.retryConfig = {};
272274
proto.copyIfPresent(

0 commit comments

Comments
 (0)