[VS Code] Always show "Generate Operation" code lens (#9233)

* Always show generate code lens

* ensure there is a new line before inserted query

Author: fredzqm

firebase-vscode/src/data-connect/code-lens-provider.ts

@@ -123,32 +123,30 @@ export class OperationCodeLensProvider extends ComputedCodeLensProvider {
       }
     }
 
-    if (projectId) {
-      const comments = findCommentsBlocks(documentText);
-      for (let i = 0; i < comments.length; i++) {
-        const c = comments[i];
-        const range = new vscode.Range(c.startLine, 0, c.startLine, 0);
-        const queryDoc = documentNode.definitions.find((d) =>
-          d.kind === Kind.OPERATION_DEFINITION && 
-          // startToken.line is 1-indexed, endLine is 0-indexed
-          d.loc?.startToken.line === c.endLine + 2
-        );
-        const arg: GenerateOperationInput = {
-          projectId,
-          document: document,
-          description: c.text,
-          insertPosition: c.endIndex + 1,
-          existingQuery: queryDoc?.loc ? documentText.substring(c.endIndex + 1, queryDoc.loc.endToken.end) : '',
-        };
-        codeLenses.push(
-          new vscode.CodeLens(range, {
-            title: queryDoc ? `$(sparkle) Refine Operation` : `$(sparkle) Generate Operation`,
-            command: "firebase.dataConnect.generateOperation",
-            tooltip: "Generate the operation (⌘+enter or Ctrl+Enter)",
-            arguments: [arg],
-          }),
-        );
-      }
+    const comments = findCommentsBlocks(documentText);
+    for (let i = 0; i < comments.length; i++) {
+      const c = comments[i];
+      const range = new vscode.Range(c.startLine, 0, c.startLine, 0);
+      const queryDoc = documentNode.definitions.find((d) =>
+        d.kind === Kind.OPERATION_DEFINITION &&
+        // startToken.line is 1-indexed, endLine is 0-indexed
+        d.loc?.startToken.line === c.endLine + 2
+      );
+      const arg: GenerateOperationInput = {
+        projectId,
+        document: document,
+        description: c.text,
+        insertPosition: c.endIndex + 1,
+        existingQuery: queryDoc?.loc ? documentText.substring(c.endIndex + 1, queryDoc.loc.endToken.end) : '',
+      };
+      codeLenses.push(
+        new vscode.CodeLens(range, {
+          title: queryDoc ? `$(sparkle) Refine Operation` : `$(sparkle) Generate Operation`,
+          command: "firebase.dataConnect.generateOperation",
+          tooltip: "Generate the operation (⌘+enter or Ctrl+Enter)",
+          arguments: [arg],
+        }),
+      );
     }
     return codeLenses;
   }

firebase-vscode/src/data-connect/execution/execution.ts

@@ -53,7 +53,7 @@ interface ExecutionInput {
 }
 
 export interface GenerateOperationInput {
-  projectId: string;
+  projectId?: string;
   document: vscode.TextDocument;
   description: string;
   insertPosition: number;
@@ -314,6 +314,10 @@ export function registerExecution(
   }
 
   async function generateOperation(arg: GenerateOperationInput) {
+    if (!arg.projectId) {
+      vscode.window.showErrorMessage(`Connect a Firebase project to use Gemini in Firebase features.`);
+      return;
+    }
     try {
       const schema = await dataConnectService.schema();
       const prompt = `Generate a Data Connect operation to match this description: ${arg.description} 

firebase-vscode/src/data-connect/file-utils.ts

@@ -59,17 +59,16 @@ export async function insertQueryAt(uri: vscode.Uri, at: number, existing: strin
   const doc = await vscode.workspace.openTextDocument(uri);
   const text = doc.getText();
   if (!existing) {
+    if (text[at-1] !== "\n") {
+      replace = "\n" + replace;
+    }
     const newText = text.slice(0, at) + replace + text.slice(at);
     await vscode.workspace.fs.writeFile(uri, new TextEncoder().encode(newText));
     return;
   }
   if (text.slice(at, at + existing.length) !== existing) {
     throw new Error("The existing query was updated.");
   }
-  // Adds a new line before if inserting at the end of the file
-  if (at > text.length) {
-    replace = "\n" + replace;
-  }
   const newText = text.slice(0, at) + replace + text.slice(at + existing.length);
   await vscode.workspace.fs.writeFile(uri, new TextEncoder().encode(newText));
 }