Skip to content

Commit 587e0bb

Browse files
authored
Respect configured timeout on storage emulator integration test (#8889)
* Respect configured timeout on storage emulator integration test * Lint and extend timeout
1 parent 533265e commit 587e0bb

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

scripts/storage-emulator-integration/conformance/persistence.test.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,10 @@ describe("Storage persistence conformance tests", () => {
6262
devtools: true,
6363
});
6464
page = await browser.newPage();
65-
await page.goto("https://example.com", { waitUntil: "networkidle2" });
65+
await page.goto("https://example.com", {
66+
waitUntil: "networkidle2",
67+
timeout: TEST_SETUP_TIMEOUT - 5000,
68+
});
6669
await page.addScriptTag({
6770
url: "https://www.gstatic.com/firebasejs/9.9.1/firebase-app-compat.js",
6871
});

scripts/storage-emulator-integration/utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { FrameworkOptions } from "../integration-helpers/framework";
77
const { google } = require("googleapis");
88

99
/* Various delays needed when integration test spawns parallel emulator subprocesses. */
10-
export const TEST_SETUP_TIMEOUT = 60000;
10+
export const TEST_SETUP_TIMEOUT = 120000;
1111
export const EMULATORS_SHUTDOWN_DELAY_MS = 5000;
1212
export const SMALL_FILE_SIZE = 200 * 1024; /* 200 kB */
1313
// Firebase Emulator config, for starting up emulators

0 commit comments

Comments
 (0)