fix: Force upload for non-ACTIVE functions to prevent GCFv2 update failure (#9456)

* Fix: Force upload for non-ACTIVE functions to prevent GCFv2 update failure

When a GCFv2 function is in a FAILED state but the local source code hasn't changed, the CLI previously skipped the source upload. This caused the subsequent update operation to fail with 'Precondition failed' because it lacked the required storage source information.

This change ensures that source upload is only skipped if the existing function is in an ACTIVE state, forcing a re-upload and allowing repair of FAILED functions.

* Add changelog entry for GCFv2 precondition fix

* Refactor: Remove duplicate test case in deploy.spec.ts

Author: taeold

CHANGELOG.md

@@ -1,2 +1,3 @@
 - [Added] support for new google-genai plugin during `init genkit` (#8957)
 - Updated to v2.17.1 of the Data Connect emulator, which fixes an admin SDK bug for operation without argument #9449 (#9454).
+- Fixed "Precondition failed" error when updating GCFv2 functions in a FAILED state without code changes.

src/deploy/functions/deploy.spec.ts

@@ -66,11 +66,13 @@ describe("deploy", () => {
       haveBackend = backend.of(endpoint1InHaveBackend, endpoint2InHaveBackend);
     });
 
-    it("should skip if all endpoints are identical", () => {
+    it("should skip if all endpoints are identical and ACTIVE", () => {
       endpoint1InWantBackend.hash = "1";
       endpoint2InWantBackend.hash = "2";
       endpoint1InHaveBackend.hash = endpoint1InWantBackend.hash;
       endpoint2InHaveBackend.hash = endpoint2InWantBackend.hash;
+      endpoint1InHaveBackend.state = "ACTIVE";
+      endpoint2InHaveBackend.state = "ACTIVE";
 
       // Execute
       const result = deploy.shouldUploadBeSkipped(CONTEXT, wantBackend, haveBackend);
@@ -140,6 +142,19 @@ describe("deploy", () => {
       // Expect
       expect(result).to.be.false;
     });
+
+    it("should not skip if state is not ACTIVE", () => {
+      endpoint1InWantBackend.hash = "1";
+      endpoint2InWantBackend.hash = "2";
+      endpoint1InHaveBackend.hash = endpoint1InWantBackend.hash;
+      endpoint2InHaveBackend.hash = endpoint2InWantBackend.hash;
+      endpoint1InHaveBackend.state = "ACTIVE";
+      endpoint2InHaveBackend.state = "FAILED";
+
+      const result = deploy.shouldUploadBeSkipped(CONTEXT, wantBackend, haveBackend);
+
+      expect(result).to.be.false;
+    });
   });
 
   describe("uploadSourceV2", () => {

src/deploy/functions/deploy.ts

@@ -221,6 +221,11 @@ export function shouldUploadBeSkipped(
     if (!haveEndpoint) {
       return false;
     }
-    return haveEndpoint.hash && wantEndpoint.hash && haveEndpoint.hash === wantEndpoint.hash;
+    return (
+      haveEndpoint.hash &&
+      wantEndpoint.hash &&
+      haveEndpoint.hash === wantEndpoint.hash &&
+      haveEndpoint.state === "ACTIVE"
+    );
   });
 }