Fix extension hanging during Firebase Init (#7630)

hlshen · rrousselGit · web-flow · commit 626bdcea3a40 · 2024-09-10T00:14:46.000Z
* remove requireAuthWrapper loop

* changelog

* Update firebase-vscode/src/cli.ts

Co-authored-by: Remi Rousselet &lt;darky12s@gmail.com&gt;

* Apply suggestions from code review

Co-authored-by: Remi Rousselet &lt;darky12s@gmail.com&gt;

---------

Co-authored-by: Remi Rousselet &lt;darky12s@gmail.com&gt;
diff --git a/firebase-vscode/CHANGELOG.md b/firebase-vscode/CHANGELOG.md
@@ -1,5 +1,7 @@
 ## NEXT
 
+- [Fixed] Extension properly picks up firebase.json changes during Firebase Init flow
+
 ## 0.7.0
 
 - Updated internal firebase-tools dependency to 13.16.0
diff --git a/firebase-vscode/src/cli.ts b/firebase-vscode/src/cli.ts
@@ -131,10 +131,6 @@ export async function login() {
 }
 
 export async function listProjects() {
-  const loggedInUser = await requireAuthWrapper(false);
-  if (!loggedInUser) {
-    return [];
-  }
   return listFirebaseProjects();
 }
 
diff --git a/firebase-vscode/src/core/user.ts b/firebase-vscode/src/core/user.ts
@@ -17,7 +17,7 @@ export const isServiceAccount = computed(() => {
 });
 
 export async function checkLogin() {
-    return await requireAuthWrapper();
+  return await requireAuthWrapper();
 }
 
 export function registerUser(broker: ExtensionBrokerImpl, telemetryLogger: TelemetryLogger): Disposable {

Original file line number	Diff line number	Diff line change
`@@ -131,10 +131,6 @@ export async function login() {`
`131`	`131`	`}`
`132`	`132`
`133`	`133`	`export async function listProjects() {`
`134`		`- const loggedInUser = await requireAuthWrapper(false);`
`135`		`- if (!loggedInUser) {`
`136`		`- return [];`
`137`		`- }`
`138`	`134`	`return listFirebaseProjects();`
`139`	`135`	`}`
`140`	`136`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ export const isServiceAccount = computed(() => {`
`17`	`17`	`});`
`18`	`18`
`19`	`19`	`export async function checkLogin() {`
`20`		`- return await requireAuthWrapper();`
	`20`	`+ return await requireAuthWrapper();`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`export function registerUser(broker: ExtensionBrokerImpl, telemetryLogger: TelemetryLogger): Disposable {`