Skip to content

Commit 8894222

Browse files
authored
Disable broken VSCode integration tests (#8934)
1 parent 7e2a6e3 commit 8894222

File tree

1 file changed

+57
-57
lines changed

1 file changed

+57
-57
lines changed

.github/workflows/node-test.yml

Lines changed: 57 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -67,63 +67,63 @@ jobs:
6767
- uses: codecov/codecov-action@v3
6868
if: matrix.node-version == '20'
6969

70-
vscode_integration:
71-
runs-on: macos-latest
72-
strategy:
73-
matrix:
74-
node-version:
75-
- "20"
76-
77-
env:
78-
FIREBASE_EMULATORS_PATH: ${{ github.workspace }}/emulator-cache
79-
# This overrides the binary which runs firebase commands in the extension tasks such as emulator start.
80-
# Currently, CI fails to start with npx so we change it to the global firebase binary.
81-
FIREBASE_BINARY: firebase
82-
83-
steps:
84-
- name: Setup Java JDK
85-
uses: actions/[email protected]
86-
with:
87-
java-version: 17
88-
distribution: temurin
89-
90-
- uses: actions/checkout@v4
91-
- name: Setup Chrome
92-
uses: browser-actions/[email protected]
93-
with:
94-
install-dependencies: true
95-
install-chromedriver: true
96-
- uses: actions/setup-node@v3
97-
with:
98-
node-version: ${{ matrix.node-version }}
99-
cache: npm
100-
cache-dependency-path: firebase-vscode/package-lock.json
101-
102-
# TODO temporary workaround for GitHub Actions CI issue:
103-
# npm ERR! Your cache folder contains root-owned files, due to a bug in
104-
# npm ERR! previous versions of npm which has since been addressed.
105-
- run: sudo chown -R 501:20 "/Users/runner/.npm" || exit 1
106-
- run: npm ci
107-
- run: npm install
108-
working-directory: firebase-vscode
109-
- run: npm run build
110-
working-directory: firebase-vscode
111-
112-
- run: npm i -g firebase-tools@latest
113-
114-
- uses: GabrielBB/xvfb-action@v1
115-
with:
116-
run: npm run test:e2e
117-
working-directory: firebase-vscode
118-
119-
- uses: actions/upload-artifact@v4
120-
if: failure()
121-
with:
122-
name: screenshots
123-
path: firebase-vscode/src/test/screenshots
124-
125-
- uses: codecov/codecov-action@v3
126-
if: matrix.node-version == '20'
70+
# vscode_integration:
71+
# runs-on: macos-latest
72+
# strategy:
73+
# matrix:
74+
# node-version:
75+
# - "20"
76+
77+
# env:
78+
# FIREBASE_EMULATORS_PATH: ${{ github.workspace }}/emulator-cache
79+
# # This overrides the binary which runs firebase commands in the extension tasks such as emulator start.
80+
# # Currently, CI fails to start with npx so we change it to the global firebase binary.
81+
# FIREBASE_BINARY: firebase
82+
83+
# steps:
84+
# - name: Setup Java JDK
85+
# uses: actions/[email protected]
86+
# with:
87+
# java-version: 17
88+
# distribution: temurin
89+
90+
# - uses: actions/checkout@v4
91+
# - name: Setup Chrome
92+
# uses: browser-actions/[email protected]
93+
# with:
94+
# install-dependencies: true
95+
# install-chromedriver: true
96+
# - uses: actions/setup-node@v3
97+
# with:
98+
# node-version: ${{ matrix.node-version }}
99+
# cache: npm
100+
# cache-dependency-path: firebase-vscode/package-lock.json
101+
102+
# # TODO temporary workaround for GitHub Actions CI issue:
103+
# # npm ERR! Your cache folder contains root-owned files, due to a bug in
104+
# # npm ERR! previous versions of npm which has since been addressed.
105+
# - run: sudo chown -R 501:20 "/Users/runner/.npm" || exit 1
106+
# - run: npm ci
107+
# - run: npm install
108+
# working-directory: firebase-vscode
109+
# - run: npm run build
110+
# working-directory: firebase-vscode
111+
112+
# - run: npm i -g firebase-tools@latest
113+
114+
# - uses: GabrielBB/xvfb-action@v1
115+
# with:
116+
# run: npm run test:e2e
117+
# working-directory: firebase-vscode
118+
119+
# - uses: actions/upload-artifact@v4
120+
# if: failure()
121+
# with:
122+
# name: screenshots
123+
# path: firebase-vscode/src/test/screenshots
124+
125+
# - uses: codecov/codecov-action@v3
126+
# if: matrix.node-version == '20'
127127

128128
unit:
129129
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)