Add no-undeclared-imports eslint rule (#8017)

* Add no-undeclared-imports eslint rule

* fix build breakage

Author: joehan

.eslintrc.js

@@ -20,7 +20,16 @@ module.exports = {
     "require-atomic-updates": "off", // This rule is so noisy and isn't useful: https://github.com/eslint/eslint/issues/11899
     "require-jsdoc": "off", // This rule is deprecated and superseded by jsdoc/require-jsdoc.
     "valid-jsdoc": "off", // This is deprecated but included in recommended configs.
-
+    "brikke/no-undeclared-imports": [
+      "error",
+      {
+        excludedFilePatterns: ["**/scripts/**/*", `update-notifier-cjs.d.ts`],
+        excludedModules: [
+          /node:/,
+          "express-serve-static-core", // We rely on just the types, and the package breaks our build.
+        ],
+      },
+    ],
     "no-prototype-builtins": "warn", // TODO(bkendall): remove, allow to error.
     "no-useless-escape": "warn", // TODO(bkendall): remove, allow to error.
     "prefer-promise-reject-errors": "warn", // TODO(bkendall): remove, allow to error.
@@ -107,7 +116,7 @@ module.exports = {
     sourceType: "module",
     warnOnUnsupportedTypeScriptVersion: false,
   },
-  plugins: ["prettier", "@typescript-eslint", "jsdoc"],
+  plugins: ["prettier", "@typescript-eslint", "jsdoc", "brikke"],
   settings: {
     jsdoc: {
       tagNamePreference: {

npm-shrinkwrap.json

@@ -225,6 +225,7 @@
     "eslint": "^8.56.0",
     "eslint-config-google": "^0.14.0",
     "eslint-config-prettier": "^9.1.0",
+    "eslint-plugin-brikke": "^2.2.2",
     "eslint-plugin-jsdoc": "^48.0.1",
     "eslint-plugin-prettier": "^5.1.3",
     "firebase": "^9.16.0",
@@ -240,6 +241,7 @@
     "nyc": "^15.1.0",
     "openapi-merge": "^1.0.23",
     "openapi-typescript": "^4.5.0",
+    "openapi3-ts": "^3.2.0",
     "prettier": "^3.2.4",
     "proxy": "^1.0.2",
     "puppeteer": "^19.0.0",

package.json

@@ -16,7 +16,7 @@ import { parseObjectUploadMultipartRequest } from "../multipart";
 import { Upload, UploadNotActiveError } from "../upload";
 import { ForbiddenError, NotFoundError } from "../errors";
 import { reqBodyToBuffer } from "../../shared/request";
-import { Query } from "express-serve-static-core";
+import type { Query } from "express-serve-static-core";
 
 export function createCloudEndpoints(emulator: StorageEmulator): Router {
   // eslint-disable-next-line new-cap