Combine auth_disable_user and auth_set_claims into auth_update_user (#9166)

* Deleted `src/mcp/tools/auth/disable_user.ts`, `src/mcp/tools/auth/disable_user.spec.ts`, `src/mcp/tools/auth/set_claims.ts`, and `src/mcp/tools/auth/set_claims.spec.ts`.

This indicates that my refactoring did not break any existing functionality.

I have created the new spec file at `src/mcp/tools/auth/update_user.spec.ts` with a basic test structure.

I have added a comprehensive suite of tests to `src/mcp/tools/auth/update_user.spec.ts` to cover all the functionality of the new tool.

* Cleaning up unit tests

* Fixing tests

* PR suggestions

* PR fixes

* Few changes

* Name update

* Name update

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: Joe Hanley <[email protected]>
Co-authored-by: Alexander Nohe <[email protected]>

Author: 3 people

src/gcp/auth.spec.ts

@@ -189,7 +189,7 @@ describe("auth", () => {
         })
         .reply(200, {});
 
-      const result = await auth.disableUser(PROJECT_ID, "test-uid", true);
+      const result = await auth.toggleUserEnablement(PROJECT_ID, "test-uid", true);
 
       expect(result).to.be.true;
       expect(nock.isDone()).to.be.true;
@@ -204,7 +204,9 @@ describe("auth", () => {
         })
         .reply(404, { error: { message: "Not Found" } });
 
-      await expect(auth.disableUser(PROJECT_ID, "test-uid", true)).to.be.rejectedWith("Not Found");
+      await expect(auth.toggleUserEnablement(PROJECT_ID, "test-uid", true)).to.be.rejectedWith(
+        "Not Found",
+      );
       expect(nock.isDone()).to.be.true;
     });
   });

src/gcp/auth.ts

@@ -200,7 +200,7 @@ export async function listUsers(project: string, limit: number): Promise<UserInf
  * @param disabled sets whether the user is marked as disabled (true) or enabled (false).
  * @return the call succeeded (true).
  */
-export async function disableUser(
+export async function toggleUserEnablement(
   project: string,
   uid: string,
   disabled: boolean,

src/mcp/tools/auth/disable_user.spec.ts

@@ -1,7 +1,6 @@
 import { ServerTool } from "../../tool";
+import { update_user } from "./update_user";
 import { get_users } from "./get_users";
-import { disable_user } from "./disable_user";
-import { set_claim } from "./set_claims";
 import { set_sms_region_policy } from "./set_sms_region_policy";
 
-export const authTools: ServerTool[] = [get_users, disable_user, set_claim, set_sms_region_policy];
+export const authTools: ServerTool[] = [get_users, update_user, set_sms_region_policy];

src/mcp/tools/auth/disable_user.ts

@@ -0,0 +1,106 @@
+import { expect } from "chai";
+import * as sinon from "sinon";
+import { update_user } from "./update_user";
+import * as auth from "../../../gcp/auth";
+import { McpContext } from "../../types";
+import * as util from "../../util";
+
+describe("update_user tool", () => {
+  const projectId = "test-project";
+  let setCustomClaimsStub: sinon.SinonStub;
+  let toggleuserEnablementStub: sinon.SinonStub;
+  let mcpErrorStub: sinon.SinonStub;
+
+  beforeEach(() => {
+    setCustomClaimsStub = sinon.stub(auth, "setCustomClaim");
+    toggleuserEnablementStub = sinon.stub(auth, "toggleUserEnablement");
+    mcpErrorStub = sinon.stub(util, "mcpError");
+  });
+
+  afterEach(() => {
+    sinon.restore();
+  });
+
+  it("should disable a user", async () => {
+    toggleuserEnablementStub.resolves(true);
+
+    const result = await update_user.fn({ uid: "123", disabled: true }, {
+      projectId,
+    } as McpContext);
+
+    expect(result).to.deep.equal({
+      content: [
+        {
+          text: "Successfully updated user 123. User disabled.",
+          type: "text",
+        },
+      ],
+    });
+    expect(toggleuserEnablementStub).to.have.been.calledWith(projectId, "123", true);
+    expect(setCustomClaimsStub).to.not.have.been.called;
+  });
+
+  it("should enable a user", async () => {
+    toggleuserEnablementStub.resolves(true);
+
+    const result = await update_user.fn({ uid: "123", disabled: false }, {
+      projectId,
+    } as McpContext);
+
+    expect(result).to.deep.equal({
+      content: [
+        {
+          text: "Successfully updated user 123. User enabled.",
+          type: "text",
+        },
+      ],
+    });
+    expect(toggleuserEnablementStub).to.have.been.calledWith(projectId, "123", false);
+    expect(setCustomClaimsStub).to.not.have.been.called;
+  });
+
+  it("should set a custom claim", async () => {
+    setCustomClaimsStub.resolves({ uid: "123", customClaims: { admin: true } });
+
+    const result = await update_user.fn(
+      {
+        uid: "123",
+        claim: { key: "admin", value: true },
+      },
+      {
+        projectId,
+      } as McpContext,
+    );
+
+    expect(result).to.deep.equal({
+      content: [
+        {
+          text: "Successfully updated user 123. Claim 'admin' set.",
+          type: "text",
+        },
+      ],
+    });
+    expect(setCustomClaimsStub).to.have.been.calledWith(projectId, "123", { admin: true });
+    expect(toggleuserEnablementStub).to.not.have.been.called;
+  });
+
+  it("should fail to set a custom claim and disable a user", async () => {
+    setCustomClaimsStub.resolves({ uid: "123", customClaims: { admin: true } });
+    toggleuserEnablementStub.resolves(true);
+
+    await update_user.fn(
+      {
+        uid: "123",
+        claim: { key: "admin", value: true },
+        disabled: true,
+      },
+      {
+        projectId,
+      } as McpContext,
+    );
+
+    expect(mcpErrorStub).to.be.calledWith(
+      "Can only enable/disable a user or set a claim, not both.",
+    );
+  });
+});