review round 1: use path.join, fix mismatched url

Author: oleina

src/mcp/tools/database/get_data.ts

@@ -4,6 +4,7 @@ import { mcpError, toContent } from "../../util";
 import * as url from "node:url";
 import { Client } from "../../../apiv2";
 import { text } from "node:stream/consumers";
+import path from "node:path";
 
 export const get_data = tool(
   {
@@ -14,7 +15,7 @@ export const get_data = tool(
         .string()
         .optional()
         .describe(
-          "connect to the database at url. If omitted, use default database instance <project>-default-rtdb.firebaseio.com. Can point to emulator URL (e.g. localhost:6000/<instance>)",
+          "connect to the database at url. If omitted, use default database instance <project>-default-rtdb.firebasedatabase.app. Can point to emulator URL (e.g. localhost:6000/<instance>)",
         ),
       path: z.string().describe("The path to the data to read. (ex: /my/cool/path)"),
     }),
@@ -32,23 +33,26 @@ export const get_data = tool(
       requiresProject: false,
     },
   },
-  async ({ path, databaseUrl }, { projectId, host }) => {
-    if (!path.startsWith("/")) {
-      return mcpError(`paths must start with '/' (you passed ''${path}')`);
+  async ({ path: getPath, databaseUrl }, { projectId, host }) => {
+    if (!getPath.startsWith("/")) {
+      return mcpError(`paths must start with '/' (you passed ''${getPath}')`);
     }
 
     const dbUrl = new url.URL(
       databaseUrl
-        ? `${databaseUrl}/${path}.json`
-        : `https://${projectId}-default-rtdb.us-central1.firebasedatabase.app/${path}.json`,
+        ? `${databaseUrl}/${getPath}.json`
+        : path.join(
+            `https://${projectId}-default-rtdb.us-central1.firebasedatabase.app`,
+            `${getPath}.json`,
+          ),
     );
 
     const client = new Client({
       urlPrefix: dbUrl.origin,
       auth: true,
     });
 
-    host.logger.debug(`sending read request to path '${path}' for url '${dbUrl.toString()}'`);
+    host.logger.debug(`sending read request to path '${getPath}' for url '${dbUrl.toString()}'`);
 
     const res = await client.request<unknown, NodeJS.ReadableStream>({
       method: "GET",

src/mcp/tools/database/set_data.ts

@@ -5,6 +5,7 @@ import * as url from "node:url";
 import { stringToStream } from "../../../utils";
 import { Client } from "../../../apiv2";
 import { getErrMsg } from "../../../error";
+import path from "node:path";
 
 export const set_data = tool(
   {
@@ -15,7 +16,7 @@ export const set_data = tool(
         .string()
         .optional()
         .describe(
-          "connect to the database at url. If omitted, use default database instance <project>-default-rtdb.firebaseio.com. Can point to emulator URL (e.g. localhost:6000/<instance>)",
+          "connect to the database at url. If omitted, use default database instance <project>-default-rtdb.us-central1.firebasedatabase.app. Can point to emulator URL (e.g. localhost:6000/<instance>)",
         ),
       path: z.string().describe("The path to the data to read. (ex: /my/cool/path)"),
       data: z.string().describe('The JSON to write. (ex: {"alphabet": ["a", "b", "c"]})'),
@@ -31,15 +32,18 @@ export const set_data = tool(
       requiresProject: false,
     },
   },
-  async ({ path, databaseUrl, data }, { projectId, host }) => {
-    if (!path.startsWith("/")) {
-      return mcpError(`paths must start with '/' (you passed ''${path}')`);
+  async ({ path: setPath, databaseUrl, data }, { projectId, host }) => {
+    if (!setPath.startsWith("/")) {
+      return mcpError(`paths must start with '/' (you passed ''${setPath}')`);
     }
 
     const dbUrl = new url.URL(
       databaseUrl
-        ? `${databaseUrl}/${path}.json`
-        : `https://${projectId}-default-rtdb.us-central1.firebasedatabase.app/${path}.json`,
+        ? `${databaseUrl}/${setPath}.json`
+        : path.join(
+            `https://${projectId}-default-rtdb.us-central1.firebasedatabase.app`,
+            `${setPath}.json`,
+          ),
     );
 
     const client = new Client({
@@ -49,7 +53,7 @@ export const set_data = tool(
 
     const inStream = stringToStream(data);
 
-    host.logger.debug(`sending write request to path '${path}' for url '${dbUrl.toString()}'`);
+    host.logger.debug(`sending write request to path '${setPath}' for url '${dbUrl.toString()}'`);
 
     try {
       await client.request({