turtle onboarding fixes (#6781)

* fixes for initializing turtles

* fix up tests to be better

* fix delete command

* capture specific error status

* revert test file

* formatting is hard

Author: bkendall

src/commands/apphosting-backends-delete.ts

@@ -20,16 +20,14 @@ const TABLE_HEAD = [
   "Updated Date",
 ];
 
-export const command = new Command("apphosting:backends:delete")
-  .description("Delete a backend from a Firebase project")
+export const command = new Command("apphosting:backends:delete <backend>")
+  .description("delete a backend from a Firebase project")
   .option("-l, --location <location>", "App Backend location", "")
-  .option("-s, --backend <backend>", "Backend Id", "")
   .withForce()
   .before(apphosting.ensureApiEnabled)
-  .action(async (options: Options) => {
+  .action(async (backendId: string, options: Options) => {
     const projectId = needProjectId(options);
     let location = options.location as string;
-    const backendId = options.backend as string;
     if (!backendId) {
       throw new FirebaseError("Backend id can't be empty.");
     }

src/gcp/apphosting.ts

@@ -399,6 +399,7 @@ export async function createRollout(
   backendId: string,
   rolloutId: string,
   rollout: DeepOmit<Rollout, RolloutOutputOnlyFields | "name">,
+  validateOnly = false,
 ): Promise<Operation> {
   const res = await client.post<DeepOmit<Rollout, RolloutOutputOnlyFields | "name">, Operation>(
     `projects/${projectId}/locations/${location}/backends/${backendId}/rollouts`,
@@ -409,7 +410,7 @@ export async function createRollout(
         ...deploymentTool.labels(),
       },
     },
-    { queryParams: { rolloutId } },
+    { queryParams: { rolloutId, validateOnly: validateOnly ? "true" : "false" } },
   );
   return res.body;
 }

src/init/features/apphosting/index.ts

@@ -1,4 +1,5 @@
 import * as clc from "colorette";
+
 import * as repo from "./repo";
 import * as poller from "../../../operation-poller";
 import * as apphosting from "../../../gcp/apphosting";
@@ -204,9 +205,44 @@ export async function orchestrateRollout(
   const buildId = await apphosting.getNextRolloutId(projectId, location, backendId, 1);
   const buildOp = await apphosting.createBuild(projectId, location, backendId, buildId, buildInput);
 
-  const rolloutOp = await apphosting.createRollout(projectId, location, backendId, buildId, {
+  const rolloutBody = {
     build: `projects/${projectId}/locations/${location}/backends/${backendId}/builds/${buildId}`,
-  });
+  };
+
+  let tries = 0;
+  let done = false;
+  while (!done) {
+    tries++;
+    try {
+      const validateOnly = true;
+      await apphosting.createRollout(
+        projectId,
+        location,
+        backendId,
+        buildId,
+        rolloutBody,
+        validateOnly,
+      );
+      done = true;
+    } catch (err: unknown) {
+      if (err instanceof FirebaseError && err.status === 400) {
+        if (tries >= 5) {
+          throw err;
+        }
+        await new Promise((resolve) => setTimeout(resolve, 1000));
+      } else {
+        throw err;
+      }
+    }
+  }
+
+  const rolloutOp = await apphosting.createRollout(
+    projectId,
+    location,
+    backendId,
+    buildId,
+    rolloutBody,
+  );
 
   const rolloutPoll = poller.pollOperation<Rollout>({
     ...apphostingPollerOptions,