feat(dataconnect): Add unit tests for dataconnect files (#8943)

* feat(dataconnect): Add unit tests for dataconnect files

Adds unit tests for the following files in `src/dataconnect`:
- `errors.ts`
- `graphqlError.ts`
- `prompts.ts`

This improves test coverage for the dataconnect feature.

* feat(dataconnect): Add unit tests for dataconnect files

Adds unit tests for the following files in `src/dataconnect`:
- `errors.ts`
- `graphqlError.ts`
- `prompts.ts`

This improves test coverage for the dataconnect feature.

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

Author: joehan

src/dataconnect/errors.spec.ts

@@ -0,0 +1,77 @@
+import { expect } from "chai";
+import { getIncompatibleSchemaError, getInvalidConnectors } from "./errors";
+
+describe("errors", () => {
+  describe("getIncompatibleSchemaError", () => {
+    it("should return undefined if no incompatible schema error", () => {
+      const err = {
+        context: {
+          body: {
+            error: {
+              details: [{ "@type": "some.other.Error" }],
+            },
+          },
+        },
+      };
+      expect(getIncompatibleSchemaError(err)).to.be.undefined;
+    });
+
+    it("should extract violation type from precondition failure", () => {
+      const err = {
+        context: {
+          body: {
+            error: {
+              details: [
+                {
+                  "@type": "type.googleapis.com/google.rpc.PreconditionFailure",
+                  violations: [{ type: "INCOMPATIBLE_SCHEMA" }],
+                },
+                { "@type": "IncompatibleSqlSchemaError" },
+              ],
+            },
+          },
+        },
+      };
+      const result = getIncompatibleSchemaError(err);
+      expect(result).to.not.be.undefined;
+      expect(result?.violationType).to.equal("INCOMPATIBLE_SCHEMA");
+    });
+  });
+
+  describe("getInvalidConnectors", () => {
+    it("should return an empty array if no invalid connectors", () => {
+      const err = {
+        context: {
+          body: {
+            error: {
+              details: [{ "@type": "some.other.Error" }],
+            },
+          },
+        },
+      };
+      expect(getInvalidConnectors(err)).to.be.empty;
+    });
+
+    it("should extract invalid connectors from precondition failure", () => {
+      const err = {
+        context: {
+          body: {
+            error: {
+              details: [
+                {
+                  "@type": "type.googleapis.com/google.rpc.PreconditionFailure",
+                  violations: [
+                    { type: "INCOMPATIBLE_CONNECTOR", subject: "users" },
+                    { type: "INCOMPATIBLE_CONNECTOR", subject: "posts" },
+                  ],
+                },
+              ],
+            },
+          },
+        },
+      };
+      const result = getInvalidConnectors(err);
+      expect(result).to.deep.equal(["users", "posts"]);
+    });
+  });
+});

src/dataconnect/graphqlError.spec.ts

@@ -0,0 +1,61 @@
+import { expect } from "chai";
+import { prettify, prettifyTable } from "./graphqlError";
+import { GraphqlError } from "./types";
+
+describe("graphqlError", () => {
+  describe("prettify", () => {
+    it("should format a simple error", () => {
+      const err: GraphqlError = {
+        message: "Something went wrong",
+        path: ["users", 0, "name"],
+        locations: [{ line: 10, column: 2 }],
+        extensions: { file: "users.gql" },
+      };
+      const result = prettify(err);
+      expect(result).to.equal("users.gql:10: On users[0].name: Something went wrong");
+    });
+
+    it("should handle missing path", () => {
+      const err: GraphqlError = {
+        message: "Another issue",
+        locations: [{ line: 5, column: 1 }],
+        extensions: { file: "posts.gql" },
+      };
+      const result = prettify(err);
+      expect(result).to.equal("posts.gql:5: Another issue");
+    });
+  });
+
+  describe("prettifyTable", () => {
+    it("should format a list of errors into a table", () => {
+      const errs: GraphqlError[] = [
+        {
+          message: "BREAKING: A breaking change",
+          path: ["users"],
+          locations: [{ line: 1, column: 1 }],
+          extensions: {
+            file: "schema.gql",
+            workarounds: [{ description: "Do this", reason: "Because", replaceWith: "That" }],
+          },
+        },
+        {
+          message: "INSECURE: An insecure change",
+          path: ["posts"],
+          locations: [{ line: 2, column: 2 }],
+          extensions: {
+            file: "schema.gql",
+          },
+        },
+      ];
+      const result = prettifyTable(errs);
+      // We don't assert the exact table output due to formatting,
+      // but we can check for key elements.
+      expect(result).to.include("BREAKING");
+      expect(result).to.include("A breaking change");
+      expect(result).to.include("Do this");
+      expect(result).to.include("Because");
+      expect(result).to.include("INSECURE");
+      expect(result).to.include("An insecure change");
+    });
+  });
+});

src/dataconnect/prompts.spec.ts

@@ -0,0 +1,40 @@
+import { expect } from "chai";
+import * as sinon from "sinon";
+import * as prompt from "../prompt";
+import * as client from "./client";
+import { promptDeleteConnector } from "./prompts";
+
+describe("prompts", () => {
+  let confirmStub: sinon.SinonStub;
+  let deleteConnectorStub: sinon.SinonStub;
+
+  beforeEach(() => {
+    confirmStub = sinon.stub(prompt, "confirm");
+    deleteConnectorStub = sinon.stub(client, "deleteConnector");
+  });
+
+  afterEach(() => {
+    sinon.restore();
+  });
+
+  describe("promptDeleteConnector", () => {
+    it("should delete connector if user confirms", async () => {
+      confirmStub.resolves(true);
+      deleteConnectorStub.resolves();
+
+      await promptDeleteConnector({ force: false, nonInteractive: false }, "my-connector");
+
+      expect(confirmStub.calledOnce).to.be.true;
+      expect(deleteConnectorStub.calledOnceWith("my-connector")).to.be.true;
+    });
+
+    it("should not delete connector if user denies", async () => {
+      confirmStub.resolves(false);
+
+      await promptDeleteConnector({ force: false, nonInteractive: false }, "my-connector");
+
+      expect(confirmStub.calledOnce).to.be.true;
+      expect(deleteConnectorStub.notCalled).to.be.true;
+    });
+  });
+});