Skip to content

Commit 4d9a604

Browse files
author
Cynthia Jiang
committed
update ios packing
1 parent 2c9c140 commit 4d9a604

File tree

14 files changed

+47
-45
lines changed

14 files changed

+47
-45
lines changed

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,7 @@ endif()
304304

305305
if(FIREBASE_UNI_LIBRARY)
306306
if(FIREBASE_IOS_BUILD)
307-
ios_pack(firebase_lib_uni libFirebaseCppApp DEPS ${TARGET_LINK_LIB_NAMES})
307+
ios_pack(firebase_lib_uni libFirebaseCppApp DEPS "firebase_app" "firebase_app_swig" "flatbuffers")
308308
else()
309309
build_uni(
310310
"${TARGET_LINK_LIB_NAMES}"

analytics/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ mono_add_library(firebase_analytics_cs
5151
)
5252

5353
if(FIREBASE_IOS_BUILD)
54-
ios_pack(firebase_lib_analytics libFirebaseCppAnalytics DEPS firebase_analytics_swig)
54+
ios_pack(firebase_lib_analytics libFirebaseCppAnalytics DEPS firebase_analytics firebase_analytics_swig)
5555
else()
5656
build_firebase_shared(
5757
analytics

auth/CMakeLists.txt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -65,13 +65,13 @@ mono_add_library(firebase_auth_cs
6565
)
6666

6767
if(FIREBASE_IOS_BUILD)
68-
ios_pack(firebase_lib_auth libFirebaseCppAuth DEPS firebase_auth_swig)
68+
ios_pack(firebase_lib_auth libFirebaseCppAuth DEPS firebase_auth firebase_auth_swig)
6969
else()
70-
build_firebase_shared(
71-
auth
72-
auth
73-
FirebaseCppAuth
74-
)
70+
build_firebase_shared(
71+
auth
72+
auth
73+
FirebaseCppAuth
74+
)
7575
endif()
7676

7777
unity_pack_cs(firebase_auth_cs)

cmake/build_shared.cmake

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,16 +29,11 @@ function(build_firebase_shared LIBRARY_NAME ARTIFACT_NAME OUTPUT_NAME)
2929

3030
add_library(${shared_target} SHARED
3131
${FIREBASE_SOURCE_DIR}/empty.cc
32+
$<TARGET_OBJECTS:firebase_${LIBRARY_NAME}>
3233
$<TARGET_OBJECTS:firebase_${LIBRARY_NAME}_swig>
3334
)
34-
35-
# add_dependencies(${shared_target}
36-
# firebase_${LIBRARY_NAME}
37-
# firebase_app
38-
# )
3935

40-
set(SHARED_TARGET_LINK_LIB_NAMES "firebase_${LIBRARY_NAME}_swig")
41-
message("SHARED_TARGET_LINK_LIB_NAMES is ${SHARED_TARGET_LINK_LIB_NAMES}")
36+
set(SHARED_TARGET_LINK_LIB_NAMES "firebase_${LIBRARY_NAME}" "firebase_${LIBRARY_NAME}_swig")
4237

4338
target_link_libraries(${shared_target}
4439
${SHARED_TARGET_LINK_LIB_NAMES}

cmake/ios_pack.cmake

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,13 @@ if (CMAKE_INTERPROCEDURAL_OPTIMIZATION)
1919
set(ar_tool ${CMAKE_CXX_COMPILER_AR})
2020
endif()
2121

22+
if(NOT CMAKE_LIBTOOL)
23+
find_program(CMAKE_LIBTOOL NAMES libtool)
24+
endif()
25+
if(CMAKE_LIBTOOL)
26+
set(CMAKE_LIBTOOL ${CMAKE_LIBTOOL} CACHE PATH "libtool executable")
27+
endif()
28+
2229
# Packs static libraries into one static library for ios and sets up the correct
2330
# install call for it
2431
#
@@ -49,7 +56,7 @@ macro(ios_pack name output_name)
4956
set(first false)
5057
string(APPEND content "cp $<TARGET_FILE:${dep}> ${TARGET_FILE}\n")
5158
else()
52-
string(APPEND content "${ar_tool} -q $<TARGET_FILE:${dep}> ${TARGET_FILE}\n")
59+
string(APPEND content "${CMAKE_LIBTOOL} -static -o ${TARGET_FILE} ${TARGET_FILE} $<TARGET_FILE:${dep}>\n")
5360
endif()
5461
endforeach()
5562

crashlytics/CMakeLists.txt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -90,13 +90,13 @@ mono_add_library(firebase_crashlytics_cs
9090
)
9191

9292
if(FIREBASE_IOS_BUILD)
93-
ios_pack(firebase_lib_crashlytics libFirebaseCppCrashlytics DEPS firebase_crashlytics_swig)
93+
ios_pack(firebase_lib_crashlytics libFirebaseCppCrashlytics DEPS firebase_crashlytics firebase_crashlytics_swig)
9494
else()
95-
build_firebase_shared(
96-
crashlytics
97-
crashlytics
98-
FirebaseCppCrashlytics
99-
)
95+
build_firebase_shared(
96+
crashlytics
97+
crashlytics
98+
FirebaseCppCrashlytics
99+
)
100100
endif()
101101

102102
unity_pack_cs(firebase_crashlytics_cs)

database/CMakeLists.txt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -69,13 +69,13 @@ mono_add_library(firebase_database_cs
6969
)
7070

7171
if(FIREBASE_IOS_BUILD)
72-
ios_pack(firebase_lib_database libFirebaseCppDatabase DEPS firebase_database_swig)
72+
ios_pack(firebase_lib_database libFirebaseCppDatabase DEPS firebase_database firebase_database_swig)
7373
else()
74-
build_firebase_shared(
75-
database
76-
database
77-
FirebaseCppDatabase
78-
)
74+
build_firebase_shared(
75+
database
76+
database
77+
FirebaseCppDatabase
78+
)
7979
endif()
8080

8181
unity_pack_cs(firebase_database_cs)

dynamic_links/CMakeLists.txt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -63,13 +63,13 @@ mono_add_library(firebase_dynamic_links_cs
6363
)
6464

6565
if(FIREBASE_IOS_BUILD)
66-
ios_pack(firebase_lib_dynamic_links libFirebaseCppDynamicLinks DEPS firebase_dynamic_links_swig)
66+
ios_pack(firebase_lib_dynamic_links libFirebaseCppDynamicLinks DEPS firebase_dynamic_links firebase_dynamic_links_swig)
6767
else()
68-
build_firebase_shared(
69-
dynamic_links
70-
dynamic-links
71-
FirebaseCppDynamicLinks
72-
)
68+
build_firebase_shared(
69+
dynamic_links
70+
dynamic-links
71+
FirebaseCppDynamicLinks
72+
)
7373
endif()
7474

7575
unity_pack_cs(firebase_dynamic_links_cs)

firestore/CMakeLists.txt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -143,13 +143,13 @@ mono_add_library(firebase_firestore_cs
143143
)
144144

145145
if(FIREBASE_IOS_BUILD)
146-
ios_pack(firebase_lib_firestore libFirebaseCppFirestore DEPS firebase_firestore_swig)
146+
ios_pack(firebase_lib_firestore libFirebaseCppFirestore DEPS firebase_firestore firebase_firestore_swig firebase_firestore_swig_cpp)
147147
else()
148-
build_firebase_shared(
149-
firestore
150-
firestore
151-
FirebaseCppFirestore
152-
)
148+
build_firebase_shared(
149+
firestore
150+
firestore
151+
FirebaseCppFirestore
152+
)
153153
endif()
154154

155155
unity_pack_cs(firebase_firestore_cs)

functions/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ mono_add_library(firebase_functions_cs
5555
)
5656

5757
if(FIREBASE_IOS_BUILD)
58-
ios_pack(firebase_lib_functions libFirebaseCppFunctions DEPS firebase_functions_swig)
58+
ios_pack(firebase_lib_functions libFirebaseCppFunctions DEPS firebase_functions firebase_functions_swig)
5959
else()
6060
build_firebase_shared(
6161
functions

0 commit comments

Comments
 (0)