Skip to content

Commit c541d7c

Browse files
author
Cynthia Jiang
committed
update review notes
1 parent 72c502b commit c541d7c

File tree

4 files changed

+1
-7
lines changed

4 files changed

+1
-7
lines changed

.github/workflows/sdk_build.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ jobs:
6565
run: git config --system core.longpaths true
6666

6767
# Set up the requirements, and install Unity
68+
# Ruby setup has to happen before python install and setup, to keep the absl config.
6869
- uses: ruby/setup-ruby@v1
6970
with:
7071
ruby-version: 3.0.2

cmake/external_rules.cmake

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,6 @@ function(download_external_sources)
6060
"${FIREBASE_BINARY_DIR}/external/src/firebase_cpp_sdk" PARENT_SCOPE)
6161
endif()
6262

63-
message(WARNING "${ENV_COMMAND} cmake --debug-output")
64-
6563
execute_process(
6664
COMMAND
6765
${ENV_COMMAND} cmake --debug-output

cmake/unity_mono.cmake

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,8 +100,6 @@ macro(mono_add_external_library name projpath)
100100
set(absprojpath ${CMAKE_CURRENT_LIST_DIR}/${projpath})
101101
endif()
102102

103-
message(WARNING "Defining build of ${DLL_NAME} using ${MONO_CSHARP_BUILD_EXE}")
104-
105103
set(CSHARP_BUILD_EXE "${UNITY_CSHARP_BUILD_EXE}")
106104
if(MSVC)
107105
set(CSHARP_BUILD_EXE "${MONO_CSHARP_BUILD_EXE}")

cmake/unity_pack.cmake

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -156,8 +156,6 @@ function(unity_pack_cs name)
156156

157157
string(REPLACE ".dll" "" dllbasename ${dllname})
158158
string(REPLACE ".dll" "" dllbaserename ${dllrename})
159-
160-
message(WARNING "Setting up install: FILE:${dllpath}/${dllname} DEST:${UNITY_PACK_PACK_PATH} RENAME:${dllrename}")
161159
# Dll file
162160
install(
163161
FILES "${dllpath}/${dllname}"
@@ -247,7 +245,6 @@ function(unity_pack_native name)
247245
set(lib_dest "")
248246
endif()
249247

250-
message(WARNING "unity_pack_native TARGETS:${name} LIBRARY:${dll_dest} ARCHIVE:${lib_dest}")
251248
# Win32 treats Dll's as 'runtime' other platforms as 'library'
252249
install(
253250
TARGETS

0 commit comments

Comments
 (0)