Skip to content

Commit d1b9e6d

Browse files
authored
Fix dynamic link tests on mobile (#795)
1 parent 71e262b commit d1b9e6d

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

dynamic_links/testapp/Assets/Firebase/Sample/DynamicLinks/UIHandler.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ DynamicLinkComponents CreateDynamicLinkComponents() {
122122
#endif
123123

124124
return new DynamicLinkComponents(
125-
// The base Link.
125+
// The base Link. This should be in your allowlist in the Firebase console.
126126
new System.Uri("https://google.com/abc"),
127127
// The dynamic link domain.
128128
kDomainUriPrefix) {
@@ -134,11 +134,11 @@ DynamicLinkComponents CreateDynamicLinkComponents() {
134134
Content = "mycontent"
135135
},
136136
IOSParameters = new Firebase.DynamicLinks.IOSParameters(appIdentifier) {
137-
FallbackUrl = new System.Uri("https://mysite/fallback"),
137+
FallbackUrl = new System.Uri("https://google.com/fallback"),
138138
CustomScheme = "mycustomscheme",
139139
MinimumVersion = "1.2.3",
140140
IPadBundleId = appIdentifier,
141-
IPadFallbackUrl = new System.Uri("https://mysite/fallbackipad")
141+
IPadFallbackUrl = new System.Uri("https://google.com/fallbackipad")
142142
},
143143
ITunesConnectAnalyticsParameters =
144144
new Firebase.DynamicLinks.ITunesConnectAnalyticsParameters() {
@@ -147,13 +147,13 @@ DynamicLinkComponents CreateDynamicLinkComponents() {
147147
ProviderToken = "pq-rstuv"
148148
},
149149
AndroidParameters = new Firebase.DynamicLinks.AndroidParameters(appIdentifier) {
150-
FallbackUrl = new System.Uri("https://mysite/fallback"),
150+
FallbackUrl = new System.Uri("https://google.com/fallback"),
151151
MinimumVersion = 12
152152
},
153153
SocialMetaTagParameters = new Firebase.DynamicLinks.SocialMetaTagParameters() {
154154
Title = "My App!",
155155
Description = "My app is awesome!",
156-
ImageUrl = new System.Uri("https://mysite.com/someimage.jpg")
156+
ImageUrl = new System.Uri("https://google.com/someimage.jpg")
157157
},
158158
};
159159
}

dynamic_links/testapp/Assets/Firebase/Sample/DynamicLinks/UIHandlerAutomated.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public override void Start() {
3333
Func<Task>[] tests = {
3434
TestCreateLongLinkAsync,
3535
// TODO(b/264533368) Enable theses tests when the issue has been fixed.
36-
#if (false) // (UNITY_ANDROID || UNITY_IOS)
36+
#if (UNITY_ANDROID || UNITY_IOS)
3737
// Link shortening does not work on desktop builds, so only test that for mobile.
3838
TestCreateShortLinkAsync,
3939
TestCreateUnguessableShortLinkAsync,
@@ -71,12 +71,12 @@ Task TestCreateLongLinkAsync() {
7171

7272
// This is taken from the values given in UIHandler.
7373
var expected =
74-
urlHost + "/?afl=https://mysite/fallback&" +
74+
urlHost + "/?afl=https://google.com/fallback&" +
7575
"amv=12&apn=" + identifier + "&at=abcdefg&ct=hijklmno&" +
76-
"ibi=" + identifier + "&ifl=https://mysite/fallback&imv=1.2.3&" +
76+
"ibi=" + identifier + "&ifl=https://google.com/fallback&imv=1.2.3&" +
7777
"ipbi=" + identifier + "&" +
78-
"ipfl=https://mysite/fallbackipad&ius=mycustomscheme&link=https://google.com/abc&" +
79-
"pt=pq-rstuv&sd=My app is awesome!&si=https://mysite.com/someimage.jpg&st=My App!&" +
78+
"ipfl=https://google.com/fallbackipad&ius=mycustomscheme&link=https://google.com/abc&" +
79+
"pt=pq-rstuv&sd=My app is awesome!&si=https://google.com/someimage.jpg&st=My App!&" +
8080
"utm_campaign=mycampaign&utm_content=mycontent&utm_medium=mymedium&utm_source=mysource&" +
8181
"utm_term=myterm";
8282
// The order of URL parameters is different between desktop and mobile implementations, and

0 commit comments

Comments
 (0)