Skip to content

Commit dd2a651

Browse files
author
Cynthia Jiang
committed
add TODO to convert .sh & .bat to .py
1 parent 5a2efbd commit dd2a651

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/sdk_build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ jobs:
142142
if: startsWith(matrix.os, 'windows')
143143
shell: bash
144144
run: |
145-
# ./build_windows_x64.bat ${{ github.event.inputs.additional_cmake_flags }}
145+
# ./build_windows_x64.bat ${{ github.event.inputs.additional_cmake_flags }} TODO convert to python script
146146
mkdir ${{ matrix.build_dir }}
147147
pushd ${{ matrix.build_dir }}
148148
cmake .. -G "Visual Studio 16 2019" -A x64 -DFIREBASE_CPP_SDK_DIR="${FIREBASE_CPP_SDK_DIR}" -DUNITY_ROOT_DIR="${{ matrix.unity_install_dir }}" -DSWIG_DIR="$(swig -swiglib)" ${{ github.event.inputs.additional_cmake_flags }}

0 commit comments

Comments
 (0)