Clean up comments

Author: a-maurice

scripts/gha/desktop_tester.py

@@ -134,11 +134,7 @@ def run(self):
     open_process.kill()
     if platform.system() == 'Linux':
       # Linux seems to have a problem printing out too much information, so truncate it
-      # It can also fail to save the logs correctly for some reason, so check for that
-      if self.logs is None:
-        logging.warning("Unable to print the logs")
-      else:
-        logging.info("Test result: %s (Log might be truncated)", self.logs[:64000])
+      logging.info("Test result: %s (Log might be truncated)", self.logs[:64000])
     else:
       logging.info("Test result: %s", self.logs)
     logging.info("Finished running %s", self.testapp_path)

scripts/gha/integration_testing/XcodeCapabilities.cs

@@ -14,38 +14,24 @@
 
 /* Post build processor for configuring the XCode project generated by Unity.
  *
- * Requires Unity 5.0 or higher.
+ * Requires Unity 2019 or higher.
  *
  * Given that Unity generates the XCode project, we cannot configure a project
  * in advance with the necessary frameworks and capabilities. Instead, we do so
  * programmatically via a post build processor. This will automatically run
  * once Unity is finished building for iOS.
  *
- * There are three main operations performed by this script:
- * (1) Copy over an existing entitlement to the XCode project.
- * (2) Patch the project's Info.plist for certain capabilities.
- * (3) Add frameworks to the project.
+ * There are two main operations performed by this script:
+ * (1) Generate an entitlements file with the necessary ones for products.
+ * (2) Turn off bitcode.
  *
- * For (1), the entitlement is generated manually in advance by
- * configuring a separate XCode project to use the desired capabilities
- * and frameworks, and saving the generated entitlement. That entitlement
- * is then copied into the Unity project before building for iOS, and is saved
- * as 'dev.entitlements'.
+ * For (1), the entitlement is generated using ProjectCapabilityManager,
+ * into a file called `dev.entitlements`.  Based on the name of the project,
+ * it adds the capabilities that are expected.
  *
- * For (2), we similarly see the difference between a project with the
- * capabilities/frameworks versus without them, and patch the Info.plist
- * using Unity's plist API. We could have saved a copy of an Info.plist
- * and copied that over, like we did in (1), but the Info.plist contains a
- * large amount of other critical information. Patching the plist appears
- * to involve less of a maintenance burden.
- *
- * For (3), Unity has an API for adding frameworks.
- *
- * Note that starting with Unity 2017, there is a much more powerful
- * API for enabling XCode capabilities which would significantly simplify
- * this script. If support for 5.x is deprecated, then moving to that API
- * is recommended. See the ProjectCapabilityManager in Unity's documentation
- * for reference.
+ * For (2), we modify the project to turn off bitcode, since XCode has
+ * deprecated it, but some versions of Unity turn it on by default, causing
+ * issues.
  */
 
 #if (UNITY_IOS || UNITY_TVOS)