Skip to content

Commit f0d6c34

Browse files
authored
Disable code signing for simulator tests (#1019)
* Disable code signing for simulator tests * Increase the iOS deployment target * Update Simulator versions
1 parent d1d97e4 commit f0d6c34

File tree

3 files changed

+16
-10
lines changed

3 files changed

+16
-10
lines changed

scripts/gha/integration_testing/gameloop_apple/gameloop.xcodeproj/project.pbxproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -532,7 +532,7 @@
532532
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
533533
GCC_WARN_UNUSED_FUNCTION = YES;
534534
GCC_WARN_UNUSED_VARIABLE = YES;
535-
IPHONEOS_DEPLOYMENT_TARGET = 10.0;
535+
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
536536
MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE;
537537
MTL_FAST_MATH = YES;
538538
ONLY_ACTIVE_ARCH = YES;
@@ -587,7 +587,7 @@
587587
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
588588
GCC_WARN_UNUSED_FUNCTION = YES;
589589
GCC_WARN_UNUSED_VARIABLE = YES;
590-
IPHONEOS_DEPLOYMENT_TARGET = 10.0;
590+
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
591591
MTL_ENABLE_DEBUG_INFO = NO;
592592
MTL_FAST_MATH = YES;
593593
SDKROOT = iphoneos;
@@ -603,7 +603,7 @@
603603
ASSETCATALOG_COMPILER_GLOBAL_ACCENT_COLOR_NAME = AccentColor;
604604
CODE_SIGN_STYLE = Automatic;
605605
INFOPLIST_FILE = gameloop/Info.plist;
606-
IPHONEOS_DEPLOYMENT_TARGET = 10.0;
606+
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
607607
LD_RUNPATH_SEARCH_PATHS = (
608608
"$(inherited)",
609609
"@executable_path/Frameworks",
@@ -622,7 +622,7 @@
622622
ASSETCATALOG_COMPILER_GLOBAL_ACCENT_COLOR_NAME = AccentColor;
623623
CODE_SIGN_STYLE = Automatic;
624624
INFOPLIST_FILE = gameloop/Info.plist;
625-
IPHONEOS_DEPLOYMENT_TARGET = 10.0;
625+
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
626626
LD_RUNPATH_SEARCH_PATHS = (
627627
"$(inherited)",
628628
"@executable_path/Frameworks",

scripts/gha/print_matrix_configuration.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -142,9 +142,9 @@
142142
"model=iphone8,version=16.6",
143143
"model=ipad10,version=16.6",
144144
]},
145-
"simulator_min": {"platform": IOS, "type": "virtual", "name": "iPhone 8", "version": "15.2"},
146-
"simulator_target": {"platform": IOS, "type": "virtual", "name": "iPhone 12", "version": "16.1"},
147-
"simulator_latest": {"platform": IOS, "type": "virtual", "name": "iPhone 12", "version": "16.2"},
145+
"simulator_min": [ {"type": "virtual", "name":"iPhone SE (3rd generation)", "version":"17.0.1"} ],
146+
"simulator_target": [ {"type": "virtual", "name":"iPhone 15", "version":"17.2"} ],
147+
"simulator_latest": [ {"type": "virtual", "name":"iPad Pro (12.9-inch) (6th generation)", "version":"17.4"} ],
148148
"tvos_simulator": {"platform": TVOS, "type": "virtual", "name": "Apple TV", "version": "16.1"},
149149
}
150150

scripts/gha/test_simulator.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,10 @@ def _build_ios_gameloop(gameloop_project, device_name, device_os):
322322
"-scheme", "gameloop",
323323
"build-for-testing",
324324
"-destination", "platform=iOS Simulator,name=%s,OS=%s" % (device_name, device_os),
325-
"SYMROOT=%s" % output_path]
325+
"SYMROOT=%s" % output_path,
326+
'CODE_SIGN_IDENTITY=""',
327+
"CODE_SIGNING_REQUIRED=NO",
328+
"CODE_SIGNING_ALLOWED=NO"]
326329
logging.info("Building game-loop test: %s", " ".join(args))
327330
subprocess.run(args=args, check=True)
328331

@@ -345,7 +348,10 @@ def _build_tvos_gameloop(gameloop_project, device_name, device_os):
345348
"-scheme", "gameloop_tvos",
346349
"build-for-testing",
347350
"-destination", "platform=tvOS Simulator,name=%s,OS=%s" % (device_name, device_os),
348-
"SYMROOT=%s" % output_path]
351+
"SYMROOT=%s" % output_path,
352+
'CODE_SIGN_IDENTITY=""',
353+
"CODE_SIGNING_REQUIRED=NO",
354+
"CODE_SIGNING_ALLOWED=NO"]
349355
logging.info("Building game-loop test: %s", " ".join(args))
350356
subprocess.run(args=args, check=True)
351357

@@ -387,7 +393,7 @@ def _shutdown_simulator():
387393
def _create_and_boot_simulator(apple_platform, device_name, device_os):
388394
"""Create a simulator locally. Will wait until this simulator booted."""
389395
_shutdown_simulator()
390-
command = "xcrun xctrace list devices 2>&1 | grep \"%s (%s)\" | awk -F'[()]' '{print $4}'" % (device_name, device_os)
396+
command = "xcrun xctrace list devices 2>&1 | grep \"%s Simulator (%s)\" | awk -F'[()]' '{print $4}'" % (device_name, device_os)
391397
logging.info("Get test simulator: %s", command)
392398
result = subprocess.Popen(command, universal_newlines=True, shell=True, stdout=subprocess.PIPE)
393399
device_id = result.stdout.read().strip()

0 commit comments

Comments
 (0)