replaced shouldDisplayName to requireDisplayName

Author: prakhar1989

demo/public/app.js

@@ -49,7 +49,7 @@ var uiConfig = {
   // Terms of service url.
   'tosUrl': 'https://www.google.com',
   // Whether the display name should be displayed in Sign Up page.
-  'shouldDisplayName': false
+  'requireDisplayName': false
 };
 
 // Initialize the FirebaseUI Widget using Firebase.

javascript/ui/page/passwordsignup.js

@@ -31,7 +31,7 @@ goog.require('firebaseui.auth.ui.page.Base');
 /**
  * Password sign-up UI component.
  * @param {?string} tosUrl The ToS URL.
- * @param {boolean} showDisplayName Whether to show the display name.
+ * @param {boolean} requireDisplayName Whether to show the display name.
  * @param {function()} onSubmitClick Callback to invoke when the submit button
  *     is clicked.
  * @param {function()=} opt_onCancelClick Callback to invoke when the cancel
@@ -44,7 +44,7 @@ goog.require('firebaseui.auth.ui.page.Base');
  */
 firebaseui.auth.ui.page.PasswordSignUp = function(
     tosUrl,
-    showDisplayName,
+    requireDisplayName,
     onSubmitClick,
     opt_onCancelClick,
     opt_email,
@@ -56,7 +56,7 @@ firebaseui.auth.ui.page.PasswordSignUp = function(
       firebaseui.auth.soy2.page.passwordSignUp,
       {
         email: opt_email,
-        showDisplayName: showDisplayName,
+        requireDisplayName: requireDisplayName,
         name: opt_name,
         tosUrl: tosUrl,
         allowCancel: !!opt_onCancelClick
@@ -65,7 +65,7 @@ firebaseui.auth.ui.page.PasswordSignUp = function(
       'passwordSignUp');
   this.onSubmitClick_ = onSubmitClick;
   this.onCancelClick_ = opt_onCancelClick;
-  this.showDisplayName_ = showDisplayName;
+  this.requireDisplayName_ = requireDisplayName;
 };
 goog.inherits(firebaseui.auth.ui.page.PasswordSignUp,
     firebaseui.auth.ui.page.Base);
@@ -74,7 +74,7 @@ goog.inherits(firebaseui.auth.ui.page.PasswordSignUp,
 /** @override */
 firebaseui.auth.ui.page.PasswordSignUp.prototype.enterDocument = function() {
   this.initEmailElement();
-  if (this.showDisplayName_) {
+  if (this.requireDisplayName_) {
     this.initNameElement();
   }
   this.initNewPasswordElement();
@@ -98,7 +98,7 @@ firebaseui.auth.ui.page.PasswordSignUp.prototype.disposeInternal = function() {
  */
 firebaseui.auth.ui.page.PasswordSignUp.prototype.setupFocus_ = function() {
   // Focus order.
-  if (this.showDisplayName_) {
+  if (this.requireDisplayName_) {
     this.focusToNextOnEnter(this.getEmailElement(), this.getNameElement());
     this.focusToNextOnEnter(this.getNameElement(), this.getNewPasswordElement());
   } else {
@@ -115,7 +115,7 @@ firebaseui.auth.ui.page.PasswordSignUp.prototype.setupFocus_ = function() {
   // Auto focus.
   if (!firebaseui.auth.ui.element.getInputValue(this.getEmailElement())) {
     this.getEmailElement().focus();
-  } else if (this.showDisplayName_ &&
+  } else if (this.requireDisplayName_ &&
     !firebaseui.auth.ui.element.getInputValue(this.getNameElement())) {
     this.getNameElement().focus();
   } else {

javascript/ui/page/passwordsignup_test.js

@@ -49,10 +49,10 @@ var infoBarTestHelper =
     new firebaseui.auth.ui.element.InfoBarTestHelper().registerTests();
 
 
-function createComponent(tosUrl, shouldDisplayName, opt_name) {
+function createComponent(tosUrl, requireDisplayName, opt_name) {
   var component = new firebaseui.auth.ui.page.PasswordSignUp(
       tosUrl,
-      shouldDisplayName,
+      requireDisplayName,
       goog.bind(
           firebaseui.auth.ui.element.FormTestHelper.prototype.onSubmit,
           formTestHelper),

javascript/widgets/config.js

@@ -72,7 +72,7 @@ firebaseui.auth.widget.Config = function() {
    * Determines whether the user is asked for entering display name
    * while going through the email/password signup flow.
    */
-  this.config_.define('shouldDisplayName', true);
+  this.config_.define('requireDisplayName', true);
 };
 
 
@@ -296,8 +296,8 @@ firebaseui.auth.widget.Config.prototype.getTosUrl = function() {
 
 
 /** @return {boolean} Whether the display name should be displayed. */
-firebaseui.auth.widget.Config.prototype.getShouldDisplayName = function() {
-  return /** @type {boolean} */ (this.config_.get('shouldDisplayName'));
+firebaseui.auth.widget.Config.prototype.getRequireDisplayName = function() {
+  return /** @type {boolean} */ (this.config_.get('requireDisplayName'));
 };
 
 

javascript/widgets/config_test.js

@@ -243,9 +243,9 @@ function testGetTosUrl() {
 
 
 function testShouldDisplayName() {
-  assertTrue(config.getShouldDisplayName());
-  config.update('shouldDisplayName', false);
-  assertFalse(config.getShouldDisplayName());
+  assertTrue(config.getRequireDisplayName());
+  config.update('requireDisplayName', false);
+  assertFalse(config.getRequireDisplayName());
 }
 
 

javascript/widgets/handler/passwordsignup.js

@@ -48,7 +48,7 @@ firebaseui.auth.widget.handler.handlePasswordSignUp = function(
   // Render the UI.
   var component = new firebaseui.auth.ui.page.PasswordSignUp(
       app.getConfig().getTosUrl(),
-      app.getConfig().getShouldDisplayName(),
+      app.getConfig().getRequireDisplayName(),
       // On submit.
       function() {
         firebaseui.auth.widget.handler.onSignUpSubmit_(app, component);
@@ -70,13 +70,13 @@ firebaseui.auth.widget.handler.handlePasswordSignUp = function(
  * @private
  */
 firebaseui.auth.widget.handler.onSignUpSubmit_ = function(app, component) {
-  var shouldDisplayName = app.getConfig().getShouldDisplayName();
+  var requireDisplayName = app.getConfig().getRequireDisplayName();
 
   // Check fields are valid.
   var email = component.checkAndGetEmail();
 
   var name = null;
-  if (shouldDisplayName) {
+  if (requireDisplayName) {
     name = component.checkAndGetName();
   }
 
@@ -85,7 +85,7 @@ firebaseui.auth.widget.handler.onSignUpSubmit_ = function(app, component) {
     component.getEmailElement().focus();
     return;
   }
-  if (shouldDisplayName && !name) {
+  if (requireDisplayName && !name) {
     component.getNameElement().focus();
     return;
   }

soy/pages.soy

@@ -76,7 +76,7 @@
  */
 {template .passwordSignUp}
   {@param? email: string} /** The email address to prefill. */
-  {@param? showDisplayName: bool} /** Whether to show the display name. */
+  {@param? requireDisplayName: bool} /** Whether to show the display name. */
   {@param? name: string} /** The name to prefill. */
   {@param? tosUrl: string} /** The Terms of Service URL. */
   {@param? allowCancel: bool} /** Whether to show the cancel link. */
@@ -90,7 +90,7 @@
       </div>
       <div class="{css firebaseui-card-content}">
         {call firebaseui.auth.soy2.element.email data="all" /}
-        {if $showDisplayName}
+        {if $requireDisplayName}
           {call firebaseui.auth.soy2.element.name data="all" /}
         {/if}
         {call firebaseui.auth.soy2.element.newPassword}