fix(react): fixed linting errors

Author: dackers86

packages/firebaseui-react/eslint.config.js

@@ -45,7 +45,19 @@ export default [
         HTMLFormElement: "readonly",
         Event: "readonly",
         setTimeout: "readonly",
+        clearTimeout: "readonly",
+        clearInterval: "readonly",
         React: "readonly",
+        global: "readonly",
+        describe: "readonly",
+        it: "readonly",
+        expect: "readonly",
+        beforeEach: "readonly",
+        afterEach: "readonly",
+        beforeAll: "readonly",
+        afterAll: "readonly",
+        vi: "readonly",
+        __dirname: "readonly",
       },
     },
     plugins: {
@@ -62,6 +74,7 @@ export default [
       ...react.configs.recommended.rules,
       ...reactHooks.configs.recommended.rules,
       "no-unused-vars": "off", // Turn off base rule
+      "no-undef": "off", // Turn off base rule - TypeScript handles this better
       "no-console": "warn",
       "prefer-const": "error",
       "no-var": "error",
@@ -90,6 +103,15 @@ export default [
       globals: {
         window: "readonly",
         console: "readonly",
+        document: "readonly",
+        HTMLInputElement: "readonly",
+        HTMLFormElement: "readonly",
+        Event: "readonly",
+        setTimeout: "readonly",
+        clearTimeout: "readonly",
+        clearInterval: "readonly",
+        React: "readonly",
+        global: "readonly",
         describe: "readonly",
         it: "readonly",
         expect: "readonly",
@@ -98,6 +120,7 @@ export default [
         beforeAll: "readonly",
         afterAll: "readonly",
         vi: "readonly",
+        __dirname: "readonly",
       },
     },
     plugins: {
@@ -114,6 +137,7 @@ export default [
       ...react.configs.recommended.rules,
       ...reactHooks.configs.recommended.rules,
       "no-unused-vars": "off", // Turn off base rule
+      "no-undef": "off", // Turn off base rule - TypeScript handles this better
       "no-console": "warn",
       "prefer-const": "error",
       "no-var": "error",

packages/firebaseui-react/src/auth/forms/email-link-form.tsx

@@ -98,6 +98,7 @@ export function EmailLinkForm(_: EmailLinkFormProps) {
       <fieldset>
         <form.Field
           name="email"
+          // eslint-disable-next-line react/no-children-prop
           children={(field) => (
             <>
               <label htmlFor={field.name}>

packages/firebaseui-react/src/auth/forms/email-password-form.tsx

@@ -81,6 +81,7 @@ export function EmailPasswordForm({ onForgotPasswordClick, onRegisterClick }: Em
       <fieldset>
         <form.Field
           name="email"
+          // eslint-disable-next-line react/no-children-prop
           children={(field) => (
             <>
               <label htmlFor={field.name}>
@@ -113,6 +114,7 @@ export function EmailPasswordForm({ onForgotPasswordClick, onRegisterClick }: Em
       <fieldset>
         <form.Field
           name="password"
+          // eslint-disable-next-line react/no-children-prop
           children={(field) => (
             <>
               <label htmlFor={field.name}>

packages/firebaseui-react/src/auth/forms/forgot-password-form.tsx

@@ -83,6 +83,7 @@ export function ForgotPasswordForm({ onBackToSignInClick }: ForgotPasswordFormPr
       <fieldset>
         <form.Field
           name="email"
+          // eslint-disable-next-line react/no-children-prop
           children={(field) => (
             <>
               <label htmlFor={field.name}>

packages/firebaseui-react/src/auth/forms/phone-form.tsx

@@ -83,6 +83,7 @@ function PhoneNumberForm({ onSubmit, formError, recaptchaVerifier, recaptchaCont
       <fieldset>
         <phoneForm.Field
           name="phoneNumber"
+          // eslint-disable-next-line react/no-children-prop
           children={(field) => (
             <>
               <label htmlFor={field.name}>
@@ -232,6 +233,7 @@ function VerificationForm({
       <fieldset>
         <verificationForm.Field
           name="verificationCode"
+          // eslint-disable-next-line react/no-children-prop
           children={(field) => (
             <>
               <label htmlFor={field.name}>

packages/firebaseui-react/src/auth/forms/register-form.tsx

@@ -78,6 +78,7 @@ export function RegisterForm({ onBackToSignInClick }: RegisterFormProps) {
       <fieldset>
         <form.Field
           name="email"
+          // eslint-disable-next-line react/no-children-prop
           children={(field) => (
             <>
               <label htmlFor={field.name}>
@@ -110,6 +111,7 @@ export function RegisterForm({ onBackToSignInClick }: RegisterFormProps) {
       <fieldset>
         <form.Field
           name="password"
+          // eslint-disable-next-line react/no-children-prop
           children={(field) => (
             <>
               <label htmlFor={field.name}>

packages/firebaseui-react/src/hooks.ts

@@ -31,7 +31,8 @@ export function useUI() {
  * If no UI configuration is provided, use the auth instance from the context.
  */
 export function useAuth(ui?: FirebaseUIConfiguration | undefined) {
-  const config = ui ?? useUI();
+  const contextUI = useUI();
+  const config = ui ?? contextUI;
   const auth = useMemo(() => ui?.getAuth() ?? getAuth(config.app), [config.app]);
   return auth;
 }

packages/firebaseui-react/vite.config.ts

@@ -16,15 +16,16 @@
 
 import { defineConfig } from "vite";
 import path from "node:path";
+import { fileURLToPath } from "node:url";
 import react from "@vitejs/plugin-react";
 
 // https://vite.dev/config/
 export default defineConfig({
   plugins: [react()],
   resolve: {
     alias: {
-      "@firebase-ui/core": path.resolve(__dirname, "../firebaseui-core/src"),
-      "~": path.resolve(__dirname, "./src"),
+      "@firebase-ui/core": path.resolve(path.dirname(fileURLToPath(import.meta.url)), "../firebaseui-core/src"),
+      "~": path.resolve(path.dirname(fileURLToPath(import.meta.url)), "./src"),
     },
   },
 });

packages/firebaseui-react/vitest.config.ts

@@ -16,6 +16,7 @@
 
 import { defineConfig } from "vitest/config";
 import { resolve } from "path";
+import { fileURLToPath } from "node:url";
 
 export default defineConfig({
   test: {
@@ -42,7 +43,7 @@ export default defineConfig({
   },
   resolve: {
     alias: {
-      "~": resolve(__dirname, "./src"),
+      "~": resolve(resolve(fileURLToPath(import.meta.url), ".."), "./src"),
     },
   },
 });