Skip to content

Commit 21ea11b

Browse files
prakhar1989bojeil-google
authored andcommitted
Mock firebase.auth in config_test
1 parent 6102ec8 commit 21ea11b

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

javascript/widgets/config.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -298,8 +298,7 @@ firebaseui.auth.widget.Config.prototype.isDisplayNameRequired = function() {
298298
var signInOptions = this.getSignInOptions_();
299299

300300
for (var i = 0; i < signInOptions.length; i++) {
301-
//if (signInOptions[i]['provider'] == firebase.auth.EmailAuthProvider.PROVIDER_ID
302-
if (signInOptions[i]['provider'] == 'password'
301+
if (signInOptions[i]['provider'] == firebase.auth.EmailAuthProvider.PROVIDER_ID
303302
&& signInOptions[i]['requireDisplayName'] !== undefined) {
304303
return /** @type {boolean} */ (!!signInOptions[i]['requireDisplayName']);
305304
}

javascript/widgets/config_test.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ goog.setTestOnly('firebaseui.auth.widget.ConfigTest');
4141
var config;
4242
var stub = new goog.testing.PropertyReplacer();
4343
var logMessages = [];
44+
var firebase = {};
4445

4546

4647
function setUp() {
@@ -50,6 +51,7 @@ function setUp() {
5051
stub.set(firebaseui.auth.log, 'error', function(msg) {
5152
logMessages.push(msg);
5253
});
54+
firebase.auth = {EmailAuthProvider: {PROVIDER_ID: 'password'}};
5355
}
5456

5557

0 commit comments

Comments
 (0)