Skip to content

Commit 3a67397

Browse files
nicolasgarnierbojeil-google
authored andcommitted
Restrict firebase imports in Node distro (#205)
At the moment only `require('firebase/app');` and `require('firebase/auth')` is needed but the Node distro imports the whole Firebase SDK with `require('firebase');`. This makes it hard to only load parts of the Firebase SDK or use dynamic imports when using Node to build for the client (using Webpack for instance). This would fix #163
1 parent a1d0ddc commit 3a67397

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

gulpfile.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ const OUTPUT_WRAPPER = OPTIMIZATION_LEVEL === 'WHITESPACE_ONLY' ?
4040

4141
// Adds the firebase module requirement and exports firebaseui.
4242
const NPM_MODULE_WRAPPER = OPTIMIZATION_LEVEL === 'WHITESPACE_ONLY' ?
43-
'var firebase=require(\'firebase\');%output%module.exports=firebaseui;' :
44-
'(function() { var firebase=require(\'firebase\');%output% })();' +
43+
'var firebase=require(\'firebase/app\');require(\'firebase/auth\');%output%module.exports=firebaseui;' :
44+
'(function() { var firebase=require(\'firebase/app\');require(\'firebase/auth\');%output% })();' +
4545
'module.exports=firebaseui;';
4646

4747
// The path to Closure Compiler.

0 commit comments

Comments
 (0)