Merge branch '@invertase/align-core' of https://github.com/firebase/firebaseui-web into @invertase/align-react

Author: Ehesp

.github/workflows/test.yaml

@@ -9,6 +9,29 @@ on:
       - "**"
 
 jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+      - name: Setup node
+        uses: actions/setup-node@v4
+        with:
+          node-version: '20'
+          check-latest: true
+      - name: Setup pnpm
+        uses: pnpm/action-setup@v4
+        with:
+          version: latest
+      - name: Install dependencies
+        run: pnpm install
+      - name: Run ESLint on core packages
+        run: pnpm --filter="@firebase-ui/*" run lint
+      - name: Run ESLint on example apps
+        run: pnpm --filter="angular-example" --filter="nextjs" --filter="react" run lint
+      - name: Check Prettier formatting
+        run: pnpm format:check
+
   test:
     runs-on: ubuntu-latest
     steps:

.gitignore

@@ -15,6 +15,9 @@ dist-ssr
 # Angular
 .angular
 
+# Next.js
+.next
+
 # Coverage
 coverage
 

.prettierignore

@@ -13,6 +13,7 @@ releases/
 # Generated files
 *.min.js
 *.min.css
+packages/styles/dist.css
 
 # Logs
 *.log

eslint.config.js

@@ -16,47 +16,119 @@
 
 import js from "@eslint/js";
 import prettier from "eslint-config-prettier";
+import tseslint from "@typescript-eslint/eslint-plugin";
+import tsparser from "@typescript-eslint/parser";
 
 export default [
-  { ignores: ["**/dist/**", "**/node_modules/**", "**/releases/**", "**/.angular/**"] },
+  {
+    ignores: [
+      "dist/**",
+      "node_modules/**",
+      "releases/**",
+      "*.tgz",
+      "**/dist/**",
+      "**/node_modules/**",
+      "**/build/**",
+      "**/.next/**",
+      "**/coverage/**",
+      "**/.angular/**",
+      "**/cache/**",
+      "**/.cache/**",
+    ],
+  },
   js.configs.recommended,
   prettier,
   {
-    files: ["**/*.{js,jsx,ts,tsx}"],
+    files: ["**/*.{js,jsx}"],
     languageOptions: {
       ecmaVersion: 2022,
       sourceType: "module",
+      globals: {
+        window: "readonly",
+        console: "readonly",
+        document: "readonly",
+        process: "readonly",
+        Buffer: "readonly",
+        __dirname: "readonly",
+        __filename: "readonly",
+        global: "readonly",
+        module: "readonly",
+        require: "readonly",
+        exports: "readonly",
+        setImmediate: "readonly",
+        clearImmediate: "readonly",
+        URL: "readonly",
+        clearInterval: "readonly",
+        clearTimeout: "readonly",
+        setTimeout: "readonly",
+        setInterval: "readonly",
+      },
+    },
+    rules: {
+      "no-unused-vars": "off",
+      "no-console": "warn",
+      "prefer-const": "error",
+      "no-var": "error",
+      "no-undef": "off",
+    },
+  },
+  {
+    files: ["**/*.{ts,tsx}"],
+    languageOptions: {
+      ecmaVersion: 2022,
+      sourceType: "module",
+      parser: tsparser,
       parserOptions: {
         ecmaFeatures: {
           jsx: true,
         },
       },
+      globals: {
+        window: "readonly",
+        console: "readonly",
+        document: "readonly",
+        process: "readonly",
+        Buffer: "readonly",
+        __dirname: "readonly",
+        __filename: "readonly",
+        global: "readonly",
+        module: "readonly",
+        require: "readonly",
+        exports: "readonly",
+        setImmediate: "readonly",
+        clearImmediate: "readonly",
+        URL: "readonly",
+        clearInterval: "readonly",
+        clearTimeout: "readonly",
+        setTimeout: "readonly",
+        setInterval: "readonly",
+        React: "readonly",
+        describe: "readonly",
+        it: "readonly",
+        expect: "readonly",
+        beforeEach: "readonly",
+        afterEach: "readonly",
+        beforeAll: "readonly",
+        afterAll: "readonly",
+        vi: "readonly",
+        test: "readonly",
+        jest: "readonly",
+      },
+    },
+    plugins: {
+      "@typescript-eslint": tseslint,
     },
     rules: {
-      // Core JavaScript rules
-      "no-unused-vars": ["error", { varsIgnorePattern: "^_", argsIgnorePattern: "^_" }],
+      "no-unused-vars": "off",
+      "no-undef": "off",
       "no-console": "warn",
       "prefer-const": "error",
       "no-var": "error",
-
-      // Security and best practices
-      "no-debugger": "error",
-      "no-eval": "error",
-      "no-implied-eval": "error",
-      "no-new-func": "error",
-      "no-script-url": "error",
-      "no-with": "error",
-
-      // Modern JavaScript preferences
-      "prefer-arrow-callback": "error",
-      "prefer-template": "error",
-      "prefer-destructuring": ["error", { object: true, array: false }],
-
-      // Code quality
-      eqeqeq: ["error", "always"],
-      "no-duplicate-imports": "error",
-      "no-useless-return": "error",
-      "no-useless-concat": "error",
+      "@typescript-eslint/no-unused-vars": [
+        "error",
+        { varsIgnorePattern: "^_", argsIgnorePattern: "^_", caughtErrorsIgnorePattern: "^_" },
+      ],
+      "@typescript-eslint/no-explicit-any": "warn",
     },
   },
 ];

examples/angular/README.md

@@ -38,10 +38,10 @@ This will compile your project and store the build artifacts in the `dist/` dire
 
 ## Running unit tests
 
-To execute unit tests with the [Karma](https://karma-runner.github.io) test runner, use the following command:
+To execute unit tests with [Vitest](https://vitest.dev), use the following command:
 
 ```bash
-ng test
+pnpm test
 ```
 
 ## Running end-to-end tests

examples/angular/angular.json

@@ -69,21 +69,6 @@
         },
         "extract-i18n": {
           "builder": "@angular/build:extract-i18n"
-        },
-        "test": {
-          "builder": "@angular/build:karma",
-          "options": {
-            "polyfills": ["zone.js", "zone.js/testing"],
-            "tsConfig": "tsconfig.spec.json",
-            "assets": [
-              {
-                "glob": "**/*",
-                "input": "public"
-              }
-            ],
-            "styles": ["src/styles.css"],
-            "scripts": []
-          }
         }
       }
     },
@@ -107,13 +92,6 @@
             }
           },
           "defaultConfiguration": "production"
-        },
-        "test": {
-          "builder": "@angular/build:karma",
-          "options": {
-            "tsConfig": "projects/angular/tsconfig.spec.json",
-            "polyfills": ["zone.js", "zone.js/testing"]
-          }
         }
       }
     }

examples/angular/eslint.config.js

@@ -16,6 +16,8 @@
 
 import js from "@eslint/js";
 import prettier from "eslint-config-prettier";
+import typescript from "@typescript-eslint/eslint-plugin";
+import typescriptParser from "@typescript-eslint/parser";
 
 export default [
   { ignores: ["dist/**", "node_modules/**", ".angular/**"] },
@@ -26,13 +28,18 @@ export default [
     languageOptions: {
       ecmaVersion: 2022,
       sourceType: "module",
+      parser: typescriptParser,
       parserOptions: {
         project: "./tsconfig.json",
       },
     },
+    plugins: {
+      "@typescript-eslint": typescript,
+    },
     rules: {
-      "no-unused-vars": ["error", { varsIgnorePattern: "^_", argsIgnorePattern: "^_" }],
-      "no-console": "warn",
+      "no-unused-vars": "off", // Use TypeScript version instead
+      "no-console": "off", // Allow console in examples
+      "no-undef": "off", // TypeScript handles this
       "prefer-const": "error",
       "no-var": "error",
       "@typescript-eslint/no-explicit-any": "warn",