Skip to content

Commit 59331c4

Browse files
authored
Merge pull request #482 from firebase/remove_extra_comma
revert to node6 on travis and remove extra comma in gulp script
2 parents 1c4b650 + 7a40789 commit 59331c4

File tree

3 files changed

+2238
-2238
lines changed

3 files changed

+2238
-2238
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
language: node_js
22
node_js:
3-
- '8'
3+
- '6'
44
install: npm install
55
script: npm test -- --saucelabs
66
before_install:

gulpfile.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ function repeatTaskForAllLocales(taskName, dependencies, operation) {
172172
const localeDependencies = dependencies.map(replaceTokens);
173173
gulp.task(localeTaskName, gulp.series(
174174
gulp.parallel.apply(null, localeDependencies),
175-
() => operation(locale),
175+
() => operation(locale)
176176
));
177177
return localeTaskName;
178178
});
@@ -256,7 +256,7 @@ gulp.task('build-externs',
256256
repeatTaskForAllLocales(
257257
'build-firebaseui-js-$',
258258
['build-externs', 'build-ts', 'build-soy'],
259-
buildFirebaseUiJs,
259+
buildFirebaseUiJs
260260
);
261261

262262
// Bundles the FirebaseUI JS with its dependencies as a NPM module. This builds
@@ -274,19 +274,19 @@ const buildJsTasks = repeatTaskForAllLocales(
274274
// Builds the final JS file for the default language.
275275
gulp.task('build-js', gulp.series(
276276
'build-js-' + DEFAULT_LOCALE,
277-
() => makeDefaultFile('firebaseui'),
277+
() => makeDefaultFile('firebaseui')
278278
));
279279

280280
// Builds the final JS file for all supported languages.
281281
gulp.task('build-all-js', gulp.series(
282282
gulp.parallel.apply(null, buildJsTasks),
283-
() => makeDefaultFile('firebaseui'),
283+
() => makeDefaultFile('firebaseui')
284284
));
285285

286286
// Builds the NPM module for the default language.
287287
gulp.task('build-npm', gulp.series(
288288
'build-npm-' + DEFAULT_LOCALE,
289-
() => makeDefaultFile('npm'),
289+
() => makeDefaultFile('npm')
290290
));
291291

292292
/**
@@ -337,16 +337,16 @@ gulp.task('clean', () => fse.remove(TMP_DIR));
337337
gulp.task('default', gulp.series(
338338
gulp.parallel(
339339
'build-externs', 'build-ts', 'build-js',
340-
'build-npm', 'build-css', 'build-css-rtl',
340+
'build-npm', 'build-css', 'build-css-rtl'
341341
),
342-
'clean',
342+
'clean'
343343
));
344344

345345
// Builds everything (JS for all languages, both LTR and RTL CSS).
346346
gulp.task('build-all', gulp.series(
347347
gulp.parallel(
348348
'build-externs', 'build-ts', 'build-all-js',
349-
'build-npm', 'build-css', 'build-css-rtl',
349+
'build-npm', 'build-css', 'build-css-rtl'
350350
),
351-
'clean',
351+
'clean'
352352
));

0 commit comments

Comments
 (0)