Merge branch '@invertase/v7-development' of https://github.com/firebase/firebaseui-web into @invertase/brands

Author: Ehesp

.github/workflows/lint.yaml

@@ -0,0 +1,35 @@
+name: Lint and Format Check
+
+on:
+  push:
+    branches:
+      - "@invertase/v7-development"
+  pull_request:
+
+jobs:
+  lint:
+    name: Lint and Format Check
+    runs-on: ubuntu-latest
+    
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+        
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: '20'
+          
+      - name: Setup pnpm
+        uses: pnpm/action-setup@v4
+        with:
+          version: 10
+            
+      - name: Install dependencies
+        run: pnpm install --frozen-lockfile
+        
+      - name: Run ESLint check
+        run: pnpm run lint:check
+        
+      - name: Run Prettier check
+        run: pnpm run format:check

.github/workflows/test.yaml

@@ -3,31 +3,38 @@ name: Test
 on:
   push:
     branches:
-      - "**"
+      - "@invertase/v7-development"
   pull_request:
-    branches:
-      - "**"
 
 jobs:
+
   test:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
         uses: actions/checkout@v4
+
       - name: Setup node
         uses: actions/setup-node@v4
         with:
           node-version: '20'
           check-latest: true
+
       - name: Setup pnpm
         uses: pnpm/action-setup@v4
         with:
           version: latest
+
       - name: Install dependencies
         run: pnpm install
+
+      - name: Build packages
+        run: pnpm run build
+
       - name: Install Firebase CLI
         run: npm i -g [email protected]
-      - name: Start Firebase emulator and run tests
+
+      - name: Start Firebase emulator
         run: |
           firebase emulators:start --only auth --project demo-test &
           sleep 15
@@ -36,5 +43,7 @@ jobs:
             echo "Waiting for emulator to start..."
             sleep 2
           done
-          echo "Emulator is ready, running tests..."
-          pnpm test
+          echo "Emulator is ready"
+
+      - name: Run tests
+        run: pnpm test

.gitignore

@@ -15,6 +15,9 @@ dist-ssr
 # Angular
 .angular
 
+# Next.js
+.next
+
 # Coverage
 coverage
 

.prettierignore

@@ -13,6 +13,7 @@ releases/
 # Generated files
 *.min.js
 *.min.css
+packages/styles/dist.css
 
 # Logs
 *.log

eslint.config.js

@@ -0,0 +1,66 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */
+
+import js from "@eslint/js";
+import { globalIgnores } from "eslint/config";
+import globals from "globals";
+import tseslint from "typescript-eslint";
+import pluginPrettier from "eslint-plugin-prettier";
+import pluginReact from "eslint-plugin-react";
+import pluginReactHooks from "eslint-plugin-react-hooks";
+
+const config: any[] = [
+  globalIgnores([
+    "**/dist/**",
+    "**/node_modules/**",
+    "**/build/**",
+    "**/.next/**",
+    "**/.angular/**",
+    "**/releases/**",
+    "packages/styles/dist.css",
+    "packages/angular/**",
+  ]),
+  ...tseslint.configs.recommended,
+  {
+    // All TypeScript files
+    files: ["**/*.ts", "**/*.tsx"],
+    plugins: { js, prettier: pluginPrettier },
+    languageOptions: { globals: { ...globals.browser, ...globals.node } },
+    rules: {
+      "prettier/prettier": "error",
+      "arrow-body-style": "off",
+      "prefer-arrow-callback": "off",
+    },
+  },
+  {
+    // React package specific rules
+    files: ["packages/react/src/**/*.{ts,tsx}"],
+    plugins: { react: pluginReact, "react-hooks": pluginReactHooks },
+    languageOptions: {
+      parserOptions: {
+        ecmaFeatures: {
+          jsx: true,
+        },
+      },
+    },
+    settings: {
+      react: {
+        version: "detect",
+      },
+    },
+    rules: {
+      ...pluginReact.configs.recommended.rules,
+      ...pluginReactHooks.configs.recommended.rules,
+      "react/react-in-jsx-scope": "off", // Not needed with React 17+
+    },
+  },
+  {
+    // Test files - more lenient rules
+    files: ["**/*.test.{ts,tsx}", "**/*.spec.{ts,tsx}", "**/tests/**/*.{ts,tsx}"],
+    rules: {
+      "@typescript-eslint/no-explicit-any": "off",
+      "@typescript-eslint/no-unused-vars": "off",
+    },
+  },
+];
+
+export default config;

eslint.config.ts

@@ -38,10 +38,10 @@ This will compile your project and store the build artifacts in the `dist/` dire
 
 ## Running unit tests
 
-To execute unit tests with the [Karma](https://karma-runner.github.io) test runner, use the following command:
+To execute unit tests with [Vitest](https://vitest.dev), use the following command:
 
 ```bash
-ng test
+pnpm test
 ```
 
 ## Running end-to-end tests

examples/angular/README.md

@@ -69,21 +69,6 @@
         },
         "extract-i18n": {
           "builder": "@angular/build:extract-i18n"
-        },
-        "test": {
-          "builder": "@angular/build:karma",
-          "options": {
-            "polyfills": ["zone.js", "zone.js/testing"],
-            "tsConfig": "tsconfig.spec.json",
-            "assets": [
-              {
-                "glob": "**/*",
-                "input": "public"
-              }
-            ],
-            "styles": ["src/styles.css"],
-            "scripts": []
-          }
         }
       }
     },
@@ -107,13 +92,6 @@
             }
           },
           "defaultConfiguration": "production"
-        },
-        "test": {
-          "builder": "@angular/build:karma",
-          "options": {
-            "tsConfig": "projects/angular/tsconfig.spec.json",
-            "polyfills": ["zone.js", "zone.js/testing"]
-          }
         }
       }
     }

examples/angular/angular.json

@@ -16,6 +16,8 @@
 
 import js from "@eslint/js";
 import prettier from "eslint-config-prettier";
+import typescript from "@typescript-eslint/eslint-plugin";
+import typescriptParser from "@typescript-eslint/parser";
 
 export default [
   { ignores: ["dist/**", "node_modules/**", ".angular/**"] },
@@ -26,13 +28,18 @@ export default [
     languageOptions: {
       ecmaVersion: 2022,
       sourceType: "module",
+      parser: typescriptParser,
       parserOptions: {
         project: "./tsconfig.json",
       },
     },
+    plugins: {
+      "@typescript-eslint": typescript,
+    },
     rules: {
-      "no-unused-vars": ["error", { varsIgnorePattern: "^_", argsIgnorePattern: "^_" }],
-      "no-console": "warn",
+      "no-unused-vars": "off", // Use TypeScript version instead
+      "no-console": "off", // Allow console in examples
+      "no-undef": "off", // TypeScript handles this
       "prefer-const": "error",
       "no-var": "error",
       "@typescript-eslint/no-explicit-any": "warn",