Skip to content

Commit a8a3868

Browse files
wti806bojeil-google
authored andcommitted
3.1release (#430)
- Adds privacyPolicyUrl config to enable developers to provide privacy policy URL. And shows Term of Service and Privacy Policy link on every screen for GDPR compliance. - Catches errors that occur due to incompatible versions of firebase.js being used with firebaseui.js. - Defines the FirebaseUI externs. - Defines the typescript definitions. - Optimizes sign in flow to use updateCurentUser eliminating 2 RPCs in the process. - Fixes reCAPTCHA invisible badge which was getting hidden.
1 parent a905ebd commit a8a3868

File tree

111 files changed

+2980
-1341
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

111 files changed

+2980
-1341
lines changed

README.md

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -387,8 +387,8 @@ FirebaseUI supports the following configuration parameters.
387387
<td>No</td>
388388
<td>
389389
The URL where to redirect the user after a successful sign-in.
390-
<strong>Required</strong> when the <code>signInSuccess</code> callback is not
391-
used or when it returns <code>true</code>.
390+
<strong>Required</strong> when the <code>signInSuccessWithAuthResult</code>
391+
callback is not used or when it returns <code>true</code>.
392392
</td>
393393
</tr>
394394
<tr>
@@ -676,8 +676,8 @@ following properties.
676676

677677
FirebaseUI will wait for the returned promise to handle the reported error
678678
before clearing the UI. If no promise is returned, the UI will be cleared on
679-
completion. Even when this callback resolves, `signInSuccess` callback will not
680-
be triggered.
679+
completion. Even when this callback resolves, `signInSuccessWithAuthResult`
680+
callback will not be triggered.
681681

682682
This callback is required when `autoUpgradeAnonymousUsers` is enabled.
683683

@@ -716,14 +716,6 @@ FirebaseUI is displayed.
716716
// or whether we leave that to developer to handle.
717717
return true;
718718
},
719-
signInSuccess: function(currentUser, credential, redirectUrl) {
720-
// This callback will be deprecated. `signInSuccessWithAuthResult` should
721-
// be used instead.
722-
// Do something.
723-
// Return type determines whether we continue the redirect automatically
724-
// or whether we leave that to developer to handle.
725-
return true;
726-
},
727719
signInFailure: function(error) {
728720
// Some unrecoverable error occurred during sign-in.
729721
// Return a promise when error handling is completed and FirebaseUI
@@ -898,8 +890,8 @@ ui.start('#firebaseui-auth-container', {
898890
data = null;
899891
// FirebaseUI will reset and the UI cleared when this promise
900892
// resolves.
901-
// signInSuccess will not run. Successful sign-in logic has to be
902-
// run explicitly.
893+
// signInSuccessWithAuthResult will not run. Successful sign-in
894+
// logic has to be run explicitly.
903895
window.location.assign('<url-to-redirect-to-on-success>');
904896
});
905897

@@ -939,8 +931,8 @@ configuration parameter.
939931
You can pass a query parameter to the widget's URL that will overwrite the URL
940932
the user is redirected to after a successful sign-in. If you do so, you must set
941933
the configuration `signInSuccessUrl` value (even if it will be overwritten).
942-
When passing the redirect URL this way, the `signInSuccess` callback will
943-
receive the value as the `redirectUrl` argument.
934+
When passing the redirect URL this way, the `signInSuccessWithAuthResult`
935+
callback will receive the value as the `redirectUrl` argument.
944936

945937
You **must include the mode explicitly** in the URL when using the
946938
`signInSuccessUrl` parameter, otherwise FirebaseUI will directly redirect to the

0 commit comments

Comments
 (0)