fixed the issue that cordova opens webview instead of system browser (#486)

Author: wti806

javascript/utils/util.js

@@ -57,6 +57,12 @@ firebaseui.auth.util.getScheme = function() {
 };
 
 
+/** @return {boolean} Whether Cordova InAppBrowser plugin is installed. */
+firebaseui.auth.util.isCordovaInAppBrowserInstalled = function() {
+  return !!(window['cordova'] && window['cordova']['InAppBrowser']);
+};
+
+
 /** @return {boolean} Whether current scheme is HTTP or HTTPS. */
 firebaseui.auth.util.isHttpOrHttps = function() {
   return firebaseui.auth.util.getScheme() === 'http:' ||

javascript/widgets/config.js

@@ -641,7 +641,10 @@ firebaseui.auth.widget.Config.prototype.getTosUrl = function() {
       return /** @type {function()} */ (tosUrl);
     } else if (goog.isString(tosUrl)) {
       return function() {
-        firebaseui.auth.util.open(/** @type {string} */ (tosUrl), '_blank');
+        firebaseui.auth.util.open(
+            /** @type {string} */ (tosUrl),
+            firebaseui.auth.util.isCordovaInAppBrowserInstalled() ?
+            '_system' : '_blank');
       };
     }
   }
@@ -666,7 +669,9 @@ firebaseui.auth.widget.Config.prototype.getPrivacyPolicyUrl = function() {
     } else if (goog.isString(privacyPolicyUrl)) {
       return function() {
         firebaseui.auth.util.open(
-            /** @type {string} */ (privacyPolicyUrl), '_blank');
+            /** @type {string} */ (privacyPolicyUrl),
+            firebaseui.auth.util.isCordovaInAppBrowserInstalled() ?
+            '_system' : '_blank');
       };
     }
   }

javascript/widgets/config_test.js

@@ -1034,6 +1034,17 @@ function testGetTosUrl() {
       [
         'Privacy Policy URL is missing, the link will not be displayed.'
       ], warningLogMessages);
+  // Mock that Cordova InAppBrowser plugin is installed.
+  stub.replace(
+      firebaseui.auth.util,
+      'isCordovaInAppBrowserInstalled',
+      function() {
+        return true;
+      });
+  tosCallback = config.getTosUrl();
+  tosCallback();
+  // Target should be _system if Cordova InAppBrowser plugin is installed.
+  testUtil.assertOpen('http://localhost/tos', '_system');
   // Tests if callback function is passed to tosUrl config.
   tosCallback = function() {};
   config.update('tosUrl', tosCallback);
@@ -1062,6 +1073,17 @@ function testGetPrivacyPolicyUrl() {
       [
         'Term of Service URL is missing, the link will not be displayed.'
       ], warningLogMessages);
+  // Mock that Cordova InAppBrowser plugin is installed.
+  stub.replace(
+      firebaseui.auth.util,
+      'isCordovaInAppBrowserInstalled',
+      function() {
+        return true;
+      });
+  privacyPolicyCallback = config.getPrivacyPolicyUrl();
+  privacyPolicyCallback();
+  // Target should be _system if Cordova InAppBrowser plugin is installed.
+  testUtil.assertOpen('http://localhost/privacy_policy', '_system');
   // Tests if callback function is passed to privacyPolicyUrl config.
   privacyPolicyCallback = function() {};
   config.update('privacyPolicyUrl', privacyPolicyCallback);