Skip to content

Commit c2f16fc

Browse files
authored
fix(*): updated peer dependencies
2 parents 7af2bbb + 35c56ee commit c2f16fc

File tree

11 files changed

+762
-801
lines changed

11 files changed

+762
-801
lines changed

examples/angular/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
"@tanstack/angular-form": "^0.42.0",
5050
"@types/express": "^4.17.17",
5151
"@types/jasmine": "~5.1.0",
52-
"@types/node": "^18.18.0",
52+
"@types/node": "^20.19.0",
5353
"eslint": "^9.22.0",
5454
"eslint-config-prettier": "^9.1.0",
5555
"firebase": "^11",

packages/angular/package.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,20 +23,19 @@
2323
"release": "pnpm pack --pack-destination ../../releases/"
2424
},
2525
"peerDependencies": {
26-
"@angular/common": "catalog:peerDependencies",
27-
"@angular/core": "catalog:peerDependencies",
28-
"@firebase-ui/core": "workspace:*",
29-
"@firebase-ui/translations": "workspace:*"
26+
"@angular/fire": "catalog:peerDependencies"
3027
},
3128
"dependencies": {
29+
"@firebase-ui/core": "workspace:*",
30+
"@firebase-ui/styles": "workspace:*",
3231
"@tanstack/angular-form": "^1.1.0",
3332
"tslib": "^2.8.1",
34-
"nanostores": "catalog:",
35-
"firebase": "catalog:"
33+
"nanostores": "catalog:"
3634
},
3735
"sideEffects": false,
3836
"devDependencies": {
3937
"@angular/core": "catalog:",
38+
"@angular/common": "catalog:",
4039
"@angular/forms": "catalog:",
4140
"@angular/router": "catalog:",
4241
"@angular/fire": "catalog:",
@@ -46,6 +45,7 @@
4645
"@angular/compiler-cli": "catalog:",
4746
"@angular/platform-browser": "catalog:",
4847
"@angular/platform-browser-dynamic": "catalog:",
48+
"firebase": "catalog:",
4949
"karma": "^6.4.4",
5050
"karma-chrome-launcher": "^3.2.0",
5151
"karma-coverage": "^2.2.1",

packages/angular/src/lib/provider.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ import {
2424
} from "@angular/core";
2525
import { FirebaseApps } from "@angular/fire/app";
2626
import { type FirebaseUI as FirebaseUIType, getTranslation } from "@firebase-ui/core";
27+
import { Tail } from "../types";
2728
import { distinctUntilChanged, map, takeUntil } from "rxjs/operators";
2829
import { Observable, ReplaySubject } from "rxjs";
2930
import { Store } from "nanostores";
30-
import { TranslationCategory, TranslationKey } from "@firebase-ui/translations";
3131

3232
const FIREBASE_UI_STORE = new InjectionToken<FirebaseUIType>("firebaseui.store");
3333
const FIREBASE_UI_POLICIES = new InjectionToken<PolicyConfig>("firebaseui.policies");
@@ -74,8 +74,9 @@ export class FirebaseUI {
7474
return this.useStore(this.store);
7575
}
7676

77-
translation<T extends TranslationCategory>(category: T, key: TranslationKey<T>) {
78-
return this.config().pipe(map((config) => getTranslation(config, category, key)));
77+
//TODO: This should be typed more specifically from the translations package
78+
translation(...args: Tail) {
79+
return this.config().pipe(map((config) => getTranslation(config, ...args)));
7980
}
8081

8182
useStore<T>(store: Store<T> | null): Observable<T> {

packages/angular/src/types.ts

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
/**
2+
* Copyright 2025 Google LLC
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License");
5+
* you may not use this file except in compliance with the License.
6+
* You may obtain a copy of the License at
7+
*
8+
* http://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS,
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
* See the License for the specific language governing permissions and
14+
* limitations under the License.
15+
*/
16+
17+
export type Tail = [
18+
any, // category
19+
any, // key
20+
];

packages/react/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
"react-dom": "catalog:peerDependencies"
4242
},
4343
"dependencies": {
44-
"@nanostores/react": "^0.8.4",
44+
"@nanostores/react": "^1.0.0",
4545
"@radix-ui/react-slot": "^1.2.3",
4646
"@tanstack/react-form": "^0.41.3",
4747
"clsx": "^2.1.1",

packages/styles/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ The packages also exports themes which overrides the CSS variables with preset c
2828
```css
2929
@import "tailwindcss";
3030
@import "@firebase-ui/styles/tailwind";
31-
@import "@firebase-ui/styles/themes/brualist"
31+
@import "@firebase-ui/styles/themes/brualist";
3232
```
3333

3434
## Building

packages/styles/dist.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/styles/src/index.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,14 +48,14 @@ describe("ButtonVariant type", () => {
4848
it("should accept valid variant values", () => {
4949
const primaryVariant: ButtonVariant = "primary";
5050
const secondaryVariant: ButtonVariant = "secondary";
51-
51+
5252
expect(primaryVariant).toBe("primary");
5353
expect(secondaryVariant).toBe("secondary");
5454
});
5555

5656
it("should work with buttonVariant function", () => {
5757
const variants: ButtonVariant[] = ["primary", "secondary"];
58-
58+
5959
variants.forEach((variant) => {
6060
const result = buttonVariant({ variant });
6161
expect(typeof result).toBe("string");

packages/styles/src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@ export const buttonVariant = cva({
1313
},
1414
});
1515

16-
export type ButtonVariant = VariantProps<typeof buttonVariant>['variant'];
16+
export type ButtonVariant = VariantProps<typeof buttonVariant>["variant"];

0 commit comments

Comments
 (0)