added tests for validating presence of display name field

Author: prakhar1989

demo/public/app.js

@@ -48,6 +48,7 @@ var uiConfig = {
   ],
   // Terms of service url.
   'tosUrl': 'https://www.google.com',
+  // Whether the display name should be displayed in Sign Up page.
   'shouldDisplayName': false
 };
 

javascript/ui/element/name.js

@@ -76,13 +76,15 @@ element.name.validate_ = function(nameElement, errorElement) {
 element.name.initNameElement = function() {
   var nameElement = element.name.getNameElement.call(this);
   var errorElement = element.name.getNameErrorElement.call(this);
-  element.listenForInputEvent(this, nameElement, function(e) {
-    // Clear but not show error on-the-fly.
-    if (element.isShown(errorElement)) {
-      element.setValid(nameElement, true);
-      element.hide(errorElement);
-    }
-  });
+  if (nameElement && errorElement) {
+    element.listenForInputEvent(this, nameElement, function(e) {
+      // Clear but not show error on-the-fly.
+      if (element.isShown(errorElement)) {
+        element.setValid(nameElement, true);
+        element.hide(errorElement);
+      }
+    });
+  }
 };
 
 

javascript/ui/page/passwordsignup_test.js

@@ -114,6 +114,22 @@ function testInitialFocus_name() {
 }
 
 
+function testDisplayNameIsNotRendered() {
+  if (goog.userAgent.IE && !goog.userAgent.isDocumentModeOrHigher(9)) {
+    return;
+  }
+  component.dispose();
+  component = new firebaseui.auth.ui.page.PasswordSignUp(
+      null,
+      false,
+      goog.bind(
+          firebaseui.auth.ui.element.FormTestHelper.prototype.onSubmit,
+          formTestHelper));
+  component.render(root);
+  assertEquals(component.getNameElement(), null);
+}
+
+
 function testInitialFocus_newPassword() {
   if (goog.userAgent.IE && !goog.userAgent.isDocumentModeOrHigher(9)) {
     return;

javascript/widgets/config_test.js

@@ -242,6 +242,13 @@ function testGetTosUrl() {
 }
 
 
+function testShouldDisplayName() {
+  assertTrue(config.getShouldDisplayName());
+  config.update('shouldDisplayName', false);
+  assertFalse(config.getShouldDisplayName());
+}
+
+
 function testSetConfig() {
   config.setConfig({tosUrl: 'www.testUrl.com'});
   assertEquals('www.testUrl.com', config.getTosUrl());