Merge branch '@invertase/v7-development' of https://github.com/firebase/firebaseui-web into @invertase/require-display-name-behavior

Author: Ehesp

.github/workflows/lint.yaml

@@ -0,0 +1,35 @@
+name: Lint and Format Check
+
+on:
+  push:
+    branches:
+      - "@invertase/v7-development"
+  pull_request:
+
+jobs:
+  lint:
+    name: Lint and Format Check
+    runs-on: ubuntu-latest
+    
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+        
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: '20'
+          
+      - name: Setup pnpm
+        uses: pnpm/action-setup@v4
+        with:
+          version: 10
+            
+      - name: Install dependencies
+        run: pnpm install --frozen-lockfile
+        
+      - name: Run ESLint check
+        run: pnpm run lint:check
+        
+      - name: Run Prettier check
+        run: pnpm run format:check

.github/workflows/test.yaml

@@ -3,54 +3,38 @@ name: Test
 on:
   push:
     branches:
-      - "**"
+      - "@invertase/v7-development"
   pull_request:
-    branches:
-      - "**"
 
 jobs:
-  lint:
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-      - name: Setup node
-        uses: actions/setup-node@v4
-        with:
-          node-version: '20'
-          check-latest: true
-      - name: Setup pnpm
-        uses: pnpm/action-setup@v4
-        with:
-          version: latest
-      - name: Install dependencies
-        run: pnpm install
-      - name: Run ESLint on core packages
-        run: pnpm --filter="@firebase-ui/*" run lint
-      - name: Run ESLint on example apps
-        run: pnpm --filter="angular-example" --filter="nextjs" --filter="react" run lint
-      - name: Check Prettier formatting
-        run: pnpm format:check
 
   test:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
         uses: actions/checkout@v4
+
       - name: Setup node
         uses: actions/setup-node@v4
         with:
           node-version: '20'
           check-latest: true
+
       - name: Setup pnpm
         uses: pnpm/action-setup@v4
         with:
           version: latest
+
       - name: Install dependencies
         run: pnpm install
+
+      - name: Build packages
+        run: pnpm run build
+
       - name: Install Firebase CLI
         run: npm i -g [email protected]
-      - name: Start Firebase emulator and run tests
+
+      - name: Start Firebase emulator
         run: |
           firebase emulators:start --only auth --project demo-test &
           sleep 15
@@ -59,5 +43,7 @@ jobs:
             echo "Waiting for emulator to start..."
             sleep 2
           done
-          echo "Emulator is ready, running tests..."
-          pnpm test
+          echo "Emulator is ready"
+
+      - name: Run tests
+        run: pnpm test

eslint.config.js

@@ -0,0 +1,66 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */
+
+import js from "@eslint/js";
+import { globalIgnores } from "eslint/config";
+import globals from "globals";
+import tseslint from "typescript-eslint";
+import pluginPrettier from "eslint-plugin-prettier";
+import pluginReact from "eslint-plugin-react";
+import pluginReactHooks from "eslint-plugin-react-hooks";
+
+const config: any[] = [
+  globalIgnores([
+    "**/dist/**",
+    "**/node_modules/**",
+    "**/build/**",
+    "**/.next/**",
+    "**/.angular/**",
+    "**/releases/**",
+    "packages/styles/dist.css",
+    "packages/angular/**",
+  ]),
+  ...tseslint.configs.recommended,
+  {
+    // All TypeScript files
+    files: ["**/*.ts", "**/*.tsx"],
+    plugins: { js, prettier: pluginPrettier },
+    languageOptions: { globals: { ...globals.browser, ...globals.node } },
+    rules: {
+      "prettier/prettier": "error",
+      "arrow-body-style": "off",
+      "prefer-arrow-callback": "off",
+    },
+  },
+  {
+    // React package specific rules
+    files: ["packages/react/src/**/*.{ts,tsx}"],
+    plugins: { react: pluginReact, "react-hooks": pluginReactHooks },
+    languageOptions: {
+      parserOptions: {
+        ecmaFeatures: {
+          jsx: true,
+        },
+      },
+    },
+    settings: {
+      react: {
+        version: "detect",
+      },
+    },
+    rules: {
+      ...pluginReact.configs.recommended.rules,
+      ...pluginReactHooks.configs.recommended.rules,
+      "react/react-in-jsx-scope": "off", // Not needed with React 17+
+    },
+  },
+  {
+    // Test files - more lenient rules
+    files: ["**/*.test.{ts,tsx}", "**/*.spec.{ts,tsx}", "**/tests/**/*.{ts,tsx}"],
+    rules: {
+      "@typescript-eslint/no-explicit-any": "off",
+      "@typescript-eslint/no-unused-vars": "off",
+    },
+  },
+];
+
+export default config;

eslint.config.ts

@@ -14,10 +14,10 @@
  * limitations under the License.
  */
 
-import { bootstrapApplication } from "@angular/platform-browser";
+import { bootstrapApplication, BootstrapContext } from "@angular/platform-browser";
 import { AppComponent } from "./app/app.component";
 import { config } from "./app/app.config.server";
 
-const bootstrap = (context: any) => bootstrapApplication(AppComponent, config, context);
+const bootstrap = (context: BootstrapContext) => bootstrapApplication(AppComponent, config, context);
 
 export default bootstrap;

examples/angular/src/main.server.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */
 /**
  * Copyright 2025 Google LLC
  *

examples/angular/src/test-setup.ts

@@ -18,15 +18,16 @@
 
 import { NavLink } from "react-router";
 import { useUser } from "../firebase/hooks";
-import { signOut, type User } from "firebase/auth";
+import { signOut } from "firebase/auth";
 import { auth } from "../firebase/firebase";
 
 export function Header() {
   const user = useUser();
 
   async function onSignOut() {
     await signOut(auth);
-    router.push("/sign-in");
+    // TODO: Use the router instead of window.location.href
+    window.location.href = "/";
   }
 
   return (

examples/react/src/components/header.tsx

@@ -15,5 +15,10 @@
  */
 
 export const firebaseConfig = {
-  // your Firebase config here
+  apiKey: "AIzaSyCvMftIUCD9lUQ3BzIrimfSfBbCUQYZf-I",
+  authDomain: "fir-ui-rework.firebaseapp.com",
+  projectId: "fir-ui-rework",
+  storageBucket: "fir-ui-rework.firebasestorage.app",
+  messagingSenderId: "200312857118",
+  appId: "1:200312857118:web:94e3f69b0e0a4a863f040f",
 };

examples/react/src/firebase/config.ts

@@ -27,9 +27,12 @@ export const auth = getAuth(firebaseApp);
 
 export const ui = initializeUI({
   app: firebaseApp,
-  behaviors: [autoAnonymousLogin(), oneTapSignIn({
-    clientId: '200312857118-lscdui98fkaq7ffr81446blafjn5o6r0.apps.googleusercontent.com',
-  })],
+  behaviors: [
+    autoAnonymousLogin(),
+    oneTapSignIn({
+      clientId: "200312857118-lscdui98fkaq7ffr81446blafjn5o6r0.apps.googleusercontent.com",
+    }),
+  ],
 });
 
 if (import.meta.env.MODE === "development") {

examples/react/src/firebase/firebase.ts

@@ -18,4 +18,4 @@
 @import "@firebase-ui/styles/tailwind";
 
 /* @import "@firebase-ui/styles/src/themes/dark.css"; */
-/* @import "@firebase-ui/styles/src/themes/brutalist.css"; */
+/* @import "@firebase-ui/styles/src/themes/brutalist.css"; */