File tree Expand file tree Collapse file tree 2 files changed +4
-3
lines changed Expand file tree Collapse file tree 2 files changed +4
-3
lines changed Original file line number Diff line number Diff line change @@ -386,7 +386,8 @@ firebaseui.auth.widget.Config.prototype.getProviderConfigs = function() {
386386 } else {
387387 return {
388388 providerId : option [ 'provider' ] ,
389- providerName : option [ 'providerName' ] || null ,
389+ // ProviderName should default to providerId if not provided.
390+ providerName : option [ 'providerName' ] || option [ 'provider' ] ,
390391 buttonColor : option [ 'buttonColor' ] || null ,
391392 iconUrl : option [ 'iconUrl' ] ?
392393 firebaseui . auth . util . sanitizeUrl ( option [ 'iconUrl' ] ) : null ,
Original file line number Diff line number Diff line change @@ -284,7 +284,6 @@ function testGetProviderConfigs() {
284284 { 'not a' : 'valid config' } ,
285285 {
286286 'provider' : 'yahoo.com' ,
287- 'providerName' : 'Yahoo' ,
288287 'buttonColor' : '#FFB6C1' ,
289288 'iconUrl' : '<url-of-the-icon-of-the-sign-in-button>'
290289 }
@@ -306,7 +305,8 @@ function testGetProviderConfigs() {
306305 } , providerConfigs [ 2 ] ) ;
307306 assertObjectEquals ( {
308307 providerId : 'yahoo.com' ,
309- providerName : 'Yahoo' ,
308+ // ProviderName should default to providerId if not provided.
309+ providerName : 'yahoo.com' ,
310310 buttonColor : '#FFB6C1' ,
311311 iconUrl : '<url-of-the-icon-of-the-sign-in-button>' ,
312312 loginHintKey : null
You can’t perform that action at this time.
0 commit comments