Fix types for sign-in options (#470)

Fixes signinoption types

Author: shiatsumat

externs/firebaseui-externs.js

@@ -231,7 +231,7 @@ firebaseui.auth.Config.prototype.signInFlow;
  * Determines the list of IdPs for handling federated sign-in, phone number as
  * well as password account sign-up.
  *
- * @type {!Array<!firebaseui.auth.SignInOption>|undefined}
+ * @type {!Array<!firebaseui.auth.SignInOption|string>|undefined}
  */
 firebaseui.auth.Config.prototype.signInOptions;
 
@@ -326,20 +326,29 @@ firebaseui.auth.SignInOption = function() {};
  */
 firebaseui.auth.SignInOption.prototype.provider;
 
+/**
+ * Defines the sign-in option needed to configure the FirebaseUI federated
+ * sign-in widget.
+ *
+ * @interface
+ * @extends {firebaseui.auth.SignInOption}
+ */
+firebaseui.auth.FederatedSignInOption = function() {};
+
 /**
  * The Auth method (typically the authorization endpoint) needed for one-tap
  * sign-up, eg: 'https://accounts.google.com'.
  *
  * @type {string|undefined}
  */
-firebaseui.auth.SignInOption.prototype.authMethod;
+firebaseui.auth.FederatedSignInOption.prototype.authMethod;
 
 /**
  * The OAuth client ID needed for one-tap sign-up credential helper.
  *
  * @type {string|undefined}
  */
-firebaseui.auth.SignInOption.prototype.clientId;
+firebaseui.auth.FederatedSignInOption.prototype.clientId;
 
 /**
  * The list of additional OAuth scopes for the selected provider.
@@ -351,7 +360,7 @@ firebaseui.auth.SignInOption.prototype.clientId;
  *
  * @type {!Array<string>|undefined}
  */
-firebaseui.auth.SignInOption.prototype.scopes;
+firebaseui.auth.FederatedSignInOption.prototype.scopes;
 
 /**
  * The custom OAuth parameters for the selected OAuth provider.
@@ -365,15 +374,33 @@ firebaseui.auth.SignInOption.prototype.scopes;
  *
  * @type {!Object|undefined}
  */
-firebaseui.auth.SignInOption.prototype.customParameters;
+firebaseui.auth.FederatedSignInOption.prototype.customParameters;
+
+/**
+ * Defines the sign-in option needed to configure the FirebaseUI email sign-in
+ * widget.
+ *
+ * @interface
+ * @extends {firebaseui.auth.SignInOption}
+ */
+firebaseui.auth.EmailSignInOption = function() {};
 
 /**
  * Whether to require the display name to be provided for email/password user
  * creation flow.
  *
  * @type {boolean|undefined}
  */
-firebaseui.auth.SignInOption.prototype.requireDisplayName;
+firebaseui.auth.EmailSignInOption.prototype.requireDisplayName;
+
+/**
+ * Defines the sign-in option needed to configure the FirebaseUI phone sign-in
+ * widget.
+ *
+ * @interface
+ * @extends {firebaseui.auth.SignInOption}
+ */
+firebaseui.auth.PhoneSignInOption = function() {};
 
 /**
  * The reCAPTCHA parameters needed to customize the reCAPTCHA for phone
@@ -392,14 +419,14 @@ firebaseui.auth.SignInOption.prototype.requireDisplayName;
  *   badge: (string|undefined)
  * }|undefined}
  */
-firebaseui.auth.SignInOption.prototype.recaptchaParameters;
+firebaseui.auth.PhoneSignInOption.prototype.recaptchaParameters;
 
 /**
  * Sets the default country, eg. (GB) for the United Kingdom.
  *
  * @type {string|undefined}
  */
-firebaseui.auth.SignInOption.prototype.defaultCountry;
+firebaseui.auth.PhoneSignInOption.prototype.defaultCountry;
 
 /**
  * The default national number which will be prefilled when the phone sign-in
@@ -410,7 +437,7 @@ firebaseui.auth.SignInOption.prototype.defaultCountry;
  *
  * @type {string|undefined}
  */
-firebaseui.auth.SignInOption.prototype.defaultNationalNumber;
+firebaseui.auth.PhoneSignInOption.prototype.defaultNationalNumber;
 
 /**
  * The full phone number string instead of the 'defaultCountry' and
@@ -421,7 +448,7 @@ firebaseui.auth.SignInOption.prototype.defaultNationalNumber;
  *
  * @type {string|undefined}
  */
-firebaseui.auth.SignInOption.prototype.loginHint;
+firebaseui.auth.PhoneSignInOption.prototype.loginHint;
 
 /**
  * Sets the whitelisted countries. Accept either ISO (alpha-2) or E164 formatted
@@ -432,7 +459,7 @@ firebaseui.auth.SignInOption.prototype.loginHint;
  *
  * @type {!Array<string>|undefined}
  */
-firebaseui.auth.SignInOption.prototype.whitelistedCountries;
+firebaseui.auth.PhoneSignInOption.prototype.whitelistedCountries;
 
 /**
  * Sets the blacklisted countries. Accept either ISO (alpha-2) or E164 formatted
@@ -443,4 +470,4 @@ firebaseui.auth.SignInOption.prototype.whitelistedCountries;
  *
  * @type {!Array<string>|undefined}
  */
-firebaseui.auth.SignInOption.prototype.blacklistedCountries;
+firebaseui.auth.PhoneSignInOption.prototype.blacklistedCountries;

types/index.d.ts

@@ -12,7 +12,7 @@
  * limitations under the License.
  */
 
-declare namespace firebaseui {}
+declare namespace firebaseui { }
 
 export as namespace firebaseui;
 
@@ -66,7 +66,8 @@ declare namespace firebaseui.auth {
     queryParameterForSignInSuccessUrl?: string;
     queryParameterForWidgetMode?: string;
     signInFlow?: string;
-    signInOptions?: Array<string | SignInOption>;
+    signInOptions?: Array<string
+      | FederatedSignInOption | EmailSignInOption | PhoneSignInOption>;
     signInSuccessUrl?: string;
     siteName?: string;
     tosUrl?: string;