Skip to content

Commit fbd8324

Browse files
authored
Added more browsers coverage (#72)
Added more browsers for testing, and fixed an issue with tests on mobile devices. Set Protractor configuration maxSessions to 5.
1 parent 7e9ca93 commit fbd8324

File tree

3 files changed

+56
-25
lines changed

3 files changed

+56
-25
lines changed

javascript/widgets/handler/starter_test.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,11 @@ function testHandleStartSignIn_redirect() {
3939

4040
/** Tests startSignIn in popup mode. */
4141
function testHandleSignInButton_popup() {
42+
if (firebaseui.auth.util.isMobileBrowser()) {
43+
// Mobile browsers cannot use popup mode (it is enforced to false by the
44+
// config).
45+
return;
46+
}
4247
// Set popup mode to true.
4348
app.setConfig({'popupMode': true});
4449
// Start sign in.

protractor.conf.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,8 @@ if (options.saucelabs) {
8383
// SauceLabs configuration.
8484
config.sauceUser = process.env.SAUCE_USERNAME;
8585
config.sauceKey = process.env.SAUCE_ACCESS_KEY;
86+
// Avoid going over the SauceLabs concurrency limit (5).
87+
config.maxSessions = 5;
8688
// List of browsers configurations tested.
8789
var sauceBrowsers = require('./sauce_browsers.json');
8890
// Configuration for SauceLabs browsers.

sauce_browsers.json

Lines changed: 49 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,54 +1,78 @@
11
[
22
{
33
"browserName" : "firefox",
4-
"platform" : "Linux",
5-
"version": "40.0"
4+
"platform" : "OS X 10.9",
5+
"version": "49.0",
6+
"name": "firefox-latest-mac"
67
},
78
{
8-
"browserName" : "firefox",
9-
"platform" : "Windows 7",
10-
"version": "40.0"
9+
"browserName" : "chrome",
10+
"platform" : "OS X 10.9",
11+
"timeZone": "Pacific",
12+
"version" : "54.0",
13+
"name": "chrome-latest-mac"
1114
},
1215
{
13-
"browserName" : "chrome",
16+
"browserName" : "internet explorer",
17+
"version" : "11.0",
1418
"platform" : "Windows 7",
1519
"timeZone": "Pacific",
16-
"version" : "51.0"
20+
"name": "ie-11-windows"
1721
},
1822
{
19-
"browserName" : "chrome",
20-
"platform" : "OS X 10.9",
23+
"browserName" : "internet explorer",
24+
"version" : "10.0",
25+
"timeZone": "Pacific",
26+
"platform" : "Windows 7",
27+
"name": "ie-10-windows"
28+
},
29+
{
30+
"browserName" : "internet explorer",
31+
"version" : "9.0",
32+
"platform" : "Windows 7",
2133
"timeZone": "Pacific",
22-
"version" : "51.0"
34+
"name": "ie-9-windows"
2335
},
2436
{
2537
"browserName" : "MicrosoftEdge",
2638
"platform" : "Windows 10",
2739
"timeZone": "Pacific",
28-
"version" : "13.10586"
40+
"version" : "14.14393",
41+
"name": "edge-14-windows"
2942
},
3043
{
31-
"browserName" : "internet explorer",
32-
"version" : "11.0",
33-
"platform" : "Windows 7",
34-
"timeZone": "Pacific"
44+
"browserName" : "safari",
45+
"version" : "6.0",
46+
"platform" : "OS X 10.8",
47+
"timeZone": "Pacific",
48+
"name": "safari-6-mac"
3549
},
3650
{
37-
"browserName" : "internet explorer",
51+
"browserName" : "safari",
3852
"version" : "10.0",
53+
"platform" : "OS X 10.11",
3954
"timeZone": "Pacific",
40-
"platform" : "Windows 7"
55+
"name": "safari-10-mac"
4156
},
4257
{
43-
"browserName" : "internet explorer",
44-
"version" : "9.0",
45-
"platform" : "Windows 7",
46-
"timeZone": "Pacific"
58+
"deviceName": "iPhone 6 Simulator",
59+
"platformName": "iOS",
60+
"platformVersion": "8.4",
61+
"browserName": "Safari",
62+
"name": "ios-84-sim"
4763
},
4864
{
49-
"browserName" : "safari",
50-
"version" : "7.0",
51-
"platform" : "OS X 10.9",
52-
"timeZone": "Pacific"
65+
"deviceName": "iPhone 6 Simulator",
66+
"platformName": "iOS",
67+
"platformVersion": "9.3",
68+
"browserName": "Safari",
69+
"name": "ios-93-sim"
70+
},
71+
{
72+
"deviceName": "Android Emulator",
73+
"platformName": "Android",
74+
"platformVersion": "5.1",
75+
"browserName": "Browser",
76+
"name": "android-51-sim"
5377
}
5478
]

0 commit comments

Comments
 (0)