Skip to content

Commit fdefa9f

Browse files
sophiehebwti806
authored andcommitted
Added id attribute to all input elements (#655)
* Added id attribute to all input elements.
1 parent 71ee94d commit fdefa9f

File tree

1 file changed

+18
-8
lines changed

1 file changed

+18
-8
lines changed

soy/elements.soy

Lines changed: 18 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
{@param? disabled: bool} /** Whether the email input is disabled or not. */
2626
{@param? changeEmail: bool} /** Whether to use change email label. */
2727
<div class="firebaseui-textfield mdl-textfield mdl-js-textfield mdl-textfield--floating-label">
28-
<label class="mdl-textfield__label firebaseui-label" for="email">
28+
<label class="mdl-textfield__label firebaseui-label" for="ui-sign-in-email-input">
2929
{if $changeEmail}
3030
{msg desc="Label of a change email address input field."}Enter new email address{/msg}
3131
{else}
@@ -35,6 +35,7 @@
3535
<input
3636
type="email"
3737
name="email"
38+
id="ui-sign-in-email-input"
3839
autocomplete="username"
3940
class="mdl-textfield__input firebaseui-input firebaseui-id-email"
4041
value="{$email ?: ''}"
@@ -63,10 +64,13 @@
6364
</button>
6465
<div class="mdl-textfield mdl-js-textfield mdl-textfield--floating-label{sp}
6566
firebaseui-textfield firebaseui-phone-input-wrapper">
66-
<label class="mdl-textfield__label firebaseui-label" for="phoneNumber">
67+
<label class="mdl-textfield__label firebaseui-label" for="ui-sign-in-phone-number-input">
6768
{msg desc="Label of an phone number input field."}Phone number{/msg}
6869
</label>
69-
<input type="tel" name="phoneNumber"
70+
<input
71+
type="tel"
72+
name="phoneNumber"
73+
id="ui-sign-in-phone-number-input"
7074
class="mdl-textfield__input firebaseui-input firebaseui-id-phone-number"
7175
value="{$nationalNumber ?: ''}">
7276
</div>
@@ -84,10 +88,13 @@
8488
{template .phoneConfirmationCode}
8589
<div class="firebaseui-textfield mdl-textfield mdl-js-textfield{sp}
8690
mdl-textfield--floating-label">
87-
<label class="mdl-textfield__label firebaseui-label" for="phoneConfirmationCode">
91+
<label class="mdl-textfield__label firebaseui-label" for="ui-sign-in-phone-confirmation-code-input">
8892
{msg desc="Label of 6-digit SMS verification code."}6-digit code{/msg}
8993
</label>
90-
<input type="number" name="phoneConfirmationCode"
94+
<input
95+
type="number"
96+
name="phoneConfirmationCode"
97+
id="ui-sign-in-phone-confirmation-code-input"
9198
class="mdl-textfield__input firebaseui-input firebaseui-id-phone-confirmation-code">
9299
</div>
93100
<div class="firebaseui-error-wrapper">
@@ -275,12 +282,13 @@
275282
{template .name}
276283
{@param? name: string} /** The display name to prefill. */
277284
<div class="firebaseui-textfield mdl-textfield mdl-js-textfield mdl-textfield--floating-label">
278-
<label class="mdl-textfield__label firebaseui-label" for="name">
285+
<label class="mdl-textfield__label firebaseui-label" for="ui-sign-in-name-input">
279286
{msg desc="Label of a field for setting the user's name."}First &amp; last name{/msg}
280287
</label>
281288
<input
282289
type="text"
283290
name="name"
291+
id="ui-sign-in-name-input"
284292
autocomplete="name"
285293
class="mdl-textfield__input firebaseui-input firebaseui-id-name"
286294
value="{$name ?: ''}">
@@ -300,7 +308,7 @@
300308
{@param? label: string} /** The placeholder text in the field, defaulting to "Choose password". */
301309
<div class="firebaseui-new-password-component">
302310
<div class="firebaseui-textfield mdl-textfield mdl-js-textfield mdl-textfield--floating-label">
303-
<label class="mdl-textfield__label firebaseui-label" for="newPassword">
311+
<label class="mdl-textfield__label firebaseui-label" for="ui-sign-in-new-password-input">
304312
{if $label}
305313
{$label}
306314
{else}
@@ -310,6 +318,7 @@
310318
<input
311319
type="password"
312320
name="newPassword"
321+
id="ui-sign-in-new-password-input"
313322
autocomplete="new-password"
314323
class="mdl-textfield__input firebaseui-input firebaseui-id-new-password">
315324
</div>
@@ -331,7 +340,7 @@
331340
{template .password}
332341
{@param? current: bool} /** Whether to show "Current password" or "Password" label. */
333342
<div class="firebaseui-textfield mdl-textfield mdl-js-textfield mdl-textfield--floating-label">
334-
<label class="mdl-textfield__label firebaseui-label" for="password">
343+
<label class="mdl-textfield__label firebaseui-label" for="ui-sign-in-password-input">
335344
{if $current}
336345
{msg desc="Label of a password field."}Current password{/msg}
337346
{else}
@@ -341,6 +350,7 @@
341350
<input
342351
type="password"
343352
name="password"
353+
id="ui-sign-in-password-input"
344354
autocomplete="current-password"
345355
class="mdl-textfield__input firebaseui-input firebaseui-id-password">
346356
</div>

0 commit comments

Comments
 (0)