Skip to content

Commit fe5f978

Browse files
committed
fix: Update framework base name
1 parent e1eda84 commit fe5f978

File tree

3 files changed

+7
-17
lines changed

3 files changed

+7
-17
lines changed

packages/core/src/register-framework.test.ts

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ describe("registerFramework", () => {
1818

1919
registerFramework(framework, version);
2020

21-
expect(registerVersion).toHaveBeenCalledWith("firebase-ui", version, framework);
21+
expect(registerVersion).toHaveBeenCalledWith("firebase-ui-web", version, framework);
2222
expect(registerVersion).toHaveBeenCalledTimes(1);
2323
});
2424

@@ -32,7 +32,7 @@ describe("registerFramework", () => {
3232

3333
expect(registerVersion).toHaveBeenCalledTimes(frameworks.length);
3434
frameworks.forEach((framework) => {
35-
expect(registerVersion).toHaveBeenCalledWith("firebase-ui", version, framework);
35+
expect(registerVersion).toHaveBeenCalledWith("firebase-ui-web", version, framework);
3636
});
3737
});
3838

@@ -46,27 +46,17 @@ describe("registerFramework", () => {
4646

4747
expect(registerVersion).toHaveBeenCalledTimes(versions.length);
4848
versions.forEach((version) => {
49-
expect(registerVersion).toHaveBeenCalledWith("firebase-ui", version, framework);
49+
expect(registerVersion).toHaveBeenCalledWith("firebase-ui-web", version, framework);
5050
});
5151
});
5252

53-
it("should handle empty string parameters", () => {
54-
const framework = "";
55-
const version = "";
56-
57-
registerFramework(framework, version);
58-
59-
expect(registerVersion).toHaveBeenCalledWith("firebase-ui", "", "");
60-
expect(registerVersion).toHaveBeenCalledTimes(1);
61-
});
62-
6353
it("should handle special characters in parameters", () => {
6454
const framework = "react";
6555
const version = "1.0.0-beta.1";
6656

6757
registerFramework(framework, version);
6858

69-
expect(registerVersion).toHaveBeenCalledWith("firebase-ui", version, framework);
59+
expect(registerVersion).toHaveBeenCalledWith("firebase-ui-web", version, framework);
7060
expect(registerVersion).toHaveBeenCalledTimes(1);
7161
});
7262
});

packages/core/src/register-framework.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,5 @@ import { registerVersion } from "firebase/app";
77
* @param version The version of the framework being registered.
88
*/
99
export function registerFramework(framework: string, version: string) {
10-
registerVersion("firebase-ui", version, framework);
10+
registerVersion("firebase-ui-web", version, framework);
1111
}

packages/react/src/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@
1717
import { registerFramework } from "@firebase-ui/core";
1818
import pkgJson from '../package.json';
1919

20-
registerFramework("react", pkgJson.version);
21-
2220
export * from "./auth";
2321
export * from "./hooks";
2422
export * from "./components";
2523
export { FirebaseUIProvider, type FirebaseUIProviderProps } from "./context";
24+
25+
registerFramework("react", pkgJson.version);

0 commit comments

Comments
 (0)