chore(remote_config): Remove cSettings from Package.swift (#17568)

koji-1009 · web-flow · commit 23382aff8d7e · 2025-07-30T09:12:05.000Z
diff --git a/packages/firebase_remote_config/firebase_remote_config/ios/firebase_remote_config/Package.swift b/packages/firebase_remote_config/firebase_remote_config/ios/firebase_remote_config/Package.swift
@@ -66,13 +66,11 @@ func loadPubspecVersions() throws -> (packageVersion: String, firebaseCoreVersio
   }
 }
 
-let library_version: String
 let firebase_sdk_version_string: String
 let firebase_core_version_string: String
 let shared_spm_tag = "-firebase-core-swift"
 
 do {
-  library_version = try loadPubspecVersions().packageVersion
   firebase_sdk_version_string = try loadFirebaseSDKVersion()
   firebase_core_version_string = try loadPubspecVersions().firebaseCoreVersion
 } catch {
@@ -109,11 +107,6 @@ let package = Package(
       ],
       resources: [
         .process("Resources"),
-      ],
-      cSettings: [
-        .headerSearchPath("include"),
-        .define("LIBRARY_VERSION", to: "\"\(library_version)\""),
-        .define("LIBRARY_NAME", to: "\"flutter-fire-rc\""),
       ]
     ),
   ]
diff --git a/packages/firebase_remote_config/firebase_remote_config/macos/firebase_remote_config/Package.swift b/packages/firebase_remote_config/firebase_remote_config/macos/firebase_remote_config/Package.swift
@@ -68,13 +68,11 @@ func loadPubspecVersions() throws -> (packageVersion: String, firebaseCoreVersio
   }
 }
 
-let library_version: String
 let firebase_sdk_version_string: String
 let firebase_core_version_string: String
 let shared_spm_tag = "-firebase-core-swift"
 
 do {
-  library_version = try loadPubspecVersions().packageVersion
   firebase_sdk_version_string = try loadFirebaseSDKVersion()
   firebase_core_version_string = try loadPubspecVersions().firebaseCoreVersion
 } catch {
@@ -111,11 +109,6 @@ let package = Package(
       ],
       resources: [
         .process("Resources"),
-      ],
-      cSettings: [
-        .headerSearchPath("include"),
-        .define("LIBRARY_VERSION", to: "\"\(library_version)\""),
-        .define("LIBRARY_NAME", to: "\"flutter-fire-rc\""),
       ]
     ),
   ]

Original file line number	Diff line number	Diff line change
`@@ -66,13 +66,11 @@ func loadPubspecVersions() throws -> (packageVersion: String, firebaseCoreVersio`
`66`	`66`	`}`
`67`	`67`	`}`
`68`	`68`
`69`		`-let library_version: String`
`70`	`69`	`let firebase_sdk_version_string: String`
`71`	`70`	`let firebase_core_version_string: String`
`72`	`71`	`let shared_spm_tag = "-firebase-core-swift"`
`73`	`72`
`74`	`73`	`do {`
`75`		`- library_version = try loadPubspecVersions().packageVersion`
`76`	`74`	`firebase_sdk_version_string = try loadFirebaseSDKVersion()`
`77`	`75`	`firebase_core_version_string = try loadPubspecVersions().firebaseCoreVersion`
`78`	`76`	`} catch {`
`@@ -109,11 +107,6 @@ let package = Package(`
`109`	`107`	`],`
`110`	`108`	`resources: [`
`111`	`109`	`.process("Resources"),`
`112`		`- ],`
`113`		`- cSettings: [`
`114`		`- .headerSearchPath("include"),`
`115`		`- .define("LIBRARY_VERSION", to: "\"\(library_version)\""),`
`116`		`- .define("LIBRARY_NAME", to: "\"flutter-fire-rc\""),`
`117`	`110`	`]`
`118`	`111`	`),`
`119`	`112`	`]`
Original file line number	Diff line number	Diff line change
`@@ -68,13 +68,11 @@ func loadPubspecVersions() throws -> (packageVersion: String, firebaseCoreVersio`
`68`	`68`	`}`
`69`	`69`	`}`
`70`	`70`
`71`		`-let library_version: String`
`72`	`71`	`let firebase_sdk_version_string: String`
`73`	`72`	`let firebase_core_version_string: String`
`74`	`73`	`let shared_spm_tag = "-firebase-core-swift"`
`75`	`74`
`76`	`75`	`do {`
`77`		`- library_version = try loadPubspecVersions().packageVersion`
`78`	`76`	`firebase_sdk_version_string = try loadFirebaseSDKVersion()`
`79`	`77`	`firebase_core_version_string = try loadPubspecVersions().firebaseCoreVersion`
`80`	`78`	`} catch {`
`@@ -111,11 +109,6 @@ let package = Package(`
`111`	`109`	`],`
`112`	`110`	`resources: [`
`113`	`111`	`.process("Resources"),`
`114`		`- ],`
`115`		`- cSettings: [`
`116`		`- .headerSearchPath("include"),`
`117`		`- .define("LIBRARY_VERSION", to: "\"\(library_version)\""),`
`118`		`- .define("LIBRARY_NAME", to: "\"flutter-fire-rc\""),`
`119`	`112`	`]`
`120`	`113`	`),`
`121`	`114`	`]`