Skip to content

Commit 2e042ba

Browse files
feat: bump firebase iOS SDK to v11.7.0 (#17011)
* feat: bump firebase iOS SDK to `v11.7.0` * test: reintroduce skipped tests
1 parent 9eac89e commit 2e042ba

File tree

3 files changed

+4
-12
lines changed

3 files changed

+4
-12
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
# https://firebase.google.com/support/release-notes/ios
22
def firebase_sdk_version!()
3-
'11.6.0'
3+
'11.7.0'
44
end

tests/integration_test/firebase_auth/firebase_auth_instance_e2e_test.dart

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -904,13 +904,8 @@ void main() {
904904

905905
Exception e = await getError();
906906
expect(e, isA<FirebaseAuthException>());
907-
// Exception code is returning internal-error but the underlying error is "identitytoolkit.getRecaptchaConfig is not implemented in the Auth Emulator."
908-
// This issue on firebase-ios-sdk: https://github.com/firebase/firebase-ios-sdk/issues/14242. Once this is resolved, we ought to reinstate the below.
909-
// It works fine on live project but returns internal-error on emulator.
910-
if (defaultTargetPlatform != TargetPlatform.iOS) {
911-
FirebaseAuthException exception = e as FirebaseAuthException;
912-
expect(exception.code, equals('invalid-phone-number'));
913-
}
907+
FirebaseAuthException exception = e as FirebaseAuthException;
908+
expect(exception.code, equals('invalid-phone-number'));
914909
});
915910

916911
test(

tests/integration_test/firebase_auth/firebase_auth_user_e2e_test.dart

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -251,10 +251,7 @@ void main() {
251251
},
252252
skip: kIsWeb ||
253253
defaultTargetPlatform == TargetPlatform.macOS ||
254-
defaultTargetPlatform == TargetPlatform.windows
255-
// on iOS, returning an exception but underlying exception is: "identitytoolkit.getRecaptchaConfig is not implemented in the Auth Emulator."
256-
// which might be a result of this issue: https://github.com/firebase/firebase-ios-sdk/issues/14242. Once resolved, try to reinstate.
257-
|| defaultTargetPlatform == TargetPlatform.iOS,
254+
defaultTargetPlatform == TargetPlatform.windows,
258255
); // verifyPhoneNumber not supported on web.
259256

260257
test(

0 commit comments

Comments
 (0)