Skip to content

Commit 3c24bdf

Browse files
Fix git action failures for analyze, test
Removed a test no longer valid
1 parent 68bc426 commit 3c24bdf

File tree

5 files changed

+10
-41
lines changed

5 files changed

+10
-41
lines changed

packages/firebase_data_connect/firebase_data_connect/lib/src/core/ref.dart

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -144,14 +144,17 @@ class QueryManager {
144144
// this is dependent on the cachemanager, which is initialized lazily
145145
// this should be called whenever cacheManager is initialized.
146146
if (dataConnect.cacheManager != null) {
147-
_impactedQueriesSubscription =
148-
dataConnect.cacheManager!.impactedQueries.listen((impactedQueryIds) {
147+
_impactedQueriesSubscription = dataConnect.cacheManager!.impactedQueries
148+
.listen((impactedQueryIds) async {
149149
for (final queryId in impactedQueryIds) {
150150
final queryRef = trackedQueries[queryId];
151151
if (queryRef != null) {
152-
queryRef
153-
.execute(fetchPolicy: QueryFetchPolicy.cacheOnly)
154-
.catchError((e) => log('Error executing impacted query $e'));
152+
try {
153+
await queryRef.execute(
154+
fetchPolicy: QueryFetchPolicy.cacheOnly);
155+
} catch (e) {
156+
log('Error executing impacted query $e');
157+
}
155158
}
156159
}
157160
});

packages/firebase_data_connect/firebase_data_connect/pubspec.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@ dependencies:
2121
grpc: ^3.2.4
2222
http: ^1.2.1
2323
intl: ^0.20.2
24+
path: ^1.9.0
25+
path_provider: ^2.0.0
2426
protobuf: ^3.1.0
2527
sqlite3: ^2.9.0
2628
sqlite3_flutter_libs: ^0.5.40
27-
path_provider: ^2.0.0
28-
path: ^1.9.0
2929

3030
dev_dependencies:
3131
build_runner: ^2.4.12

packages/firebase_data_connect/firebase_data_connect/test/src/cache/cache_manager_test.dart

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ import 'dart:convert';
3232
import 'package:mockito/annotations.dart';
3333
import 'package:mockito/mockito.dart';
3434

35-
import '../core/ref_test.dart';
3635
@GenerateNiceMocks([MockSpec<FirebaseApp>(), MockSpec<ConnectorConfig>()])
3736
import '../firebase_data_connect_test.mocks.dart';
3837
import '../network/rest_transport_test.mocks.dart';
@@ -43,17 +42,12 @@ class MockDataConnectTransport extends Mock implements DataConnectTransport {}
4342

4443
void main() {
4544
late MockFirebaseApp mockApp;
46-
late MockFirebaseAuth mockAuth;
4745
late MockConnectorConfig mockConnectorConfig;
4846
late FirebaseDataConnect dataConnect;
4947
late MockClient mockHttpClient;
5048
late RestTransport transport;
5149
const Duration maxAgeSeconds = Duration(milliseconds: 200);
5250

53-
const String entityObject = '''
54-
{"desc":"itemDesc1","name":"itemOne", "cacheId":"123","price":4}
55-
''';
56-
5751
const String simpleQueryResponse = '''
5852
{"data": {"items":[
5953

packages/firebase_data_connect/firebase_data_connect/test/src/cache/result_tree_processor_test.dart

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,10 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
import 'package:firebase_data_connect/firebase_data_connect.dart';
16-
import 'package:firebase_data_connect/src/cache/cache_data_types.dart';
1715
import 'package:firebase_data_connect/src/cache/result_tree_processor.dart';
18-
import 'package:firebase_data_connect/src/common/common_library.dart';
1916

2017
import 'package:flutter_test/flutter_test.dart';
2118
import 'dart:convert';
22-
import 'dart:collection';
2319

2420
import 'package:firebase_data_connect/src/cache/in_memory_cache_provider.dart';
2521

packages/firebase_data_connect/firebase_data_connect/test/src/network/rest_transport_test.dart

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -87,30 +87,6 @@ void main() {
8787
);
8888
});
8989

90-
test('invokeOperation should return deserialized data', () async {
91-
final mockResponse = http.Response('{"data": {"key": "value"}}', 200);
92-
when(
93-
mockHttpClient.post(
94-
any,
95-
headers: anyNamed('headers'),
96-
body: anyNamed('body'),
97-
),
98-
).thenAnswer((_) async => mockResponse);
99-
100-
final deserializer = (String data) => 'Deserialized Data';
101-
102-
final result = await transport.invokeOperation(
103-
'testQuery',
104-
'executeQuery',
105-
deserializer,
106-
null,
107-
null,
108-
null,
109-
);
110-
111-
expect(result, 'Deserialized Data');
112-
});
113-
11490
test('invokeOperation should throw unauthorized error on 401 response',
11591
() async {
11692
final mockResponse = http.Response('Unauthorized', 401);

0 commit comments

Comments
 (0)