chore: update lints across packages (#13007)

kevmoo · web-flow · commit 88e59c3b9a41 · 2024-06-27T09:47:27.000+02:00
diff --git a/packages/firebase_app_installations/firebase_app_installations/example/lib/main.dart b/packages/firebase_app_installations/firebase_app_installations/example/lib/main.dart
@@ -3,9 +3,10 @@
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:developer';
-import 'package:flutter/material.dart';
-import 'package:firebase_core/firebase_core.dart';
+
 import 'package:firebase_app_installations/firebase_app_installations.dart';
+import 'package:firebase_core/firebase_core.dart';
+import 'package:flutter/material.dart';
 
 import 'firebase_options.dart';
 
@@ -20,7 +21,7 @@ void main() async {
 }
 
 class MyApp extends StatelessWidget {
-  const MyApp({Key? key}) : super(key: key);
+  const MyApp({super.key});
 
   @override
   Widget build(BuildContext context) {
@@ -37,10 +38,10 @@ class MyApp extends StatelessWidget {
 }
 
 class InstallationsCard extends StatefulWidget {
-  const InstallationsCard({Key? key}) : super(key: key);
+  const InstallationsCard({super.key});
 
   @override
-  _InstallationsCardState createState() => _InstallationsCardState();
+  State<InstallationsCard> createState() => _InstallationsCardState();
 }
 
 class _InstallationsCardState extends State<InstallationsCard> {
@@ -58,6 +59,7 @@ class _InstallationsCardState extends State<InstallationsCard> {
       // Make sure that the Auth Token is updated once the Installation Id is updated
       getAuthToken();
 
+      // ignore: use_build_context_synchronously
       ScaffoldMessenger.of(context).showSnackBar(const SnackBar(
         content: Text('New Firebase Installations Id generated 🎉'),
         backgroundColor: Colors.green,
@@ -89,10 +91,10 @@ class _InstallationsCardState extends State<InstallationsCard> {
 
   Future<void> getId() async {
     try {
-      final _newid = await FirebaseInstallations.instance.getId();
+      final newId = await FirebaseInstallations.instance.getId();
 
       setState(() {
-        id = _newid;
+        id = newId;
       });
     } catch (e) {
       log('$e');
diff --git a/packages/firebase_app_installations/firebase_app_installations/example/pubspec.yaml b/packages/firebase_app_installations/firebase_app_installations/example/pubspec.yaml
@@ -15,7 +15,7 @@ dependencies:
     sdk: flutter
 
 dev_dependencies:
-  flutter_lints: ^1.0.0
+  flutter_lints: ^4.0.0
 
 flutter:
   uses-material-design: true
diff --git a/packages/firebase_app_installations/firebase_app_installations_platform_interface/pubspec.yaml b/packages/firebase_app_installations/firebase_app_installations_platform_interface/pubspec.yaml
@@ -20,4 +20,4 @@ dev_dependencies:
   firebase_core_platform_interface: ^5.1.0
   flutter_test:
     sdk: flutter
-  flutter_lints: ^1.0.0
+  flutter_lints: ^4.0.0
diff --git a/packages/firebase_app_installations/firebase_app_installations_web/lib/firebase_app_installations_web.dart b/packages/firebase_app_installations/firebase_app_installations_web/lib/firebase_app_installations_web.dart
@@ -2,13 +2,11 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-library firebase_app_installations_web;
-
+import 'package:firebase_app_installations_platform_interface/firebase_app_installations_platform_interface.dart';
 import 'package:firebase_core/firebase_core.dart';
 import 'package:firebase_core_web/firebase_core_web.dart';
 import 'package:firebase_core_web/firebase_core_web_interop.dart'
     as core_interop;
-import 'package:firebase_app_installations_platform_interface/firebase_app_installations_platform_interface.dart';
 import 'package:flutter_web_plugins/flutter_web_plugins.dart';
 
 import 'src/guard.dart';
diff --git a/packages/firebase_app_installations/firebase_app_installations_web/lib/src/interop/installations.dart b/packages/firebase_app_installations/firebase_app_installations_web/lib/src/interop/installations.dart
@@ -27,9 +27,7 @@ class Installations
     return _expando[jsObject] ??= Installations._fromJsObject(jsObject);
   }
 
-  Installations._fromJsObject(
-      installations_interop.InstallationsJsImpl jsObject)
-      : super.fromJsObject(jsObject);
+  Installations._fromJsObject(super.jsObject) : super.fromJsObject();
 
   Future<void> delete() =>
       (installations_interop.deleteInstallations(jsObject)).toDart;
diff --git a/packages/firebase_app_installations/firebase_app_installations_web/pubspec.yaml b/packages/firebase_app_installations/firebase_app_installations_web/pubspec.yaml
@@ -17,12 +17,12 @@ dependencies:
     sdk: flutter
   flutter_web_plugins:
     sdk: flutter
-  
+
 dev_dependencies:
   firebase_core_platform_interface: ^5.1.0
   flutter_test:
     sdk: flutter
-  flutter_lints: ^1.0.0
+  flutter_lints: ^4.0.0
 
 flutter:
   plugin:
diff --git a/packages/firebase_database/firebase_database_web/lib/firebase_database_web.dart b/packages/firebase_database/firebase_database_web/lib/firebase_database_web.dart
@@ -2,8 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-library firebase_database_web;
-
 import 'dart:async';
 import 'dart:js_interop';
 import 'package:collection/collection.dart';
@@ -49,8 +47,7 @@ class FirebaseDatabaseWeb extends DatabasePlatform {
 
   /// Builds an instance of [DatabaseWeb] with an optional [FirebaseApp] instance
   /// If [app] is null then the created instance will use the default [FirebaseApp]
-  FirebaseDatabaseWeb({FirebaseApp? app, String? databaseURL})
-      : super(app: app, databaseURL: databaseURL);
+  FirebaseDatabaseWeb({super.app, super.databaseURL});
 
   @override
   DatabasePlatform delegateFor(
diff --git a/packages/firebase_database/firebase_database_web/lib/src/data_snapshot_web.dart b/packages/firebase_database/firebase_database_web/lib/src/data_snapshot_web.dart
@@ -2,7 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-part of firebase_database_web;
+part of '../firebase_database_web.dart';
 
 /// Web implementation for firebase [DataSnapshotPlatform]
 class DataSnapshotWeb extends DataSnapshotPlatform {
diff --git a/packages/firebase_database/firebase_database_web/lib/src/database_event_web.dart b/packages/firebase_database/firebase_database_web/lib/src/database_event_web.dart
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-part of firebase_database_web;
+part of '../firebase_database_web.dart';
 
 /// Web implementation for firebase [DataSnapshotPlatform]
 class DatabaseEventWeb extends DatabaseEventPlatform {
diff --git a/packages/firebase_database/firebase_database_web/lib/src/database_reference_web.dart b/packages/firebase_database/firebase_database_web/lib/src/database_reference_web.dart
@@ -2,17 +2,17 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-part of firebase_database_web;
+part of '../firebase_database_web.dart';
 
 /// Web implementation for firebase [DatabaseReferencePlatform]
 class DatabaseReferenceWeb extends QueryWeb
     implements DatabaseReferencePlatform {
   /// Builds an instance of [DatabaseReferenceWeb] delegating to a package:firebase [DatabaseReferencePlatform]
   /// to delegate queries to underlying firebase web plugin
   DatabaseReferenceWeb(
-    DatabasePlatform _database,
+    DatabasePlatform database,
     this._delegate,
-  ) : super(_database, _delegate);
+  ) : super(database, _delegate);
 
   final database_interop.DatabaseReference _delegate;
 
diff --git a/packages/firebase_database/firebase_database_web/lib/src/interop/data_snapshot_interop.dart b/packages/firebase_database/firebase_database_web/lib/src/interop/data_snapshot_interop.dart
@@ -2,7 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-part of firebase.database_interop;
+part of 'database_interop.dart';
 
 @JS('DataSnapshot')
 @staticInterop
diff --git a/packages/firebase_database/firebase_database_web/lib/src/interop/database.dart b/packages/firebase_database/firebase_database_web/lib/src/interop/database.dart
@@ -51,8 +51,7 @@ class Database
   static Database getInstance(database_interop.DatabaseJsImpl jsObject) =>
       _expando[jsObject] ??= Database._fromJsObject(jsObject);
 
-  Database._fromJsObject(database_interop.DatabaseJsImpl jsObject)
-      : super.fromJsObject(jsObject);
+  Database._fromJsObject(super.jsObject) : super.fromJsObject();
 
   /// Disconnects from the server, all database operations will be
   /// completed offline.
@@ -103,7 +102,7 @@ class DatabaseReference<T extends database_interop.ReferenceJsImpl>
   ) =>
       _expando[jsObject] ??= DatabaseReference._fromJsObject(jsObject);
 
-  DatabaseReference._fromJsObject(T jsObject) : super.fromJsObject(jsObject);
+  DatabaseReference._fromJsObject(super.jsObject) : super.fromJsObject();
 
   /// Returns child DatabaseReference from provided relative [path].
   DatabaseReference child(String path) => DatabaseReference.getInstance(
@@ -311,7 +310,7 @@ class Query<T extends database_interop.QueryJsImpl> extends JsObjectWrapper<T> {
       _onChildMoved(appName, hashCode);
 
   /// Creates a new Query from a [jsObject].
-  Query.fromJsObject(T jsObject) : super.fromJsObject(jsObject);
+  Query.fromJsObject(super.jsObject) : super.fromJsObject();
 
   /// Gets the most up-to-date result for this query.
   Future<DataSnapshot> get() async {
@@ -572,9 +571,7 @@ class TransactionResult
   ) =>
       _expando[jsObject] ??= TransactionResult._fromJsObject(jsObject);
 
-  TransactionResult._fromJsObject(
-      database_interop.TransactionResultJsImpl jsObject)
-      : super.fromJsObject(jsObject);
+  TransactionResult._fromJsObject(super.jsObject) : super.fromJsObject();
 
   bool get committed => jsObject.committed.toDart;
 
@@ -602,8 +599,7 @@ class DataSnapshot
   ) =>
       _expando[jsObject] ??= DataSnapshot._fromJsObject(jsObject);
 
-  DataSnapshot._fromJsObject(database_interop.DataSnapshotJsImpl jsObject)
-      : super.fromJsObject(jsObject);
+  DataSnapshot._fromJsObject(super.jsObject) : super.fromJsObject();
 
   /// Returns DataSnapshot for the location at the specified relative [path].
   DataSnapshot child(String path) =>
@@ -645,8 +641,7 @@ class DataSnapshot
 /// See: <https://firebase.google.com/docs/reference/js/firebase.database.OnDisconnect>.
 class OnDisconnect
     extends JsObjectWrapper<database_interop.OnDisconnectJsImpl> {
-  OnDisconnect.fromJsObject(database_interop.OnDisconnectJsImpl jsObject)
-      : super.fromJsObject(jsObject);
+  OnDisconnect.fromJsObject(super.jsObject) : super.fromJsObject();
 
   /// Cancels all previously queued onDisconnect() events for actual location
   /// and all children.
@@ -691,8 +686,8 @@ class ThenableReference
 
   /// Creates a new ThenableReference from a [jsObject].
   ThenableReference.fromJsObject(
-    database_interop.ThenableReferenceJsImpl jsObject,
-  ) : super._fromJsObject(jsObject);
+    super.jsObject,
+  ) : super._fromJsObject();
 
   /// A Future property.
   Future<DatabaseReference> get future => _future;
@@ -717,6 +712,5 @@ class Transaction extends JsObjectWrapper<database_interop.TransactionJsImpl> {
       );
 
   /// Creates a new Transaction from a [jsObject].
-  Transaction.fromJsObject(database_interop.TransactionJsImpl jsObject)
-      : super.fromJsObject(jsObject);
+  Transaction.fromJsObject(super.jsObject) : super.fromJsObject();
 }
diff --git a/packages/firebase_database/firebase_database_web/lib/src/interop/database_interop.dart b/packages/firebase_database/firebase_database_web/lib/src/interop/database_interop.dart
@@ -6,7 +6,7 @@
 // ignore_for_file: public_member_api_docs
 
 @JS('firebase_database')
-library firebase.database_interop;
+library;
 
 import 'dart:js_interop';
 
diff --git a/packages/firebase_database/firebase_database_web/lib/src/interop/query_interop.dart b/packages/firebase_database/firebase_database_web/lib/src/interop/query_interop.dart
@@ -2,7 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-part of firebase.database_interop;
+part of 'database_interop.dart';
 
 @JS('Query')
 @staticInterop
diff --git a/packages/firebase_database/firebase_database_web/lib/src/interop/reference_interop.dart b/packages/firebase_database/firebase_database_web/lib/src/interop/reference_interop.dart
@@ -2,7 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-part of firebase.database_interop;
+part of 'database_interop.dart';
 
 @JS('TransactionResult')
 @staticInterop
diff --git a/packages/firebase_database/firebase_database_web/lib/src/ondisconnect_web.dart b/packages/firebase_database/firebase_database_web/lib/src/ondisconnect_web.dart
@@ -2,7 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-part of firebase_database_web;
+part of '../firebase_database_web.dart';
 
 /// Web implementation for firebase [OnDisconnectPlatform]
 class OnDisconnectWeb extends OnDisconnectPlatform {
diff --git a/packages/firebase_database/firebase_database_web/lib/src/query_web.dart b/packages/firebase_database/firebase_database_web/lib/src/query_web.dart
@@ -2,7 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-part of firebase_database_web;
+part of '../firebase_database_web.dart';
 
 /// An implementation of [QueryPlatform] which proxies calls to js objects
 class QueryWeb extends QueryPlatform {
@@ -105,8 +105,7 @@ class QueryWeb extends QueryPlatform {
         path,
         ...modifiers
             .toList()
-            .map((e) => const DeepCollectionEquality().hash(e))
-            .toList(),
+            .map((e) => const DeepCollectionEquality().hash(e)),
         eventType.index,
       ]);
     }
diff --git a/packages/firebase_database/firebase_database_web/lib/src/transaction_result_web.dart b/packages/firebase_database/firebase_database_web/lib/src/transaction_result_web.dart
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-part of firebase_database_web;
+part of '../firebase_database_web.dart';
 
 class TransactionResultWeb extends TransactionResultPlatform {
   TransactionResultWeb._(this._ref, this._delegate)
diff --git a/packages/firebase_database/firebase_database_web/lib/src/utils/exception.dart b/packages/firebase_database/firebase_database_web/lib/src/utils/exception.dart
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-part of firebase_database_web;
+part of '../../firebase_database_web.dart';
 
 // Cannot use `guardWebExceptions` since we are inferring the
 // exception type from the message.
diff --git a/packages/firebase_database/firebase_database_web/lib/src/utils/snapshot_utils.dart b/packages/firebase_database/firebase_database_web/lib/src/utils/snapshot_utils.dart
@@ -2,7 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-part of firebase_database_web;
+part of '../../firebase_database_web.dart';
 
 /// Builds [EventPlatform] instance form web event instance
 DatabaseEventPlatform webEventToPlatformEvent(
diff --git a/packages/firebase_database/firebase_database_web/pubspec.yaml b/packages/firebase_database/firebase_database_web/pubspec.yaml
@@ -21,7 +21,7 @@ dev_dependencies:
   firebase_core_platform_interface: ^5.1.0
   flutter_test:
     sdk: flutter
-  flutter_lints: ^1.0.0
+  flutter_lints: ^4.0.0
 
 
 flutter:
diff --git a/packages/firebase_ml_model_downloader/firebase_ml_model_downloader/example/lib/main.dart b/packages/firebase_ml_model_downloader/firebase_ml_model_downloader/example/lib/main.dart
@@ -2,8 +2,8 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'package:firebase_ml_model_downloader/firebase_ml_model_downloader.dart';
 import 'package:firebase_core/firebase_core.dart';
+import 'package:firebase_ml_model_downloader/firebase_ml_model_downloader.dart';
 import 'package:flutter/material.dart';
 
 import 'firebase_options.dart';
@@ -19,7 +19,7 @@ void main() async {
 }
 
 class MyApp extends StatefulWidget {
-  const MyApp({Key? key}) : super(key: key);
+  const MyApp({super.key});
 
   @override
   State<MyApp> createState() => _MyAppState();
@@ -36,11 +36,11 @@ class _MyAppState extends State<MyApp> {
 
   /// Initially get the lcoal model if found, and asynchronously get the latest one in background.
   initWithLocalModel() async {
-    final _model = await FirebaseModelDownloader.instance.getModel(
+    final newModel = await FirebaseModelDownloader.instance.getModel(
         kModelName, FirebaseModelDownloadType.localModelUpdateInBackground);
 
     setState(() {
-      model = _model;
+      model = newModel;
     });
   }
 
@@ -82,12 +82,13 @@ class _MyAppState extends State<MyApp> {
                     Expanded(
                       child: ElevatedButton(
                         onPressed: () async {
-                          final _model = await FirebaseModelDownloader.instance
-                              .getModel(kModelName,
+                          final newModel =
+                              await FirebaseModelDownloader.instance.getModel(
+                                  kModelName,
                                   FirebaseModelDownloadType.latestModel);
 
                           setState(() {
-                            model = _model;
+                            model = newModel;
                           });
                         },
                         child: const Text('Get latest model'),
diff --git a/packages/firebase_ml_model_downloader/firebase_ml_model_downloader/example/pubspec.yaml b/packages/firebase_ml_model_downloader/firebase_ml_model_downloader/example/pubspec.yaml
diff --git a/packages/firebase_vertexai/firebase_vertexai/example/pubspec.yaml b/packages/firebase_vertexai/firebase_vertexai/example/pubspec.yaml
diff --git a/packages/firebase_vertexai/firebase_vertexai/pubspec.yaml b/packages/firebase_vertexai/firebase_vertexai/pubspec.yaml

Original file line number	Diff line number	Diff line change
`@@ -27,9 +27,7 @@ class Installations`
`27`	`27`	`return _expando[jsObject] ??= Installations._fromJsObject(jsObject);`
`28`	`28`	`}`
`29`	`29`
`30`		`- Installations._fromJsObject(`
`31`		`- installations_interop.InstallationsJsImpl jsObject)`
`32`		`- : super.fromJsObject(jsObject);`
	`30`	`+ Installations._fromJsObject(super.jsObject) : super.fromJsObject();`
`33`	`31`
`34`	`32`	`Future<void> delete() =>`
`35`	`33`	`(installations_interop.deleteInstallations(jsObject)).toDart;`