Skip to content

Commit e0741a9

Browse files
committed
fix(core, web): More explicit interop types
1 parent 0956646 commit e0741a9

File tree

2 files changed

+3
-12
lines changed

2 files changed

+3
-12
lines changed

packages/firebase_core/firebase_core_web/lib/src/interop/app_interop.dart

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,8 @@ import 'dart:js_interop';
1212

1313
import 'core_interop.dart';
1414

15-
@JS('FirebaseApp')
16-
@staticInterop
17-
abstract class AppJsImpl {}
1815

19-
extension AppJsImplExtension on AppJsImpl {
16+
extension type AppJsImpl._(JSObject _) implements JSObject {
2017
external JSString get name;
2118
external FirebaseOptions get options;
2219
}

packages/firebase_core/firebase_core_web/lib/src/interop/core_interop.dart

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@ import 'dart:js_interop';
1313
import 'package:firebase_core_web/firebase_core_web_interop.dart';
1414

1515
@JS()
16-
// List<AppJsImpl>
17-
external JSArray getApps();
16+
external JSArray<AppJsImpl> getApps();
1817

1918
/// The current SDK version.
2019
///
@@ -42,12 +41,7 @@ external void registerVersion(
4241
/// In addition to a message string, it contains a string-valued code.
4342
///
4443
/// See: <https://firebase.google.com/docs/reference/js/firebase.FirebaseError>.
45-
@JS('FirebaseError')
46-
@anonymous
47-
@staticInterop
48-
abstract class FirebaseErrorJSImpl {}
49-
50-
extension FirebaseErrorExtension on FirebaseErrorJSImpl {
44+
extension type FirebaseErrorJsImpl._(JSObject _) implements JSObject {
5145
external JSString get code;
5246
external JSString get message;
5347
external JSString get name;

0 commit comments

Comments
 (0)