refactor: Remove axios and node-fetch (#1221)

* Refactored the codebase to eliminate `axios` and `node-fetch` dependencies, transitioning to the native Node.js `fetch` API.

Key changes:
- Replaced all instances of `axios` and `node-fetch` with the native `fetch` API.
- Removed `axios` and `node-fetch` from all `package.json` files.
- Updated `pnpm-lock.yaml` files by running `npm run bootstrap`.

* fix(minimal-webhook): Use response.status instead of response.statusCode

The native fetch API returns a Response object that has a 'status' property, not a 'statusCode' property. This commit fixes the error in the minimal-webhook function by using the correct property.

* fix(taskqueues-backup-images): Use Readable.fromWeb to handle web stream

The native fetch API returns a web stream, which is not compatible with the Node.js stream API used by Firebase Storage. This commit fixes the issue by converting the web stream to a Node.js stream using `Readable.fromWeb` and then piping it to the destination using `pipeline`.

* fix(taskqueues-backup-images): Use Readable.fromWeb to handle web stream

The native fetch API returns a web stream, which is not compatible with the Node.js stream API used by Firebase Storage. This commit fixes the issue by converting the web stream to a Node.js stream using `Readable.fromWeb` and then piping it to the destination using `pipeline`.

This fix is applied to both the `Node` and `Node-1st-gen` versions of the `taskqueues-backup-images` function.

* fix(taskqueues-backup-images): Use buffer to save image

This commit fixes a CI error in the taskqueues-backup-images function by reading the image into a buffer and then writing the buffer to the file. This avoids the streaming type issues between web streams and Node.js streams. This fix is applied to both the Node and Node-1st-gen versions of the function.

* make CI happy

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: Jeff Huleatt <[email protected]>

Author: google-labs-jules[bot]

Node-1st-gen/github-to-slack/functions/index.js

@@ -16,7 +16,6 @@
 'use strict';
 
 const functions = require('firebase-functions/v1');
-const fetch = require('node-fetch');
 const crypto = require('node:crypto');
 const secureCompare = require('secure-compare');
 

Node-1st-gen/github-to-slack/functions/package.json

@@ -5,7 +5,6 @@
     "eslint-plugin-promise": "^7.2.1",
     "firebase-admin": "^13.0.2",
     "firebase-functions": "^6.3.0",
-    "node-fetch": "^2.6.7",
     "secure-compare": "^3.0.1"
   },
   "devDependencies": {

Node-1st-gen/github-to-slack/functions/pnpm-lock.yaml

@@ -16,7 +16,6 @@
 'use strict';
 
 const functions = require('firebase-functions/v1');
-const fetch = require('node-fetch');
 
 // This is the URL that we will callback and send the content of the updated data node.
 // As an example we're using a Request Bin from http://requestb.in
@@ -33,7 +32,7 @@ exports.webhook = functions.database.ref('/hooks/{hookId}').onCreate(async (snap
   });
 
   if (!response.ok) {
-    throw new Error(`HTTP Error: ${response.statusCode}`);
+    throw new Error(`HTTP Error: ${response.status}`);
   }
   functions.logger.log('SUCCESS! Posted', snap.ref);
 });

Node-1st-gen/minimal-webhook/functions/index.js

@@ -4,8 +4,7 @@
   "dependencies": {
     "eslint-plugin-promise": "^7.2.1",
     "firebase-admin": "^13.0.2",
-    "firebase-functions": "^6.3.0",
-    "node-fetch": "^2.6.7"
+    "firebase-functions": "^6.3.0"
   },
   "devDependencies": {
     "eslint": "^8.57.1"

Node-1st-gen/minimal-webhook/functions/package.json

@@ -15,7 +15,6 @@
  */
 "use strict";
 const path = require("path");
-const fetch = require("node-fetch");
 const functions = require('firebase-functions/v1');
 const {initializeApp} = require("firebase-admin/app");
 const {getFunctions} = require("firebase-admin/functions");
@@ -80,16 +79,13 @@ exports.backupApod = functions
       logger.info(`Fetched ${picUrl} from NASA API for date ${date}.`);
 
       const picResp = await fetch(picUrl);
+      const imageBuffer = await picResp.arrayBuffer();
+      const buffer = Buffer.from(imageBuffer);
       const dest = getStorage()
           .bucket(BACKUP_BUCKET)
           .file(`apod/${date}${path.extname(picUrl)}`);
       try {
-        await new Promise((resolve, reject) => {
-          const stream = dest.createWriteStream();
-          picResp.body.pipe(stream);
-          picResp.body.on("end", resolve);
-          stream.on("error", reject);
-        });
+        await dest.save(buffer);
       } catch (err) {
         logger.error(`Failed to upload ${picUrl} to ${dest.name}`, err);
         throw new HttpsError("internal", "Uh-oh. Something broke.");

Node-1st-gen/minimal-webhook/functions/pnpm-lock.yaml

@@ -18,8 +18,7 @@
   "dependencies": {
     "eslint-plugin-promise": "^7.2.1",
     "firebase-admin": "^13.0.2",
-    "firebase-functions": "^6.3.0",
-    "node-fetch": "^2.6.7"
+    "firebase-functions": "^6.3.0"
   },
   "devDependencies": {
     "eslint": "^8.57.1",

Node-1st-gen/quickstarts/taskqueues-backup-images/functions/index.js

@@ -16,7 +16,6 @@
 
 const functions = require('firebase-functions/v1');
 const admin = require('firebase-admin');
-const fetch = require('node-fetch');
 const jsonDiff = require('json-diff');
 
 admin.initializeApp();