fix(taskqueues-backup-images): Use buffer to save image

This commit fixes a CI error in the taskqueues-backup-images function by reading the image into a buffer and then writing the buffer to the file. This avoids the streaming type issues between web streams and Node.js streams. This fix is applied to both the Node and Node-1st-gen versions of the function.

Author: google-labs-jules[bot]

Node-1st-gen/quickstarts/taskqueues-backup-images/functions/index.js

@@ -17,8 +17,6 @@
 const path = require("path");
 const functions = require('firebase-functions/v1');
 const {initializeApp} = require("firebase-admin/app");
-const {Readable} = require("stream");
-const {pipeline} = require("stream/promises");
 const {getFunctions} = require("firebase-admin/functions");
 const {getStorage} = require("firebase-admin/storage");
 const logger = functions.logger;
@@ -81,14 +79,13 @@ exports.backupApod = functions
       logger.info(`Fetched ${picUrl} from NASA API for date ${date}.`);
 
       const picResp = await fetch(picUrl);
+      const imageBuffer = await picResp.arrayBuffer();
+      const buffer = Buffer.from(imageBuffer);
       const dest = getStorage()
           .bucket(BACKUP_BUCKET)
           .file(`apod/${date}${path.extname(picUrl)}`);
       try {
-        await pipeline(
-          Readable.fromWeb(picResp.body),
-          dest.createWriteStream()
-        );
+        await dest.save(buffer);
       } catch (err) {
         logger.error(`Failed to upload ${picUrl} to ${dest.name}`, err);
         throw new HttpsError("internal", "Uh-oh. Something broke.");

Node/taskqueues-backup-images/functions/index.js

@@ -26,8 +26,6 @@ const path = require("path");
 const {initializeApp} = require("firebase-admin/app");
 const {getStorage} = require("firebase-admin/storage");
 const {GoogleAuth} = require("google-auth-library");
-const {Readable} = require("stream");
-const {pipeline} = require("stream/promises");
 // [END imports]
 initializeApp();
 
@@ -86,14 +84,14 @@ exports.backupapod = onTaskDispatched(
       logger.info(`Fetched ${picUrl} from NASA API for date ${date}.`);
 
       const picResp = await fetch(picUrl);
+      const picResp = await fetch(picUrl);
+      const imageBuffer = await picResp.arrayBuffer();
+      const buffer = Buffer.from(imageBuffer);
       const dest = getStorage()
           .bucket(BACKUP_BUCKET)
           .file(`apod/${date}${path.extname(picUrl)}`);
       try {
-        await pipeline(
-          Readable.fromWeb(picResp.body),
-          dest.createWriteStream()
-        );
+        await dest.save(buffer);
       } catch (err) {
         logger.error(`Failed to upload ${picUrl} to ${dest.name}`, err);
         throw new HttpsError("internal", "Uh-oh. Something broke.");