Skip to content

Commit cc94963

Browse files
committed
address comments
1 parent eb0a839 commit cc94963

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

2nd-gen/uppercase/README.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,28 @@
11
# Firebase SDK for Cloud Functions 2nd Gen Quickstart - Realtime Database
22

3-
This quickstart demonstrates using **Firebase SDK for Cloud Functions** setup with a **Firebase database**.
3+
This quickstart demonstrates using **Firebase SDK for Cloud Functions** with **Firebase Realtime Database**.
44

55

66
## Introduction
77

88
This sample app does two things:
9-
- Create messages in the Firebase Realtime Database using a simple HTTPS request which is handled by a v2 HTTPS Firebase Function. Writing to the Realtime Database is done using the Firebase Admin SDK.
10-
- When a message gets added in the Realtime Database, a v2 Firebase Function triggers and automatically makes these messages all uppercase.
9+
- Create messages in the Firebase Realtime Database using a simple HTTPS request which is handled by a v2 HTTPS function. Writing to the Realtime Database is done using the Firebase Admin SDK.
10+
- When a message gets added in the Realtime Database, a v2 function triggers and automatically makes these messages all uppercase.
1111

1212
## Deploy and try out
1313

1414
To deploy and try out the sample:
1515

16-
- Create a Firebase project on the [Firebase Console](https://console.firebase.google.com)
16+
- Create a Firebase project using the [Firebase console](https://console.firebase.google.com)
1717
- Install the required dependencies by running `npm install` in the `functions` directory
1818
- Deploy your project's code using `firebase deploy`
19-
- Create a message by opening the querying the functions url from your browser.
19+
- Create a message by opening the querying the functions URL from your browser.
2020

21-
The function executes and redirects the browser to the Firebase console at the database location where the text string was stored. You should see your text value displayed in the console and uppercase.
21+
The function executes and redirects the browser to the Firebase console at the database location where the text string was stored. You should see your text value displayed in the console and in uppercase.
2222

2323
## Contributing
2424

25-
We'd love that you contribute to the project. Before doing so please read our [Contributor guide](../../CONTRIBUTING.md).
25+
We'd love you to contribute to the project. Before doing so please read our [Contributor guide](../../CONTRIBUTING.md).
2626

2727

2828
## License

2nd-gen/uppercase/functions/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ exports.makeuppercase = onValueCreated('/messages/{pushId}/original', (event) =>
5353
const original = event.data.val();
5454
logger.log('Uppercasing', event.params.pushId, original);
5555
const uppercase = original.toUpperCase();
56-
// You must return a Promise when performing asynchronous tasks inside a Functions such as
56+
// You must return a Promise when performing asynchronous tasks inside a function, such as
5757
// writing to the Firebase Realtime Database.
5858
// Setting an "uppercase" sibling in the Realtime Database returns a Promise.
5959
return event.data.ref.parent.child('uppercase').set(uppercase);

0 commit comments

Comments
 (0)