feat(genkit-tools/mcp): MCP fix for Antigravity #4027
Conversation
Summary of ChangesHello @ssbushi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the robustness and compatibility of Genkit tools, particularly within the Antigravity environment. It introduces a more centralized and context-aware approach to managing the Genkit runtime, ensuring that tools operate correctly by explicitly handling project root paths and adapting their behavior based on the execution environment. This also includes hiding certain runtime tools in Antigravity to prevent known issues, streamlining the user experience. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a workaround for the Antigravity environment by allowing projectRoot to be passed with tool calls. This is achieved by updating tool schemas and handlers to accept projectRoot. A significant part of this change is the refactoring of McpRuntimeManager into a static class that acts as a singleton, managing a single runtime manager instance at a time. The changes look good and address the stated goal. I've added a few comments regarding code cleanup, type safety, and architectural considerations for the McpRuntimeManager refactoring.
ssbushi
changed the title
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces support for the Antigravity IDE environment within the MCP server, which is a significant feature enhancement. The changes are well-implemented, including new CLI options for IDE and timeout, and a thoughtful refactoring of tool definitions to handle projectRoot dynamically. The introduction of mcp/utils.ts to centralize common logic is a great improvement for maintainability. The McpRuntimeManager has also been nicely updated to manage runtimes on a per-project basis. Overall, this is a solid contribution. I have one suggestion to fully align the implementation with the goal of hiding runtime tools in the Antigravity environment, as mentioned in the PR description.
1 participant
Checklist (if applicable):