Skip to content

Commit 1bfc678

Browse files
author
Cristian Avalos
committed
fixes indentation and removes unnecessary throw
1 parent f1be231 commit 1bfc678

File tree

2 files changed

+43
-46
lines changed

2 files changed

+43
-46
lines changed

dynamiclinks/app/src/main/java/com/google/firebase/quickstart/deeplinks/java/MainActivity.java

Lines changed: 35 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -75,12 +75,12 @@ public void onClick(View v) {
7575
});
7676

7777
binding.buttonShareShortLink.setOnClickListener(new View.OnClickListener() {
78-
@Override
79-
public void onClick(View v) {
80-
TextView shortLinkTextView = findViewById(R.id.shortLinkViewSend);
81-
String shortDynamicLink = shortLinkTextView.getText().toString();
82-
shareDeepLink(shortDynamicLink);
83-
}
78+
@Override
79+
public void onClick(View v) {
80+
TextView shortLinkTextView = findViewById(R.id.shortLinkViewSend);
81+
String shortDynamicLink = shortLinkTextView.getText().toString();
82+
shareDeepLink(shortDynamicLink);
83+
}
8484
});
8585
// [END_EXCLUDE]
8686

@@ -184,36 +184,34 @@ private void validateAppCode() {
184184

185185
@VisibleForTesting
186186
public void buildShortLinkFromParams(@NonNull Uri deepLink, int minVersion) {
187-
String uriPrefix = getString(R.string.dynamic_links_uri_prefix);
188-
189-
// Set dynamic link parameters:
190-
// * URI prefix (required)
191-
// * Android Parameters (required)
192-
// * Deep link
193-
FirebaseDynamicLinks.getInstance()
194-
.createDynamicLink()
195-
.setDomainUriPrefix(uriPrefix)
196-
.setAndroidParameters(
197-
new AndroidParameters.Builder()
198-
.setMinimumVersion(minVersion)
199-
.build()
200-
)
201-
.setLink(deepLink)
202-
.buildShortDynamicLink()
203-
.addOnCompleteListener(this, new OnCompleteListener<ShortDynamicLink>() {
204-
@Override
205-
public void onComplete(@NonNull Task<ShortDynamicLink> task) {
206-
if (task.isSuccessful()) {
207-
// Short link created
208-
Uri shortDynamicLink = task.getResult().getShortLink();
209-
TextView shortLinkTextView = findViewById(R.id.shortLinkViewSend);
210-
shortLinkTextView.setText(shortDynamicLink.toString());
211-
} else {
212-
// Error
213-
Log.e(TAG, task.getException().getMessage());
214-
throw new Error(task.getException().getMessage());
215-
}
216-
}
217-
});
187+
String uriPrefix = getString(R.string.dynamic_links_uri_prefix);
188+
189+
// Set dynamic link parameters:
190+
// * URI prefix (required)
191+
// * Android Parameters (required)
192+
// * Deep link
193+
FirebaseDynamicLinks.getInstance()
194+
.createDynamicLink()
195+
.setDomainUriPrefix(uriPrefix)
196+
.setAndroidParameters(
197+
new AndroidParameters.Builder()
198+
.setMinimumVersion(minVersion)
199+
.build())
200+
.setLink(deepLink)
201+
.buildShortDynamicLink()
202+
.addOnCompleteListener(this, new OnCompleteListener<ShortDynamicLink>() {
203+
@Override
204+
public void onComplete(@NonNull Task<ShortDynamicLink> task) {
205+
if (task.isSuccessful()) {
206+
// Short link created
207+
Uri shortDynamicLink = task.getResult().getShortLink();
208+
TextView shortLinkTextView = findViewById(R.id.shortLinkViewSend);
209+
shortLinkTextView.setText(shortDynamicLink.toString());
210+
} else {
211+
// Error
212+
Log.e(TAG, task.getException().getMessage());
213+
}
214+
}
215+
});
218216
}
219217
}

dynamiclinks/app/src/main/java/com/google/firebase/quickstart/deeplinks/kotlin/MainActivity.kt

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -127,17 +127,16 @@ class MainActivity : AppCompatActivity() {
127127
// * Android Parameters (required)
128128
// * Deep link
129129
Firebase.dynamicLinks.shortLinkAsync {
130-
link = deepLink
131-
domainUriPrefix = uriPrefix
132-
androidParameters {
133-
minimumVersion = minVersion
134-
}
130+
link = deepLink
131+
domainUriPrefix = uriPrefix
132+
androidParameters {
133+
minimumVersion = minVersion
134+
}
135135
}.addOnSuccessListener { (shortLink, flowchartLink) ->
136-
val shortLinkTextView = findViewById<TextView>(R.id.shortLinkViewSend);
137-
shortLinkTextView.text = shortLink.toString();
136+
val shortLinkTextView = findViewById<TextView>(R.id.shortLinkViewSend);
137+
shortLinkTextView.text = shortLink.toString();
138138
}.addOnFailureListener(this) { e ->
139-
Log.e(TAG, e.toString());
140-
throw java.lang.Error(e.toString());
139+
Log.e(TAG, e.toString());
141140
}
142141
}
143142

0 commit comments

Comments
 (0)