refactor: ensure a user is logged in before marking as favorite

Author: thatfiredev

dataconnect/app/src/main/java/com/google/firebase/example/dataconnect/feature/actordetail/ActorDetailViewModel.kt

@@ -63,13 +63,15 @@ class ActorDetailViewModel(
     }
 
     fun toggleFavorite(newValue: Boolean) {
+        // TODO(thatfiredev): hide the button if there's no user logged in
+        val uid = firebaseAuth.currentUser?.uid ?: return
         viewModelScope.launch {
             try {
                 if (newValue) {
                     moviesConnector.addFavoritedActor.execute(UUID.fromString(actorId))
                 } else {
                     moviesConnector.deleteFavoriteActor.execute(
-                        userId = firebaseAuth.currentUser?.uid ?: "",
+                        userId = uid,
                         actorId = UUID.fromString(actorId)
                     )
                 }

dataconnect/app/src/main/java/com/google/firebase/example/dataconnect/feature/moviedetail/MovieDetailViewModel.kt

@@ -69,6 +69,8 @@ class MovieDetailViewModel(
     }
 
     fun toggleFavorite(newValue: Boolean) {
+        // TODO(thatfiredev): hide the button if there's no user logged in
+        val uid = firebaseAuth.currentUser?.uid ?: return
         viewModelScope.launch {
             try {
                 if (newValue) {
@@ -77,7 +79,7 @@ class MovieDetailViewModel(
                     // TODO(thatfiredev): investigate whether this is a schema error
                     //    userId probably shouldn't be here.
                     moviesConnector.deleteFavoritedMovie.execute(
-                        userId = firebaseAuth.currentUser?.uid ?: "",
+                        userId = uid,
                         movieId = UUID.fromString(movieId)
                     )
                 }
@@ -90,6 +92,8 @@ class MovieDetailViewModel(
     }
 
     fun toggleWatched(newValue: Boolean) {
+        // TODO(thatfiredev): hide the button if there's no user logged in
+        val uid = firebaseAuth.currentUser?.uid ?: return
         viewModelScope.launch {
             try {
                 if (newValue) {
@@ -98,7 +102,7 @@ class MovieDetailViewModel(
                     // TODO(thatfiredev): investigate whether this is a schema error
                     //    userId probably shouldn't be here.
                     moviesConnector.deleteWatchedMovie.execute(
-                        userId = firebaseAuth.currentUser?.uid ?: "",
+                        userId = uid,
                         movieId = UUID.fromString(movieId)
                     )
                 }
@@ -111,6 +115,8 @@ class MovieDetailViewModel(
     }
 
     fun addRating(rating: Float, text: String) {
+        // TODO(thatfiredev): hide the button if there's no user logged in
+        if (firebaseAuth.currentUser?.uid == null) return
         viewModelScope.launch {
             try {
                 moviesConnector.addReview.execute(

dataconnect/app/src/main/java/com/google/firebase/example/dataconnect/feature/moviedetail/UserReviews.kt

@@ -63,8 +63,10 @@ fun UserReviews(
 
         Button(
             onClick = {
-                onReviewSubmitted(rating, reviewText)
-                reviewText = ""
+                if (!reviewText.isNullOrEmpty()) {
+                    onReviewSubmitted(rating, reviewText)
+                    reviewText = ""
+                }
             }
         ) {
             Text(stringResource(R.string.button_submit_review))