Integrate Latest @ 198905712

Changes to admob/testapp ...
- Unpinned sample Cocoapod versions and updated documentation to remove pinning comments.
Changes to analytics/testapp ...
- Unpinned sample Cocoapod versions and updated documentation to remove pinning comments.
Changes to auth/testapp ...
- Fix various error handling issues in Auth
- Unpinned sample Cocoapod versions and updated documentation to remove pinning comments.
Changes to database/testapp ...
- Unpinned sample Cocoapod versions and updated documentation to remove pinning comments.
Changes to dynamic_links/testapp ...
- Unpinned sample Cocoapod versions and updated documentation to remove pinning comments.
Changes to invites/testapp ...
- Unpinned sample Cocoapod versions and updated documentation to remove pinning comments.
Changes to messaging/testapp ...
- Unpinned sample Cocoapod versions and updated documentation to remove pinning comments.
- Added RequestPermission example in in Messaging testapp and fixed typo.
Changes to remote_config/testapp ...
- Unpinned sample Cocoapod versions and updated documentation to remove pinning comments.
Changes to storage/testapp ...
- Unpinned sample Cocoapod versions and updated documentation to remove pinning comments.
- Change the Storage testapp to resume only after the pause has completed.

CL: 198905712

Author: a-maurice

admob/testapp/Podfile

@@ -2,6 +2,6 @@ source 'https://github.com/CocoaPods/Specs.git'
 platform :ios, '7.0'
 # AdMob test application.
 target 'testapp' do
-  pod 'Firebase/Core', '4.13.0'
-  pod 'Firebase/AdMob', '4.13.0'
+  pod 'Firebase/Core'
+  pod 'Firebase/AdMob'
 end

analytics/testapp/Podfile

@@ -2,6 +2,6 @@ source 'https://github.com/CocoaPods/Specs.git'
 platform :ios, '8.0'
 # Analytics test application.
 target 'testapp' do
-  pod 'Firebase/Core', '4.13.0'
-  pod 'Firebase/Analytics', '4.13.0'
+  pod 'Firebase/Core'
+  pod 'Firebase/Analytics'
 end

auth/testapp/Podfile

@@ -2,6 +2,6 @@ source 'https://github.com/CocoaPods/Specs.git'
 platform :ios, '8.0'
 # Auth test application.
 target 'testapp' do
-  pod 'Firebase/Core', '4.13.0'
-  pod 'Firebase/Auth', '4.13.0'
+  pod 'Firebase/Core'
+  pod 'Firebase/Auth'
 end

auth/testapp/src/common_main.cc

@@ -514,7 +514,8 @@ extern "C" int common_main(int argc, const char* argv[]) {
       wait_ms += kWaitIntervalMs;
       LogMessage(".");
     }
-    if (wait_ms > kPhoneAuthCodeSendWaitMs) {
+    if (wait_ms > kPhoneAuthCodeSendWaitMs ||
+        listener.num_calls_on_verification_failed()) {
       LogMessage("ERROR: SMS with verification code not sent.");
     } else {
       LogMessage("SMS verification code sent.");
@@ -743,7 +744,7 @@ extern "C" int common_main(int argc, const char* argv[]) {
         Future<User*> oauth_bad = auth->SignInWithCredential(oauth_cred_bad);
         WaitForSignInFuture(
             oauth_bad, "Auth::SignInWithCredential() bad OAuth credentials",
-            ::firebase::auth::kAuthErrorNoSuchProvider, auth);
+            ::firebase::auth::kAuthErrorFailure, auth);
       }
 
       // Test Auth::SendPasswordResetEmail().

database/testapp/Podfile

@@ -2,7 +2,7 @@ source 'https://github.com/CocoaPods/Specs.git'
 platform :ios, '8.0'
 # Firebase Realtime Database test application.
 target 'testapp' do
-  pod 'Firebase/Core', '4.13.0'
-  pod 'Firebase/Database', '4.13.0'
-  pod 'Firebase/Auth', '4.13.0'
+  pod 'Firebase/Core'
+  pod 'Firebase/Database'
+  pod 'Firebase/Auth'
 end

dynamic_links/testapp/Podfile

@@ -2,6 +2,6 @@ source 'https://github.com/CocoaPods/Specs.git'
 platform :ios, '8.0'
 # Dynamic Links test application.
 target 'testapp' do
-  pod 'Firebase/Core', '4.13.0'
-  pod 'Firebase/DynamicLinks', '4.13.0'
+  pod 'Firebase/Core'
+  pod 'Firebase/DynamicLinks'
 end

invites/testapp/Podfile

@@ -2,6 +2,6 @@ source 'https://github.com/CocoaPods/Specs.git'
 platform :ios, '8.0'
 # Invites test application.
 target 'testapp' do
-  pod 'Firebase/Core', '4.13.0'
-  pod 'Firebase/Invites', '4.13.0'
+  pod 'Firebase/Core'
+  pod 'Firebase/Invites'
 end

messaging/testapp/Podfile

@@ -2,6 +2,6 @@ source 'https://github.com/CocoaPods/Specs.git'
 platform :ios, '8.0'
 # FCM test application.
 target 'testapp' do
-  pod 'Firebase/Core', '4.13.0'
-  pod 'Firebase/Messaging', '4.13.0'
+  pod 'Firebase/Core'
+  pod 'Firebase/Messaging'
 end

messaging/testapp/src/common_main.cc

@@ -40,7 +40,14 @@ extern "C" int common_main(int argc, const char* argv[]) {
         LogMessage("Try to initialize Firebase Messaging");
         ::firebase::messaging::PollableListener* listener =
             static_cast<::firebase::messaging::PollableListener*>(userdata);
-        return ::firebase::messaging::Initialize(*app, listener);
+        firebase::messaging::MessagingOptions options;
+        // Prevent the app from requesting permission to show notifications
+        // immediately upon starting up. Since it the prompt is being
+        // suppressed, we must manually display it with a call to
+        // RequestPermission() elsewhere.
+        options.suppress_notification_permission_prompt = true;
+
+        return ::firebase::messaging::Initialize(*app, listener, options);
       });
 
   while (initializer.InitializeLastResult().status() !=
@@ -56,19 +63,35 @@ extern "C" int common_main(int argc, const char* argv[]) {
 
   LogMessage("Initialized Firebase Cloud Messaging.");
 
+  // This will display the prompt to request permission to receive notifications
+  // if the prompt has not already been displayed before. (If the user already
+  // responded to the prompt, their decision is cached by the OS and can be
+  // changed in the OS settings).
+  ::firebase::Future<void> result = ::firebase::messaging::RequestPermission();
+  LogMessage("Display permission prompt if necessary.");
+  while (result.status() == ::firebase::kFutureStatusPending) {
+    ProcessEvents(100);
+  }
+  if (result.error() ==
+      ::firebase::messaging::kErrorFailedToRegisterForRemoteNotifications) {
+    LogMessage("Error registering for remote notifications.");
+  } else {
+    LogMessage("Finished checking for permission.");
+  }
+
   ::firebase::messaging::Subscribe("TestTopic");
   LogMessage("Subscribed to TestTopic");
 
   bool done = false;
   while (!done) {
     std::string token;
     if (listener.PollRegistrationToken(&token)) {
-      LogMessage("Recieved Registration Token: %s", token.c_str());
+      LogMessage("Received Registration Token: %s", token.c_str());
     }
 
     ::firebase::messaging::Message message;
     while (listener.PollMessage(&message)) {
-      LogMessage("Recieved a new message");
+      LogMessage("Received a new message");
       LogMessage("This message was %s by the user",
                  message.notification_opened ? "opened" : "not opened");
       if (!message.from.empty()) LogMessage("from: %s", message.from.c_str());

remote_config/testapp/Podfile

@@ -2,6 +2,6 @@ source 'https://github.com/CocoaPods/Specs.git'
 platform :ios, '8.0'
 # Firebase Remote Config test application.
 target 'testapp' do
-  pod 'Firebase/Core', '4.13.0'
-  pod 'Firebase/RemoteConfig', '4.13.0'
+  pod 'Firebase/Core'
+  pod 'Firebase/RemoteConfig'
 end