Skip to content

Conversation

@andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Dec 3, 2025

  • Silenced the Literal value is already handled by previous pattern; consider removing it warnings and added TODOs with context to resolve them in the future.
  • Reduced the deployment target to the lowest supported value (17.0 instead of 17.6).
  • Fixed a typo that had import ConversationKit within a #if canImport(FirebaseAILogic) but these are unrelated.
    • Will remove the #if canImport(FirebaseAILogic) statements in a follow-up since we depend on Firebase 12.6.0+ where FirebaseAILogic is always available.
  • Reverted unintentional copyright year changes on unmodified files in refactor: Modernize Project Structure and Refine Codebase #1812.

To be addressed in a follow-up PR:

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily addresses warnings and minor issues introduced in a previous PR. The changes include silencing compiler warnings about duplicate case patterns by commenting them out and adding TODOs for future resolution, reducing the iOS deployment target, fixing an import statement, and reverting incorrect copyright year updates. The changes are generally good and align with the PR's goal. I've found a minor copy-paste error in a commented-out code block which should be corrected for clarity.

@andrewheard andrewheard marked this pull request as ready for review December 3, 2025 17:16
Copy link
Contributor

@peterfriese peterfriese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching these, @andrewheard !

@andrewheard andrewheard merged commit 88d81ac into main Dec 3, 2025
7 checks passed
@andrewheard andrewheard deleted the ah/ai-qs-refactor-fixes branch December 3, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants