Skip to content

Commit 3ea80c1

Browse files
committed
Various fixes
1 parent 067fc36 commit 3ea80c1

File tree

3 files changed

+14
-9
lines changed

3 files changed

+14
-9
lines changed

dataconnect/README.md

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,8 @@ This repository contains the quickstart to help you explore the functionalities
8888
npm run build
8989
```
9090

91-
5. Set up Firebase Authentication with Google Sign-In. Optionally, allow domains for [Firebase Auth](https://firebase.google.com/docs/auth/web/hosting) in your project console (e.g., `http://127.0.0.1`).
92-
6. Allow domains for Firebase Auth in your [project console](https://console.firebase.google.com/project/_/authentication/settings) (e.g., `http://127.0.0.1`).
93-
7. In `dataconnect/dataconnect.yaml`, ensure that your `instanceId`, `database`, and `serviceId` match your project configuration:
91+
5. Allow domains for Firebase Auth in your [project console](https://console.firebase.google.com/project/_/authentication/settings) (e.g., `http://127.0.0.1`).
92+
6. In `dataconnect/dataconnect.yaml`, ensure that your `instanceId`, `database`, and `serviceId` match your project configuration:
9493

9594
```yaml
9695
specVersion: "v1alpha"
@@ -106,7 +105,7 @@ This repository contains the quickstart to help you explore the functionalities
106105
connectorDirs: ["./movie-connector"]
107106
```
108107

109-
8. Deploy your project:
108+
7. Deploy your project:
110109

111110
```bash
112111
npm install -g firebase-tools
@@ -115,13 +114,13 @@ This repository contains the quickstart to help you explore the functionalities
115114
firebase deploy --only dataconnect,hosting
116115
```
117116

118-
9. To compare schema changes, run:
117+
8. To compare schema changes, run:
119118

120119
```bash
121120
firebase dataconnect:sql:diff
122121
```
123122

124-
10. If the changes are acceptable, apply them with:
123+
9. If the changes are acceptable, apply them with:
125124

126125
```bash
127126
firebase dataconnect:sql:migrate

dataconnect/app/src/components/navbar.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import React, { useEffect, useState, useContext } from 'react';
2-
import { signInWithPopup, GoogleAuthProvider, signOut, User } from 'firebase/auth';
2+
import { signInWithRedirect, GoogleAuthProvider, signOut, User } from 'firebase/auth';
33
import { AuthContext } from '@/lib/firebase';
44
import { Link } from 'react-router-dom';
55
import { handleAuthStateChange } from '@/lib/MovieService';
@@ -18,7 +18,7 @@ export default function Navbar() {
1818

1919
async function handleSignIn() {
2020
const provider = new GoogleAuthProvider();
21-
await signInWithPopup(auth, provider);
21+
await signInWithRedirect(auth, provider);
2222
}
2323

2424
async function handleSignOut() {

dataconnect/app/src/pages/Home.tsx

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,13 @@ const ConditionalRender = ({ condition, preferred, alternate }: { condition: boo
88

99
const PlaceholderMessage = () => (
1010
<div className="min-h-screen flex items-center justify-center text-center text-4xl text-white">
11-
Run the Firebase Data Connect Extension to get started.
11+
<h1>To get Started with Firebase Data Connect:</h1>
12+
<ol>
13+
<li><a href="https://console.firebase.google.com/project/_/authentication/settings">Add {window.location.host} to your list of domains</a></li>
14+
<li>Open the Firebase Data Connect Extension</li>
15+
<li>Select your project</li>
16+
<li>Click "Start Emulators"</li>
17+
</ol>
1218
</div>
1319
)
1420

0 commit comments

Comments
 (0)