Skip to content

Commit 35d2acc

Browse files
committed
Update method name to match Credential Manager docs, merge Firebase sign out with clearing credential state
1 parent 67fc272 commit 35d2acc

File tree

2 files changed

+21
-15
lines changed

2 files changed

+21
-15
lines changed

auth/app/src/main/java/com/google/firebase/quickstart/auth/GoogleSignInActivity.java

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ private void launchCredentialManager() {
8888
// Instantiate a Google sign-in request
8989
GetGoogleIdOption googleIdOption = new GetGoogleIdOption.Builder()
9090
.setFilterByAuthorizedAccounts(true)
91-
.setServerClientId(getBaseContext().getString(R.string.default_web_client_id))
91+
.setServerClientId(getString(R.string.default_web_client_id))
9292
.build();
9393

9494
// Create the Credential Manager request
@@ -107,7 +107,7 @@ private void launchCredentialManager() {
107107
@Override
108108
public void onResult(GetCredentialResponse result) {
109109
// Extract credential from the result returned by Credential Manager
110-
createGoogleIdToken(result.getCredential());
110+
handleSignIn(result.getCredential());
111111
}
112112

113113
@Override
@@ -118,8 +118,8 @@ public void onError(GetCredentialException e) {
118118
);
119119
}
120120

121-
// [START create_google_id_token]
122-
private void createGoogleIdToken(Credential credential) {
121+
// [START handle_sign_in]
122+
private void handleSignIn(Credential credential) {
123123
// Check if credential is of type Google ID
124124
if (credential instanceof CustomCredential customCredential
125125
&& credential.getType().equals(TYPE_GOOGLE_ID_TOKEN_CREDENTIAL)) {
@@ -133,7 +133,7 @@ private void createGoogleIdToken(Credential credential) {
133133
Log.w(TAG, "Credential is not of type Google ID!");
134134
}
135135
}
136-
// [END create_google_id_token]
136+
// [END handle_sign_in]
137137

138138
// [START auth_with_google]
139139
private void firebaseAuthWithGoogle(String idToken) {
@@ -154,8 +154,11 @@ private void firebaseAuthWithGoogle(String idToken) {
154154
}
155155
// [END auth_with_google]
156156

157-
// [START clear_credential_stage]
158-
private void clearCredentialState() {
157+
// [START sign_out]
158+
private void signOut() {
159+
// Firebase sign out
160+
mAuth.signOut();
161+
159162
// When a user signs out, clear the current user credential state from all credential providers.
160163
ClearCredentialStateRequest clearRequest = new ClearCredentialStateRequest();
161164
credentialManager.clearCredentialStateAsync(
@@ -174,7 +177,7 @@ public void onError(@NonNull ClearCredentialException e) {
174177
}
175178
});
176179
}
177-
// [END clear_credential_stage]
180+
// [END sign_out]
178181

179182
private void updateUI(FirebaseUser user) {
180183

auth/app/src/main/java/com/google/firebase/quickstart/auth/kotlin/GoogleSignInActivity.kt

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -86,15 +86,15 @@ class GoogleSignInActivity : AppCompatActivity() {
8686
)
8787

8888
// Extract credential from the result returned by Credential Manager
89-
createGoogleIdToken(result.credential)
89+
handleSignIn(result.credential)
9090
} catch (e: GetCredentialException) {
9191
Log.e(TAG, "Couldn't retrieve user's credentials: ${e.localizedMessage}")
9292
}
9393
}
9494
}
9595

96-
// [START create_google_id_token]
97-
private fun createGoogleIdToken(credential: Credential) {
96+
// [START handle_sign_in]
97+
private fun handleSignIn(credential: Credential) {
9898
// Check if credential is of type Google ID
9999
if (credential is CustomCredential && credential.type == TYPE_GOOGLE_ID_TOKEN_CREDENTIAL) {
100100
// Create Google ID Token
@@ -106,7 +106,7 @@ class GoogleSignInActivity : AppCompatActivity() {
106106
Log.w(TAG, "Credential is not of type Google ID!")
107107
}
108108
}
109-
// [END create_google_id_token]
109+
// [END handle_sign_in]
110110

111111
// [START auth_with_google]
112112
private fun firebaseAuthWithGoogle(idToken: String) {
@@ -127,8 +127,11 @@ class GoogleSignInActivity : AppCompatActivity() {
127127
}
128128
// [END auth_with_google]
129129

130-
// [START clear_credential_stage]
131-
private fun clearCredentialState() {
130+
// [START sign_out]
131+
private fun signOut() {
132+
// Firebase sign out
133+
auth.signOut()
134+
132135
// When a user signs out, clear the current user credential state from all credential providers.
133136
lifecycleScope.launch {
134137
try {
@@ -140,7 +143,7 @@ class GoogleSignInActivity : AppCompatActivity() {
140143
}
141144
}
142145
}
143-
// [END clear_credential_stage]
146+
// [END sign_out]
144147

145148
private fun updateUI(user: FirebaseUser?) {
146149
}

0 commit comments

Comments
 (0)