fix: update adunitname in Firebase to map to instanceName in ironSource

Grant Kemp · Grant Kemp · commit 7665144cd0b2 · 2022-04-06T01:41:11.000+01:00
diff --git a/analytics/app/src/main/java/com/google/firebase/example/analytics/MainActivity.java b/analytics/app/src/main/java/com/google/firebase/example/analytics/MainActivity.java
@@ -259,7 +259,7 @@ public void onImpressionSuccess(ImpressionData impressionData) {
                 bundle.putString(FirebaseAnalytics.Param.AD_PLATFORM, "ironSource");
                 bundle.putString(FirebaseAnalytics.Param.AD_SOURCE, impressionData.getAdNetwork());
                 bundle.putString(FirebaseAnalytics.Param.AD_FORMAT, impressionData.getAdUnit());
-                bundle.putString(FirebaseAnalytics.Param.AD_UNIT_NAME, impressionData.getAdUnit());
+                bundle.putString(FirebaseAnalytics.Param.AD_UNIT_NAME, impressionData.getInstanceName());
                 bundle.putString(FirebaseAnalytics.Param.CURRENCY, "USD");
                 bundle.putDouble(FirebaseAnalytics.Param.VALUE, impressionData.getRevenue());
                 analytics.logEvent(FirebaseAnalytics.Event.AD_IMPRESSION, bundle);
diff --git a/analytics/app/src/main/java/com/google/firebase/example/analytics/kotlin/MainActivity.kt b/analytics/app/src/main/java/com/google/firebase/example/analytics/kotlin/MainActivity.kt
@@ -227,7 +227,7 @@ class MainActivity : AppCompatActivity(),
             param(FirebaseAnalytics.Param.AD_PLATFORM, "ironSource")
             param(FirebaseAnalytics.Param.AD_SOURCE, impressionData.adNetwork)
             param(FirebaseAnalytics.Param.AD_FORMAT, impressionData.adUnit)
-            param(FirebaseAnalytics.Param.AD_UNIT_NAME, impressionData.adUnit)
+            param(FirebaseAnalytics.Param.AD_UNIT_NAME, impressionData.instanceName)
             param(FirebaseAnalytics.Param.CURRENCY, "USD")
             param(FirebaseAnalytics.Param.VALUE, impressionData.revenue)
         }

Original file line number	Diff line number	Diff line change
`@@ -227,7 +227,7 @@ class MainActivity : AppCompatActivity(),`
`227`	`227`	`param(FirebaseAnalytics.Param.AD_PLATFORM, "ironSource")`
`228`	`228`	`param(FirebaseAnalytics.Param.AD_SOURCE, impressionData.adNetwork)`
`229`	`229`	`param(FirebaseAnalytics.Param.AD_FORMAT, impressionData.adUnit)`
`230`		`- param(FirebaseAnalytics.Param.AD_UNIT_NAME, impressionData.adUnit)`
	`230`	`+ param(FirebaseAnalytics.Param.AD_UNIT_NAME, impressionData.instanceName)`
`231`	`231`	`param(FirebaseAnalytics.Param.CURRENCY, "USD")`
`232`	`232`	`param(FirebaseAnalytics.Param.VALUE, impressionData.revenue)`
`233`	`233`	`}`